ci(a11y): axe-core gate + accessibility-tree snapshots (#222)
CI / Build & Quality Checks (push) Successful in 1m38s
CI / Docker image build & smoke test (push) Skipped
CI / Secret scan (gitleaks) (push) Successful in 8s
CI / Trigger Desktop Build (push) Successful in 9s
CI / Playwright smoke (e2e) (push) Successful in 8m52s

e2e/a11y.spec.ts runs @axe-core/playwright (WCAG 2.x A/AA) over the login
page, room timeline + composer, message options menu, thread panel, user
settings and room settings, failing on critical/serious findings other
than colour contrast (reported, not gated: generated avatar colours and
portal false positives). Aria snapshots of the composer, message menu,
thread panel and settings nav catch lost names/roles/live regions.

Burned down what the first run found:
- NavItem: callers' aria-selected is not valid on a div (axe critical);
  it now drives data-selected for styling and aria-current="page".
- Composer placeholder at 0.5 opacity was ~2.3:1; now P300.
- Voice-limit and explore custom-limit number inputs had no label.
- Thread panel is an <aside aria-label="Thread">; the settings modal is a
  role=dialog; the settings sections are a <nav>; the message action
  menu carries data-message-menu + a label.

Also allows WebKit's CI wording for the well-known probe ("Could not
connect … Connection refused") that failed run #2003.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PPmy3tPq869XDW4njjVaKA
This commit is contained in:
2026-09-20 13:25:57 -04:00
co-authored by Claude Opus 5
parent 52e0cfaa83
commit 6aa77552b8
18 changed files with 284 additions and 19 deletions
+2
View File
@@ -24,6 +24,8 @@ export function Modal500({ requestClose, children }: Modal500Props) {
<Modal
size="500"
variant="Background"
role="dialog"
aria-modal="true"
// On mobile expand to fill the viewport. On desktop fall back to the
// folds `size="500"` width (~50rem) — overriding maxWidth here would
// squish the two-pane settings layout.
+3 -1
View File
@@ -67,7 +67,9 @@ export const EditorTextarea = style([
export const EditorPlaceholderContainer = style([
DefaultReset,
{
opacity: config.opacity.Placeholder,
// [Gitea #222] folds' Placeholder opacity (0.5) lands at ~2.3:1 on the
// composer surface; P300 keeps it visibly secondary at AA contrast.
opacity: config.opacity.P300,
pointerEvents: 'none',
userSelect: 'none',
},
+29 -10
View File
@@ -9,16 +9,35 @@ export const NavItem = as<
{
highlight?: boolean;
} & css.RoomSelectorVariants
>(({ as: AsNavItem = 'div', className, highlight, variant, radii, children, ...props }, ref) => (
<AsNavItem
className={classNames(css.NavItem({ variant, radii }), className)}
data-highlight={highlight}
{...props}
ref={ref}
>
{children}
</AsNavItem>
));
>(
(
{
as: AsNavItem = 'div',
className,
highlight,
variant,
radii,
children,
'aria-selected': selected,
...props
},
ref,
) => (
// [Gitea #222] Callers pass `aria-selected`, but that attribute is only
// valid on option/tab/row roles; on a plain div axe flags it as critical.
// Keep the prop for callers and styling, expose the state as aria-current.
<AsNavItem
className={classNames(css.NavItem({ variant, radii }), className)}
data-highlight={highlight}
data-selected={selected === true || selected === 'true' ? true : undefined}
aria-current={selected === true || selected === 'true' ? 'page' : undefined}
{...props}
ref={ref}
>
{children}
</AsNavItem>
),
);
export const NavLink = forwardRef<HTMLAnchorElement, ComponentProps<typeof Link>>(
({ className, ...props }, ref) => (
+1 -1
View File
@@ -69,7 +69,7 @@ const NavItemBase = style({
[`&:has(.${NavLink}:active)`]: {
backgroundColor: ContainerActive,
},
'&[aria-selected=true]': {
'&[data-selected=true]': {
backgroundColor: ContainerActive,
},
[`&:has(.${NavLink}:focus-visible)`]: {
@@ -65,6 +65,7 @@ export function RoomVoiceLimit({ permissions }: RoomVoiceLimitProps) {
<Input
key={maxUsers}
name="limitInput"
aria-label="Voice channel participant limit"
defaultValue={maxUsers}
type="number"
min={0}
+1 -1
View File
@@ -1133,7 +1133,7 @@ export const Message = React.memo(
// The full action menu, shared by the desktop PopOut and the touch
// bottom sheet (#166).
const menuJSX = (
<Menu>
<Menu data-message-menu aria-label="Message actions">
<Box direction="Column" gap="100" className={css.MessageMenuGroup}>
{canSendReaction && (
<MenuItem
@@ -177,6 +177,8 @@ export function ThreadPanel({ room, threadId, requestClose }: ThreadPanelProps)
return (
<Box
as="aside"
aria-label="Thread"
className={classNames(css.ThreadPanel, ContainerColor({ variant: 'Background' }))}
shrink="No"
direction="Column"
+2 -2
View File
@@ -153,7 +153,7 @@ export function Settings({ initialPage, requestClose }: SettingsProps) {
</PageNavHeader>
<Box grow="Yes" direction="Column">
<PageNavContent>
<div style={{ flexGrow: 1 }}>
<nav aria-label="Settings sections" style={{ flexGrow: 1 }}>
{menuItems.map((item) => (
<MenuItem
key={item.name}
@@ -174,7 +174,7 @@ export function Settings({ initialPage, requestClose }: SettingsProps) {
</Text>
</MenuItem>
))}
</div>
</nav>
</PageNavContent>
<Box style={{ padding: config.space.S200 }} shrink="No" direction="Column">
<UseStateProvider initial={false}>