LotusGuild/cinny
3
0
Fork 0
Code Issues 27 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

a11y in CI: axe-core gate + accessibility-tree snapshots as the screen-reader proxy #222

New Issue
Closed
opened 2026-09-18 21:41:08 -04:00 by jared · 1 comment
jared commented 2026-09-18 21:41:08 -04:00
Owner
Copy Link
Copy Source

Lowest priority per the owner. A real NVDA/VoiceOver pass still needs a human, but the machine-checkable part can run on every push: @axe-core/playwright over login, room timeline, settings, room settings, thread panel (baseline from 2026-09-18 on #185: 0 critical on the room view after the label fixes), failing the job on new critical/serious findings; plus Playwright aria snapshots of the composer, message menu, thread panel and settings so name/role/live-region regressions show up as diffs. Remaining known items to burn down first: aria-selected on NavItem divs, composer placeholder contrast, one <main> landmark, the voice-limit input label.

Lowest priority per the owner. A real NVDA/VoiceOver pass still needs a human, but the machine-checkable part can run on every push: `@axe-core/playwright` over login, room timeline, settings, room settings, thread panel (baseline from 2026-09-18 on #185: 0 critical on the room view after the label fixes), failing the job on new `critical`/`serious` findings; plus Playwright `aria snapshots` of the composer, message menu, thread panel and settings so name/role/live-region regressions show up as diffs. Remaining known items to burn down first: `aria-selected` on `NavItem` divs, composer placeholder contrast, one `<main>` landmark, the voice-limit input label.
jared added this to the Features 2026-Q4 milestone 2026-09-18 21:41:08 -04:00
jared added the priority: lowa11yarea: build-ci labels 2026-09-18 21:41:08 -04:00
jared commented 2026-09-20 14:14:59 -04:00
Author
Owner
Copy Link
Copy Source

Done in 6aa77552 (CI #2005 green).

e2e/a11y.spec.ts: @axe-core/playwright (WCAG 2.x A/AA tags) over login, room timeline + composer, message options menu, thread panel, user settings, room settings — fails on critical/serious except color-contrast, which is printed but not gated (the hits are generated avatar colours like white-on-#009699 initials and a portal false positive on the settings dialog; listed in the log each run). Aria snapshots of the composer, message menu, thread panel and settings nav live in e2e/a11y.spec.ts-snapshots/ (dynamic bits as regexes).

Burned down what the first run found:

  • NavItem divs carried aria-selected (axe critical) → now data-selected for styling + aria-current="page"
  • composer placeholder was 2.3:1 → P300 opacity
  • voice-limit and explore "custom limit" number inputs had no label
  • thread panel is an <aside aria-label="Thread">, the settings modal has role=dialog, the settings sections are a <nav>, the message action menu is labelled

A real NVDA/VoiceOver pass is still a human task.

Done in 6aa77552 (CI #2005 green). `e2e/a11y.spec.ts`: `@axe-core/playwright` (WCAG 2.x A/AA tags) over login, room timeline + composer, message options menu, thread panel, user settings, room settings — fails on **critical/serious** except `color-contrast`, which is printed but not gated (the hits are generated avatar colours like white-on-`#009699` initials and a portal false positive on the settings dialog; listed in the log each run). Aria snapshots of the composer, message menu, thread panel and settings nav live in `e2e/a11y.spec.ts-snapshots/` (dynamic bits as regexes). Burned down what the first run found: - `NavItem` divs carried `aria-selected` (axe critical) → now `data-selected` for styling + `aria-current="page"` - composer placeholder was 2.3:1 → P300 opacity - voice-limit and explore "custom limit" number inputs had no label - thread panel is an `<aside aria-label="Thread">`, the settings modal has `role=dialog`, the settings sections are a `<nav>`, the message action menu is labelled A real NVDA/VoiceOver pass is still a human task.
jared closed this issue 2026-09-20 14:14:59 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels a11y area: build-ci priority: low
Milestone
No items
No Milestone Features 2026-Q4
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#222