LotusGuild/cinny
3
0
Fork 0
Code Issues 42 Pull Requests 2 Actions 1 Packages Projects Releases Wiki Activity

Starting a call in a voice room @room-pings every member when a moderator or admin starts it #295

New Issue
Closed
opened 2026-10-04 20:33:35 -04:00 by jared · 0 comments
jared commented 2026-10-04 20:33:35 -04:00
Owner
Copy Link
Copy Source

What happens
When the first person joins a voice room's call, Element Call sends an org.matrix.msc4075.rtc.notification with "m.mentions": {"room": true}. On the homeserver this matches the default push rule .m.rule.is_room_mention (notify + highlight) whenever the sender is allowed to notify the room (power ≥ notifications.room, default 50: moderators and admins).

Result: every member of the voice channel gets a highlighted @room notification each time a moderator or admin starts a call. Lotus Chat itself deliberately doesn't ring for call rooms (CallEmbedProvider skips room.isCallRoom()). But:

  • the room gets a red highlight badge;
  • members on other clients (Element on their phone, Element desktop) get a push notification;
  • Lotus counts it in unread totals and the document title.

Measured (local Synapse; Audit Main is admin of "Voice Lounge"; one call start per test run): Bob's /notifications lists 7 org.matrix.msc4075.rtc.notification events in that room, all with ["notify",{"set_tweak":"highlight"}], and the room's highlight_count is 9.

Why: CallEmbed.getWidget() appends sendNotificationType=notification for every non-DM StartCall* intent (src/app/plugins/call/CallEmbed.ts:254-256), so Element Call sends the room-wide mention.

Who: every voice channel in Lotus Guild with a moderator or admin who hops in first. That's essentially every evening.

Fix ideas

  • Don't request a notification when the room is a persistent voice channel: room.isCallRoom(), or the org.matrix.msc3401.call state that marks Lotus voice rooms. Only ask for ring in DMs, and perhaps notification in ordinary group rooms when someone explicitly starts a call.
  • Or keep it but without the room mention (so it lands under normal message rules).

Acceptance criteria: an admin starting a call in a voice room causes no highlight for other members (check /notifications); a DM call still rings.

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

**What happens** When the first person joins a voice room's call, Element Call sends an `org.matrix.msc4075.rtc.notification` with `"m.mentions": {"room": true}`. On the homeserver this matches the default push rule **`.m.rule.is_room_mention`** (`notify` + `highlight`) whenever the sender is allowed to notify the room (power ≥ `notifications.room`, default 50: moderators and admins). Result: every member of the voice channel gets a **highlighted @room notification** each time a moderator or admin starts a call. Lotus Chat itself deliberately doesn't *ring* for call rooms (`CallEmbedProvider` skips `room.isCallRoom()`). But: - the room gets a red highlight badge; - members on **other clients** (Element on their phone, Element desktop) get a push notification; - Lotus counts it in unread totals and the document title. **Measured** (local Synapse; Audit Main is admin of "Voice Lounge"; one call start per test run): Bob's `/notifications` lists 7 `org.matrix.msc4075.rtc.notification` events in that room, all with `["notify",{"set_tweak":"highlight"}]`, and the room's `highlight_count` is 9. **Why:** `CallEmbed.getWidget()` appends `sendNotificationType=notification` for every non-DM `StartCall*` intent (src/app/plugins/call/CallEmbed.ts:254-256), so Element Call sends the room-wide mention. **Who:** every voice channel in Lotus Guild with a moderator or admin who hops in first. That's essentially every evening. **Fix ideas** - Don't request a notification when the room is a persistent voice channel: `room.isCallRoom()`, or the `org.matrix.msc3401.call` state that marks Lotus voice rooms. Only ask for `ring` in DMs, and perhaps `notification` in ordinary group rooms when someone explicitly starts a call. - Or keep it but without the room mention (so it lands under normal message rules). **Acceptance criteria:** an admin starting a call in a voice room causes no highlight for other members (check `/notifications`); a DM call still rings. --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
jared added the bugpriority: mediumarea: calls labels 2026-10-04 20:33:35 -04:00
jared closed this issue 2026-10-17 20:38:38 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: calls bug priority: medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#295