LotusGuild/cinny
3
0
Fork 0
Code Issues 39 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

Call bar always shows 'Mute Screenshare Audio' (a speaker icon), even when nobody is sharing #277

New Issue
Closed
opened 2026-10-04 17:41:32 -04:00 by jared · 0 comments
jared commented 2026-10-04 17:41:32 -04:00
Owner
Copy Link
Copy Source

ScreenshareAudioButton is rendered whenever screensharing is allowed in the room (src/app/features/call/CallControls.tsx:237-244), not when someone is actually sharing. With no share in progress it appears as a plain speaker icon (VolumeHigh) right next to Deafen, so it reads like a speaker/volume control that does nothing (screenshot; also visible in the phone layout).

Fix: only render it while a screenshare with audio is active (local or remote), or at least while screenshare is true.

Screenshot

F20-call-bar.png

More context

Introduced by bb2e25de (2026-05-24, "mute screenshare audio independently").

Acceptance criteria: the button only appears while a screenshare with audio is being received (or sent); otherwise it's hidden on desktop and phone bars.

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

`ScreenshareAudioButton` is rendered whenever screensharing is **allowed** in the room (src/app/features/call/CallControls.tsx:237-244), not when someone is actually sharing. With no share in progress it appears as a plain speaker icon (`VolumeHigh`) right next to Deafen, so it reads like a speaker/volume control that does nothing (screenshot; also visible in the phone layout). **Fix:** only render it while a screenshare with audio is active (local or remote), or at least while `screenshare` is true. **Screenshot** ![F20-call-bar.png](https://code.lotusguild.org/attachments/84f8ff11-6b44-4617-b9f3-2ec95cf901da) ### More context **Introduced by** bb2e25de (2026-05-24, "mute screenshare audio independently"). **Acceptance criteria:** the button only appears while a screenshare **with audio** is being received (or sent); otherwise it's hidden on desktop and phone bars. --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
F20-call-bar.png
39 KiB
jared added the priority: lowuxarea: calls labels 2026-10-04 17:41:32 -04:00
jared closed this issue 2026-10-19 18:11:34 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: calls priority: low ux
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#277