Jared Vititoe

jared pushed to main at LotusGuild/tinker_tickets

2026-09-11 22:26:38 -04:00

b73a4c792c Merge development into main: dashboard status chart excludes Closed (#110)

78ee5fdf48 Exclude Closed tickets from the dashboard status breakdown chart (#110)

Compare 2 commits »

jared pushed to development at LotusGuild/tinker_tickets

2026-09-11 22:23:44 -04:00

78ee5fdf48 Exclude Closed tickets from the dashboard status breakdown chart (#110)

786674abf3 Merge development into main: user-activity fix + attachment thumbnails (#49, #98)

Compare 2 commits »

jared commented on issue LotusGuild/tinker_tickets#49

2026-09-11 22:20:13 -04:00

User Activity report: "Tickets Assigned" column filters by ticket creation date, not assignment date

Fixed in commit 80169de (merged to main in 786674a).

The 'Tickets Assigned' column filtered by tickets.created_at, so a ticket created outside the selected date range but assigned to a user…

jared closed issue LotusGuild/tinker_tickets#49

2026-09-11 22:20:13 -04:00

User Activity report: "Tickets Assigned" column filters by ticket creation date, not assignment date

jared commented on issue LotusGuild/tinker_tickets#98

2026-09-11 22:20:13 -04:00

Attachment 'thumbnails' are the full-size original image — no actual resized thumbnail is ever generated

Fixed in commit dcf9b0c (merged to main in 786674a).

The attachment grid's thumbnail pointed at the same download_attachment.php URL as the full-size original, so previewing a multi-MB…

jared closed issue LotusGuild/tinker_tickets#98

2026-09-11 22:20:13 -04:00

Attachment 'thumbnails' are the full-size original image — no actual resized thumbnail is ever generated

jared pushed to main at LotusGuild/tinker_tickets

2026-09-11 22:19:59 -04:00

786674abf3 Merge development into main: user-activity fix + attachment thumbnails (#49, #98)

dcf9b0cfa1 Generate real resized thumbnails for image attachments (#98)

80169de16d Fix User Activity report's Tickets Assigned column to use assignment date (#49)

Compare 3 commits »

jared pushed to development at LotusGuild/tinker_tickets

2026-09-11 22:17:40 -04:00

dcf9b0cfa1 Generate real resized thumbnails for image attachments (#98)

80169de16d Fix User Activity report's Tickets Assigned column to use assignment date (#49)

4aa83ffe58 Merge development into main: bulk-op atomicity docs + double-submit guard (#33, #36)

Compare 3 commits »

jared commented on issue LotusGuild/tinker_tickets#33

2026-09-11 21:58:59 -04:00

Bulk operations aren't actually atomic despite the docblock claiming so

Fixed in commit 844677b (merged to main in 4aa83ff).

processBulkOperation()'s docblock claimed the transaction 'ensures atomicity - either all tickets are updated or none are,' but that's only…

jared closed issue LotusGuild/tinker_tickets#33

2026-09-11 21:58:59 -04:00

Bulk operations aren't actually atomic despite the docblock claiming so

jared commented on issue LotusGuild/tinker_tickets#36

2026-09-11 21:58:59 -04:00

Bulk-action buttons have no double-submit guard

Fixed in commit 3fcd1cb (merged to main in 4aa83ff).

The 4 bulk-action confirm buttons (close/assign/priority/status) called their performBulk*() handler directly on click with no in-flight…

jared closed issue LotusGuild/tinker_tickets#36

2026-09-11 21:58:59 -04:00

Bulk-action buttons have no double-submit guard

jared pushed to main at LotusGuild/tinker_tickets

2026-09-11 21:58:46 -04:00

4aa83ffe58 Merge development into main: bulk-op atomicity docs + double-submit guard (#33, #36)

844677bbce Fix atomicity docblock and surface per-ticket bulk-op errors (#33)

3fcd1cbf0e Guard bulk-action buttons against double-submit (#36)

Compare 3 commits »

jared pushed to development at LotusGuild/tinker_tickets

2026-09-11 21:56:35 -04:00

844677bbce Fix atomicity docblock and surface per-ticket bulk-op errors (#33)

3fcd1cbf0e Guard bulk-action buttons against double-submit (#36)

3ab33d8df2 Merge development into main: concurrency/atomicity fixes (#34, #35, #37)

Compare 3 commits »

jared closed issue LotusGuild/tinker_tickets#37

2026-09-11 21:50:58 -04:00

Required-comment status-change flow isn't transactional (client and server)

jared commented on issue LotusGuild/tinker_tickets#34

2026-09-11 21:50:57 -04:00

Bulk operations: TOCTOU race on ticket status used for workflow validation

Fixed in d205a9577ae145fac12a0110c3260ab7e38c80d1 (commit d205a95, merged to main in 3ab33d8).

processBulkOperation() was validating each ticket's status/priority transition against a pre-transac…

jared closed issue LotusGuild/tinker_tickets#34

2026-09-11 21:50:57 -04:00

Bulk operations: TOCTOU race on ticket status used for workflow validation

jared commented on issue LotusGuild/tinker_tickets#35

2026-09-11 21:50:57 -04:00

create_ticket_api.php: dedup/escalation race can duplicate notifications or drop a real escalation

Fixed in commit 3778a59 (merged to main in 3ab33d8).

Two concurrent hwmonDaemon reports carrying the same dedup hash could both read the same pre-update ticket snapshot and each independently…

jared closed issue LotusGuild/tinker_tickets#35

2026-09-11 21:50:57 -04:00

create_ticket_api.php: dedup/escalation race can duplicate notifications or drop a real escalation

jared commented on issue LotusGuild/tinker_tickets#37

2026-09-11 21:50:57 -04:00

Required-comment status-change flow isn't transactional (client and server)

Fixed in commit 310dcd0 (merged to main in 3ab33d8).

A comment accompanying a status change (required or user-supplied) was posted via a separate, independent HTTP call (add_comment.php, or a…