LotusGuild/web_template
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

audit pass 15: type=button on JS createElement and innerHTML buttons

Browse Source 
- Toast close button: set closeEl.type = 'button' on createElement
- Combobox tag remove button: add type="button" to innerHTML string

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Jared Vititoe
2026-03-27 14:24:10 -04:00
parent bdf3ad085f
commit d651cfbe2c
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
base.js
+2 -1
View File
@@ -100,6 +100,7 @@
msgEl.textContent = message; msgEl.textContent = message;
const closeEl = document.createElement('button'); const closeEl = document.createElement('button');
closeEl.type = 'button';
closeEl.className = 'lt-toast-close'; closeEl.className = 'lt-toast-close';
closeEl.textContent = '✕'; closeEl.textContent = '✕';
closeEl.setAttribute('aria-label', 'Dismiss'); closeEl.setAttribute('aria-label', 'Dismiss');
@@ -1901,7 +1902,7 @@
if (!opt) return; if (!opt) return;
const tag = document.createElement('span'); const tag = document.createElement('span');
tag.className = 'lt-combobox-tag'; tag.className = 'lt-combobox-tag';
tag.innerHTML = `${escHtml(opt.label)}<button class="lt-combobox-tag-remove" data-value="${escHtml(v)}" aria-label="Remove ${escHtml(opt.label)}">✕</button>`; tag.innerHTML = `${escHtml(opt.label)}<button type="button" class="lt-combobox-tag-remove" data-value="${escHtml(v)}" aria-label="Remove ${escHtml(opt.label)}">✕</button>`;
inputWrap.insertBefore(tag, inputEl); inputWrap.insertBefore(tag, inputEl);
}); });
} }