jaredandClaude Opus 4.8
e0e92e326a
Security / PHP Security (semgrep) (push) Successful in 1m27s
Lint / Deploy (push) Successful in 4s
Lint / Notify on failure (push) Has been skipped
Lint / PHP (phpcs PSR-12) (push) Successful in 20s
Lint / JS (eslint) (push) Successful in 9s
Lint / PHP requirements (version + extensions) (push) Successful in 38s
- create_ticket_api.php: validate status (against TICKET_STATUSES) and priority (numeric 1-5). A non-numeric priority previously cast to 0 and escalated the ticket below P1 on the dedup/update path. - manage_workflows.php: reject empty/invalid from_status/to_status on POST and PUT (must be valid ticket statuses) so the workflow table can't be populated with bogus transitions. - TicketModel::getAllTickets: COUNT(*) OVER() rides on returned rows, so a page past the last row returned total/pages = 0. Fall back to a direct COUNT when an over-range page yields no rows, keeping pager math correct. - DashboardView: stop double-escaping category/type/assigned active-filter labels (they were htmlspecialchars'd into the label and again at output, rendering R&D as R&D); output escaping is retained. - check_duplicates.php / NotificationHelper::notifyWatchers: wrap the DB lookups in try/catch so a failed prepare/query degrades gracefully (advisory dup-check returns none; best-effort watcher notify is skipped) instead of fataling the request. Works whether mysqli throws or returns false. (manage_* endpoints already have a top-level try/catch.) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
113 lines
3.3 KiB
PHP
113 lines
3.3 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Check for duplicate tickets API
|
|
*
|
|
* Searches for tickets with similar titles using LIKE and SOUNDEX
|
|
*/
|
|
|
|
require_once __DIR__ . '/bootstrap.php';
|
|
require_once dirname(__DIR__) . '/helpers/ResponseHelper.php';
|
|
require_once dirname(__DIR__) . '/models/TicketModel.php';
|
|
|
|
// Only accept GET requests
|
|
if ($_SERVER['REQUEST_METHOD'] !== 'GET') {
|
|
ResponseHelper::error('Method not allowed', 405);
|
|
}
|
|
|
|
// Get title parameter
|
|
$title = isset($_GET['title']) ? trim($_GET['title']) : '';
|
|
|
|
if (strlen($title) < 5) {
|
|
ResponseHelper::success(['duplicates' => []]);
|
|
}
|
|
|
|
// Search for similar titles
|
|
// Use both LIKE for substring matching and SOUNDEX for phonetic matching
|
|
$duplicates = [];
|
|
|
|
// Prepare search term for LIKE
|
|
$searchTerm = '%' . $title . '%';
|
|
|
|
// Get SOUNDEX of title
|
|
$soundexTitle = soundex($title);
|
|
|
|
// Build visibility filter so users only see titles they have access to
|
|
$ticketModel = new TicketModel($conn);
|
|
$visFilter = $ticketModel->getVisibilityFilter($currentUser);
|
|
|
|
// First, search for exact substring matches (case-insensitive)
|
|
$sql = "SELECT ticket_id, title, status, priority, created_at
|
|
FROM tickets
|
|
WHERE (
|
|
title LIKE ?
|
|
OR SOUNDEX(title) = ?
|
|
)
|
|
AND status != 'Closed'
|
|
AND ({$visFilter['sql']})
|
|
ORDER BY created_at DESC
|
|
LIMIT 10";
|
|
|
|
$types = "ss" . $visFilter['types'];
|
|
$params = array_merge([$searchTerm, $soundexTitle], $visFilter['params']);
|
|
|
|
// Duplicate detection is advisory (it must not block ticket creation), so on any
|
|
// DB error degrade gracefully to "no duplicates" rather than fataling the request.
|
|
// mysqli may throw (default exception mode) or return false depending on config.
|
|
try {
|
|
$stmt = $conn->prepare($sql);
|
|
if (!$stmt) {
|
|
throw new RuntimeException('prepare failed: ' . $conn->error);
|
|
}
|
|
if (!empty($params)) {
|
|
$stmt->bind_param($types, ...$params);
|
|
}
|
|
$stmt->execute();
|
|
$result = $stmt->get_result();
|
|
} catch (Throwable $e) {
|
|
error_log('check_duplicates: ' . $e->getMessage());
|
|
ResponseHelper::success(['duplicates' => []]);
|
|
}
|
|
|
|
while ($row = $result->fetch_assoc()) {
|
|
// Calculate similarity score
|
|
$similarity = 0;
|
|
|
|
// Check for exact substring match
|
|
if (stripos($row['title'], $title) !== false) {
|
|
$similarity = 90;
|
|
// Check SOUNDEX match
|
|
} elseif (soundex($row['title']) === $soundexTitle) {
|
|
$similarity = 70;
|
|
// Check word overlap
|
|
} else {
|
|
$titleWords = array_map('strtolower', preg_split('/\s+/', $title));
|
|
$rowWords = array_map('strtolower', preg_split('/\s+/', $row['title']));
|
|
$matchingWords = array_intersect($titleWords, $rowWords);
|
|
$similarity = (count($matchingWords) / max(count($titleWords), 1)) * 60;
|
|
}
|
|
|
|
if ($similarity >= 30) {
|
|
$duplicates[] = [
|
|
'ticket_id' => $row['ticket_id'],
|
|
'title' => $row['title'],
|
|
'status' => $row['status'],
|
|
'priority' => $row['priority'],
|
|
'created_at' => $row['created_at'],
|
|
'similarity' => round($similarity)
|
|
];
|
|
}
|
|
}
|
|
|
|
$stmt->close();
|
|
|
|
// Sort by similarity descending
|
|
usort($duplicates, function ($a, $b) {
|
|
return $b['similarity'] - $a['similarity'];
|
|
});
|
|
|
|
// Limit to top 5
|
|
$duplicates = array_slice($duplicates, 0, 5);
|
|
|
|
ResponseHelper::success(['duplicates' => $duplicates]);
|