The partial-update controller (status transitions incl. requires_comment with the comment in the same transaction, field edits, visibility, audit delta, status-change notifications) was defined inline inside api/update_ticket.php, so nothing else could reuse it. Moved it verbatim to controllers/ApiTicketController.php so the MCP update_status tool can run the exact same code path as the web UI; update_ticket.php now just require_once's it. The class body is byte-identical to the original (diffed against HEAD, modulo the 4-space dedent). Verified the web endpoint over real HTTP with a real session + CSRF: Open -> In Progress succeeds, In Progress -> Closed without a comment is refused with requires_comment (400), and with a comment closes the ticket and persists the reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MGDKHiU5RJdo3dqQUDow3X
134 lines
4.3 KiB
PHP
134 lines
4.3 KiB
PHP
<?php
|
|
|
|
// Enable error reporting for debugging
|
|
require_once dirname(__DIR__) . '/helpers/ErrorHandler.php';
|
|
ErrorHandler::init();
|
|
|
|
// Apply rate limiting
|
|
require_once dirname(__DIR__) . '/middleware/RateLimitMiddleware.php';
|
|
RateLimitMiddleware::apply('api');
|
|
|
|
// Start output buffering to capture any errors
|
|
ob_start();
|
|
|
|
try {
|
|
// Load config
|
|
$configPath = dirname(__DIR__) . '/config/config.php';
|
|
require_once $configPath;
|
|
require_once dirname(__DIR__) . '/helpers/Database.php';
|
|
|
|
// Load models directly with absolute paths
|
|
$ticketModelPath = dirname(__DIR__) . '/models/TicketModel.php';
|
|
$commentModelPath = dirname(__DIR__) . '/models/CommentModel.php';
|
|
$auditLogModelPath = dirname(__DIR__) . '/models/AuditLogModel.php';
|
|
$workflowModelPath = dirname(__DIR__) . '/models/WorkflowModel.php';
|
|
|
|
require_once $ticketModelPath;
|
|
require_once $commentModelPath;
|
|
require_once $auditLogModelPath;
|
|
require_once $workflowModelPath;
|
|
require_once dirname(__DIR__) . '/helpers/NotificationHelper.php';
|
|
|
|
// Check authentication via session
|
|
if (session_status() === PHP_SESSION_NONE) {
|
|
session_start();
|
|
}
|
|
if (!isset($_SESSION['user']) || !isset($_SESSION['user']['user_id'])) {
|
|
ob_end_clean();
|
|
http_response_code(401);
|
|
header('Content-Type: application/json');
|
|
echo json_encode(['success' => false, 'error' => 'Authentication required']);
|
|
exit;
|
|
}
|
|
|
|
// CSRF Protection
|
|
require_once dirname(__DIR__) . '/middleware/CsrfMiddleware.php';
|
|
if ($_SERVER['REQUEST_METHOD'] === 'POST' || $_SERVER['REQUEST_METHOD'] === 'PUT') {
|
|
$csrfToken = $_SERVER['HTTP_X_CSRF_TOKEN'] ?? '';
|
|
if (!CsrfMiddleware::validateToken($csrfToken)) {
|
|
http_response_code(403);
|
|
header('Content-Type: application/json');
|
|
echo json_encode([
|
|
'success' => false,
|
|
'error' => 'Invalid CSRF token',
|
|
'csrf_token' => CsrfMiddleware::getToken()
|
|
]);
|
|
exit;
|
|
}
|
|
$GLOBALS['newCsrfToken'] = CsrfMiddleware::rotateToken();
|
|
}
|
|
|
|
$currentUser = $_SESSION['user'];
|
|
$userId = $currentUser['user_id'];
|
|
$isAdmin = $currentUser['is_admin'] ?? false;
|
|
|
|
require_once dirname(__DIR__) . '/controllers/ApiTicketController.php';
|
|
|
|
// Use centralized database connection
|
|
$conn = Database::getConnection();
|
|
|
|
// Check request method
|
|
if ($_SERVER['REQUEST_METHOD'] !== 'POST') {
|
|
throw new Exception("Method not allowed. Expected POST, got " . $_SERVER['REQUEST_METHOD']);
|
|
}
|
|
|
|
// Get POST data
|
|
$input = file_get_contents('php://input');
|
|
$data = json_decode($input, true);
|
|
|
|
if (!$data) {
|
|
ob_end_clean();
|
|
http_response_code(400);
|
|
header('Content-Type: application/json');
|
|
echo json_encode(['success' => false, 'error' => 'Invalid JSON data received']);
|
|
exit;
|
|
}
|
|
|
|
if (!isset($data['ticket_id'])) {
|
|
ob_end_clean();
|
|
http_response_code(400);
|
|
header('Content-Type: application/json');
|
|
echo json_encode(['success' => false, 'error' => 'Missing ticket_id parameter']);
|
|
exit;
|
|
}
|
|
|
|
$ticketId = trim((string)$data['ticket_id']);
|
|
|
|
// Initialize controller
|
|
$controller = new ApiTicketController($conn, $userId, $isAdmin, $currentUser);
|
|
|
|
// Update ticket
|
|
$result = $controller->update($ticketId, $data);
|
|
|
|
// Discard any output that might have been generated
|
|
ob_end_clean();
|
|
|
|
// Invalidate stats cache on successful ticket update
|
|
if (!empty($result['success'])) {
|
|
require_once dirname(__DIR__) . '/models/StatsModel.php';
|
|
(new StatsModel($conn))->invalidateCache();
|
|
}
|
|
|
|
// Return response
|
|
if (!empty($result['http_status'])) {
|
|
http_response_code($result['http_status']);
|
|
unset($result['http_status']);
|
|
}
|
|
header('Content-Type: application/json');
|
|
echo json_encode($result);
|
|
} catch (Exception $e) {
|
|
// Discard any output that might have been generated
|
|
ob_end_clean();
|
|
|
|
// Log error details but don't expose to client
|
|
error_log("Update ticket API error: " . $e->getMessage());
|
|
|
|
// Return error response
|
|
header('Content-Type: application/json');
|
|
http_response_code(500);
|
|
echo json_encode([
|
|
'success' => false,
|
|
'error' => 'An internal error occurred'
|
|
]);
|
|
}
|