Lint / PHP (phpcs PSR-12) (push) Successful in 17s
Lint / JS (eslint) (push) Successful in 7s
Lint / PHP requirements (version + extensions) (push) Successful in 20s
Lint / Notify on failure (push) Skipped
Security / PHP Security (semgrep) (push) Successful in 1m8s
Lint / Deploy (push) Successful in 2s
The attachment grid's <img> thumbnail pointed at the same download_attachment.php URL as the full-size original, so previewing a multi-MB photo attachment cost a full multi-MB download just to render a small grid preview. loading="lazy" only deferred off-screen images; it never reduced per-image transfer size. Generate a resized JPEG thumbnail (longest side capped at 300px) via GD at upload time, from the same metadata-stripped image stripImageMetadata() already produces, reusing its decompression-bomb guard (~40MP decode cap). Store the thumbnail's filename in a new nullable ticket_attachments. thumbnail_filename column (migration 005); NULL means no thumbnail exists (non-image, GD unavailable, or an attachment predating this change) and callers fall back to the full-size original. download_attachment.php serves the thumbnail when requested via ?thumb=1 and one exists, falling back to the original otherwise. The attachments grid now requests thumb=1 for its <img> preview; the lightbox link is unchanged and still opens the full-size original. delete_attachment.php removes the thumbnail file alongside the original, and cleanup_orphan_uploads.php's orphan lookup now also matches thumbnail_filename so generated thumbnails aren't swept up as orphans. Verified against real MariaDB + GD: a 1600x1200 test JPEG produced a 300x225 thumbnail at ~1.8KB vs. the 52KB original (~29x smaller); confirmed the serving logic picks the thumbnail for image attachments with one, falls back to the original for a non-image attachment even when thumb=1 is requested, and that the updated orphan-cleanup lookup matches both the original and thumbnail filename (and correctly finds neither for an unrelated filename). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117oBw2jN4kALYeS8HPq4zV
130 lines
4.6 KiB
PHP
130 lines
4.6 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Delete Attachment API
|
|
*
|
|
* Handles deletion of ticket attachments
|
|
*/
|
|
|
|
// Capture errors for debugging
|
|
require_once dirname(__DIR__) . '/helpers/ErrorHandler.php';
|
|
ErrorHandler::init();
|
|
|
|
// Apply rate limiting (also starts session)
|
|
require_once dirname(__DIR__) . '/middleware/RateLimitMiddleware.php';
|
|
RateLimitMiddleware::apply('api');
|
|
|
|
// Ensure session is started
|
|
if (session_status() === PHP_SESSION_NONE) {
|
|
session_start();
|
|
}
|
|
|
|
require_once dirname(__DIR__) . '/config/config.php';
|
|
require_once dirname(__DIR__) . '/helpers/Database.php';
|
|
require_once dirname(__DIR__) . '/helpers/ResponseHelper.php';
|
|
require_once dirname(__DIR__) . '/models/AttachmentModel.php';
|
|
require_once dirname(__DIR__) . '/models/AuditLogModel.php';
|
|
require_once dirname(__DIR__) . '/models/TicketModel.php';
|
|
require_once dirname(__DIR__) . '/middleware/CsrfMiddleware.php';
|
|
|
|
header('Content-Type: application/json');
|
|
|
|
// Check authentication
|
|
if (!isset($_SESSION['user']) || !isset($_SESSION['user']['user_id'])) {
|
|
ResponseHelper::unauthorized();
|
|
}
|
|
|
|
// Only accept DELETE or POST requests
|
|
if (!in_array($_SERVER['REQUEST_METHOD'], ['DELETE', 'POST'])) {
|
|
ResponseHelper::error('Method not allowed', 405);
|
|
}
|
|
|
|
// Get request body
|
|
$input = json_decode(file_get_contents('php://input'), true);
|
|
if ($_SERVER['REQUEST_METHOD'] === 'POST') {
|
|
$input = array_merge($_POST, $input ?? []);
|
|
}
|
|
|
|
// Verify CSRF token
|
|
$csrfToken = $input['csrf_token'] ?? $_SERVER['HTTP_X_CSRF_TOKEN'] ?? '';
|
|
if (!CsrfMiddleware::validateToken($csrfToken)) {
|
|
ResponseHelper::error('Invalid CSRF token', 403, ['csrf_token' => CsrfMiddleware::getToken()]);
|
|
}
|
|
|
|
// Get attachment ID
|
|
$attachmentId = isset($input['attachment_id']) ? (int)$input['attachment_id'] : 0;
|
|
if ($attachmentId <= 0 || (string)$attachmentId !== (string)($input['attachment_id'] ?? '')) {
|
|
ResponseHelper::error('Valid attachment ID is required');
|
|
}
|
|
|
|
try {
|
|
$attachmentModel = new AttachmentModel(Database::getConnection());
|
|
|
|
// Get attachment details
|
|
$attachment = $attachmentModel->getAttachment($attachmentId);
|
|
if (!$attachment) {
|
|
ResponseHelper::notFound('Attachment not found');
|
|
}
|
|
|
|
// Verify user can access the parent ticket
|
|
$ticketModel = new TicketModel(Database::getConnection());
|
|
$ticket = $ticketModel->getTicketById($attachment['ticket_id']);
|
|
if (!$ticket || !$ticketModel->canUserAccessTicket($ticket, $_SESSION['user'])) {
|
|
ResponseHelper::notFound('Attachment not found');
|
|
}
|
|
|
|
// Check permission (must be uploader or admin)
|
|
$isAdmin = $_SESSION['user']['is_admin'] ?? false;
|
|
if (!$attachmentModel->canUserDelete($attachmentId, $_SESSION['user']['user_id'], $isAdmin)) {
|
|
ResponseHelper::forbidden('You do not have permission to delete this attachment');
|
|
}
|
|
|
|
// Delete the file — use realpath() to prevent path traversal
|
|
$uploadDir = realpath($GLOBALS['config']['UPLOAD_DIR'] ?? dirname(__DIR__) . '/uploads');
|
|
$filePath = $uploadDir . '/' . $attachment['ticket_id'] . '/' . $attachment['filename'];
|
|
$realPath = realpath($filePath);
|
|
|
|
if ($realPath !== false) {
|
|
// Ensure the resolved path is still inside the upload directory
|
|
if (strncmp($realPath, $uploadDir . DIRECTORY_SEPARATOR, strlen($uploadDir) + 1) !== 0) {
|
|
ResponseHelper::forbidden('Access denied');
|
|
}
|
|
if (!unlink($realPath)) {
|
|
ResponseHelper::serverError('Failed to delete file');
|
|
}
|
|
}
|
|
|
|
// Delete the generated preview thumbnail alongside the original, if one exists.
|
|
if (!empty($attachment['thumbnail_filename'])) {
|
|
$thumbPath = $uploadDir . '/' . $attachment['ticket_id'] . '/' . $attachment['thumbnail_filename'];
|
|
$realThumbPath = realpath($thumbPath);
|
|
if ($realThumbPath !== false && strncmp($realThumbPath, $uploadDir . DIRECTORY_SEPARATOR, strlen($uploadDir) + 1) === 0) {
|
|
@unlink($realThumbPath);
|
|
}
|
|
}
|
|
|
|
// Delete from database
|
|
if (!$attachmentModel->deleteAttachment($attachmentId)) {
|
|
ResponseHelper::serverError('Failed to delete attachment record');
|
|
}
|
|
|
|
// Log the deletion
|
|
$conn = Database::getConnection();
|
|
$auditLog = new AuditLogModel($conn);
|
|
$auditLog->log(
|
|
$_SESSION['user']['user_id'],
|
|
'attachment_delete',
|
|
'ticket_attachments',
|
|
(string)$attachmentId,
|
|
[
|
|
'ticket_id' => $attachment['ticket_id'],
|
|
'filename' => $attachment['original_filename'],
|
|
'size' => $attachment['file_size']
|
|
]
|
|
);
|
|
|
|
ResponseHelper::success([], 'Attachment deleted successfully');
|
|
} catch (Exception $e) {
|
|
ResponseHelper::serverError('Failed to delete attachment');
|
|
}
|