LotusGuild/tinker_tickets
4
0
Fork 0
Code Issues 46 Pull Requests Actions Packages Projects Releases Wiki Activity

Two different 'clear filters' controls clear disjoint sets — no single click fully resets the dashboard #76

New Issue
Closed
opened 2026-09-01 00:07:12 -04:00 by jared · 1 comment
jared commented 2026-09-01 00:07:12 -04:00
Owner
Copy Link
Copy Source

Severity: Medium

assets/js/dashboard.js has two separate clear-filter code paths that clear different subsets of active filters:

  • The sidebar's own "Clear" button (initSidebarFilters's clearFiltersBtn, ~lines 359-368) clears status/category/type/the 6 real date fields, but never touches search, priority, or assigned_to.
  • The page-level "Clear All Filters" button (clearAllFilters, ~lines 290-310) clears search/status/priority/category/type/assigned_to but (per the related date-filter issue) not the real date fields.

Impact: Depending on which of the two a user clicks, some filter category always survives. There's no single control that reliably returns the dashboard to a truly unfiltered state.

Fix: Consolidate to one shared clear-filters function covering the complete, correct set of param names (search/status/priority/category/type/assigned_to + all 6 date fields), called by both buttons.

**Severity:** Medium `assets/js/dashboard.js` has two separate clear-filter code paths that clear different subsets of active filters: - The sidebar's own "Clear" button (`initSidebarFilters`'s `clearFiltersBtn`, ~lines 359-368) clears `status`/`category`/`type`/the 6 real date fields, but never touches `search`, `priority`, or `assigned_to`. - The page-level "Clear All Filters" button (`clearAllFilters`, ~lines 290-310) clears `search`/`status`/`priority`/`category`/`type`/`assigned_to` but (per the related date-filter issue) not the real date fields. **Impact:** Depending on which of the two a user clicks, some filter category always survives. There's no single control that reliably returns the dashboard to a truly unfiltered state. **Fix:** Consolidate to one shared clear-filters function covering the complete, correct set of param names (search/status/priority/category/type/assigned_to + all 6 date fields), called by both buttons.
jared added the priority/mediumux labels 2026-09-08 10:15:48 -04:00
jared commented 2026-09-08 21:18:22 -04:00
Author
Owner
Copy Link
Copy Source

Fixed and verified (real MariaDB/jsdom/curl-range as applicable). Merged to main in commit 23d94bf.

Fixed and verified (real MariaDB/jsdom/curl-range as applicable). Merged to main in commit 23d94bf.
jared closed this issue 2026-09-08 21:18:22 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
Bearer/internal API surface
 bug
Something is not working
 concurrency
Race condition / concurrency bug
 config
Configuration / deployment default
 data-integrity
Data correctness / schema / integrity issue
 dead-code
Unused / dead code cleanup
 documentation
README / docs accuracy
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-decision
Needs a maintainer decision, not clearly a bug
 notifications
Matrix / in-app notification bug
 performance
Performance or resource-usage concern
 priority/docs
Documentation-only gap
 priority/high
High-severity / high-impact issue
 priority/low
Low-severity / cosmetic issue
 priority/medium
Medium-severity issue
 question
More information is needed
 rate-limiting
Rate limiting behavior
 reliability
Reliability / error-handling gap
 security
Security or access-control impact
 ux
User-facing UX/functional bug
 wontfix
This won't be fixed
 workflow
Ticket status workflow engine
No labels priority/medium ux
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/tinker_tickets#76