sendAssignmentNotification() has the same missing-visibility-check gap as #46 #72

Open
opened 2026-09-01 00:07:10 -04:00 by jared · 0 comments
Owner

Severity: Medium

helpers/NotificationHelper.php::sendAssignmentNotification() (~lines 256-276), called from api/assign_ticket.php:74-78 — has no visibility parameter or check at all, same root gap as the already-filed #46 (sendTicketNotification/sendStatusChangeNotification), but in a separate function.

Impact: Assigning a user to a confidential/internal ticket broadcasts the ticket title to the shared Matrix notify list unconditionally when MATRIX_NOTIFY_ASSIGNMENTS=1.

Note: If #46 is fixed by only touching the two functions it literally names, this one will be missed — worth fixing together or cross-referencing explicitly.

Fix: Thread $ticket['visibility'] through this function too and redact/suppress the title for non-public tickets, matching the fix approach for #46.

**Severity:** Medium `helpers/NotificationHelper.php::sendAssignmentNotification()` (~lines 256-276), called from `api/assign_ticket.php:74-78` — has no visibility parameter or check at all, same root gap as the already-filed #46 (`sendTicketNotification`/`sendStatusChangeNotification`), but in a separate function. **Impact:** Assigning a user to a confidential/internal ticket broadcasts the ticket title to the shared Matrix notify list unconditionally when `MATRIX_NOTIFY_ASSIGNMENTS=1`. **Note:** If #46 is fixed by only touching the two functions it literally names, this one will be missed — worth fixing together or cross-referencing explicitly. **Fix:** Thread `$ticket['visibility']` through this function too and redact/suppress the title for non-public tickets, matching the fix approach for #46.
jared added the notificationspriority/mediumsecurity labels 2026-09-08 10:15:47 -04:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/tinker_tickets#72