cleanup_audit_log.php: unbounded single-statement DELETE risks lock contention on a large backlog #66

New Issue

2026-08-31T23:57:38-04:00

jared commented

2026-08-31 23:57:38 -04:00

Severity: Low

models/AuditLogModel.php::deleteOldLogs() (~lines 312-323), called daily by cron/cleanup_audit_log.php — a single unbounded DELETE FROM audit_log WHERE created_at < ?. created_at is indexed so row selection itself is efficient, but on a large qualifying row set (e.g. the first run after enabling/changing AUDIT_LOG_RETENTION_DAYS, or after the cron job silently failed to run for a while) an unbounded single-statement DELETE holds row locks for the full duration of the transaction — risking lock contention with the frequent concurrent INSERTs the audit log receives from live traffic (nearly every user action logs a row).

Fix: Batch the delete (e.g. DELETE ... ORDER BY created_at LIMIT 1000 in a loop until no rows remain) to bound lock hold time per statement.

**Severity:** Low `models/AuditLogModel.php::deleteOldLogs()` (~lines 312-323), called daily by `cron/cleanup_audit_log.php` — a single unbounded `DELETE FROM audit_log WHERE created_at < ?`. `created_at` is indexed so row selection itself is efficient, but on a large qualifying row set (e.g. the first run after enabling/changing `AUDIT_LOG_RETENTION_DAYS`, or after the cron job silently failed to run for a while) an unbounded single-statement `DELETE` holds row locks for the full duration of the transaction — risking lock contention with the frequent concurrent `INSERT`s the audit log receives from live traffic (nearly every user action logs a row). **Fix:** Batch the delete (e.g. `DELETE ... ORDER BY created_at LIMIT 1000` in a loop until no rows remain) to bound lock hold time per statement.

jared added the performance priority/low labels 2026-09-08 10:15:47 -04:00

jared referenced this issue from a commit

2026-09-08 11:59:38 -04:00

Batch the audit log retention DELETE to bound lock hold time (#66)

jared referenced this issue from a commit

2026-09-08 15:39:42 -04:00

Merge development into main: 15-issue triage + fix batch

Sign in to join this conversation.