LotusGuild/tinker_tickets
4
0
Fork 0
Code Issues 46 Pull Requests Actions Packages Projects Releases Wiki Activity

SLA priority-alert banner doesn't update when priority changes without a page reload #64

New Issue
Closed
opened 2026-08-31 23:57:37 -04:00 by jared · 1 comment
jared commented 2026-08-31 23:57:37 -04:00
Owner
Copy Link
Copy Source

Severity: Medium

views/TicketView.php:212-249 renders the P1/P2 SLA banner server-side based on $priorityNum at page-load time. assets/js/ticket.js:471-475's priority-change handler (updateTicketField('priority', ...)) only updates a data-priority attribute on .lt-frame-ticket — it never touches #priorityAlertBanner or the SLA progress bar.

Impact: Changing a ticket from P1→P3 in edit mode leaves the SLA breach banner and progress bar visibly showing (still counting up) until the page is reloaded. Conversely, raising a ticket from P3→P1 shows no SLA banner at all until reload, even though the SLA clock should now be actively running.

Fix: After a successful priority update, re-render (or show/hide) the SLA banner and progress bar client-side based on the new priority, matching what a fresh page load would show, instead of leaving stale server-rendered state on screen.

**Severity:** Medium `views/TicketView.php:212-249` renders the P1/P2 SLA banner server-side based on `$priorityNum` at page-load time. `assets/js/ticket.js:471-475`'s priority-change handler (`updateTicketField('priority', ...)`) only updates a `data-priority` attribute on `.lt-frame-ticket` — it never touches `#priorityAlertBanner` or the SLA progress bar. **Impact:** Changing a ticket from P1→P3 in edit mode leaves the SLA breach banner and progress bar visibly showing (still counting up) until the page is reloaded. Conversely, raising a ticket from P3→P1 shows no SLA banner at all until reload, even though the SLA clock should now be actively running. **Fix:** After a successful priority update, re-render (or show/hide) the SLA banner and progress bar client-side based on the new priority, matching what a fresh page load would show, instead of leaving stale server-rendered state on screen.
jared added the priority/mediumux labels 2026-09-08 10:15:47 -04:00
jared commented 2026-09-08 21:18:23 -04:00
Author
Owner
Copy Link
Copy Source

Fixed and verified (real MariaDB/jsdom/curl-range as applicable). Merged to main in commit 23d94bf.

Fixed and verified (real MariaDB/jsdom/curl-range as applicable). Merged to main in commit 23d94bf.
jared closed this issue 2026-09-08 21:18:23 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
Bearer/internal API surface
 bug
Something is not working
 concurrency
Race condition / concurrency bug
 config
Configuration / deployment default
 data-integrity
Data correctness / schema / integrity issue
 dead-code
Unused / dead code cleanup
 documentation
README / docs accuracy
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-decision
Needs a maintainer decision, not clearly a bug
 notifications
Matrix / in-app notification bug
 performance
Performance or resource-usage concern
 priority/docs
Documentation-only gap
 priority/high
High-severity / high-impact issue
 priority/low
Low-severity / cosmetic issue
 priority/medium
Medium-severity issue
 question
More information is needed
 rate-limiting
Rate limiting behavior
 reliability
Reliability / error-handling gap
 security
Security or access-control impact
 ux
User-facing UX/functional bug
 wontfix
This won't be fixed
 workflow
Ticket status workflow engine
No labels priority/medium ux
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/tinker_tickets#64