LotusGuild/tinker_tickets
4
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Advanced Search priority range and date range have no min≤max validation #61

New Issue
Closed
opened 2026-08-31 21:40:12 -04:00 by jared · 1 comment
jared commented 2026-08-31 21:40:12 -04:00
Owner
Copy Link
Copy Source

Severity: Low

assets/js/advanced-search.js (~lines 90-99 date range, ~lines 108-112 priority range) — a user can set priority_min=5, priority_max=1, or an end-date before a start-date; nothing blocks it client- or server-side in this flow. It's just silently sent as an unsatisfiable range, returning zero results with no explanation to the user.

Fix: Add simple client-side validation (swap or clamp min/max, or disable submit with an inline message) before building the filter query string.

**Severity:** Low `assets/js/advanced-search.js` (~lines 90-99 date range, ~lines 108-112 priority range) — a user can set `priority_min=5, priority_max=1`, or an end-date before a start-date; nothing blocks it client- or server-side in this flow. It's just silently sent as an unsatisfiable range, returning zero results with no explanation to the user. **Fix:** Add simple client-side validation (swap or clamp min/max, or disable submit with an inline message) before building the filter query string.
jared added the priority/lowux labels 2026-09-08 10:15:46 -04:00
jared commented 2026-09-08 20:46:39 -04:00
Author
Owner
Copy Link
Copy Source

Fixed and verified (real MariaDB/GD/jsdom/etc. as applicable). Merged to main in commit cef1689.

Fixed and verified (real MariaDB/GD/jsdom/etc. as applicable). Merged to main in commit cef1689.
jared closed this issue 2026-09-08 20:46:39 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
Bearer/internal API surface
 bug
Something is not working
 concurrency
Race condition / concurrency bug
 config
Configuration / deployment default
 data-integrity
Data correctness / schema / integrity issue
 dead-code
Unused / dead code cleanup
 documentation
README / docs accuracy
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-decision
Needs a maintainer decision, not clearly a bug
 notifications
Matrix / in-app notification bug
 performance
Performance or resource-usage concern
 priority/docs
Documentation-only gap
 priority/high
High-severity / high-impact issue
 priority/low
Low-severity / cosmetic issue
 priority/medium
Medium-severity issue
 question
More information is needed
 rate-limiting
Rate limiting behavior
 reliability
Reliability / error-handling gap
 security
Security or access-control impact
 ux
User-facing UX/functional bug
 wontfix
This won't be fixed
 workflow
Ticket status workflow engine
No labels priority/low ux
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/tinker_tickets#61