CreateTicketView.php uses raw browser confirm() instead of the project's showConfirmModal() convention #53

New Issue

2026-08-31T21:36:20-04:00

jared commented

2026-08-31 21:36:20 -04:00

Severity: Low (consistency / documented-convention violation)

views/CreateTicketView.php (~line 347) uses the native browser confirm() dialog to warn before a template overwrites in-progress title/description text. This directly violates README.md Developer Notes #21: "Never use browser confirm(). Use showConfirmModal(title, message, type, onConfirm)." Every other confirm-before-destructive-action flow in the app (delete field, delete transition, delete template, revoke key, etc.) correctly uses the styled showConfirmModal() — this is the one inconsistent spot, and also the one place where a template swap could silently blow away typed content if the browser's native dialog styling confuses a user into missing/dismissing it incorrectly.

Fix: Replace the confirm() call with showConfirmModal(...), matching every other destructive-action confirmation in the app.

**Severity:** Low (consistency / documented-convention violation) `views/CreateTicketView.php` (~line 347) uses the native browser `confirm()` dialog to warn before a template overwrites in-progress title/description text. This directly violates README.md Developer Notes #21: "Never use browser `confirm()`. Use `showConfirmModal(title, message, type, onConfirm)`." Every other confirm-before-destructive-action flow in the app (delete field, delete transition, delete template, revoke key, etc.) correctly uses the styled `showConfirmModal()` — this is the one inconsistent spot, and also the one place where a template swap could silently blow away typed content if the browser's native dialog styling confuses a user into missing/dismissing it incorrectly. **Fix:** Replace the `confirm()` call with `showConfirmModal(...)`, matching every other destructive-action confirmation in the app.

jared added the priority/low ux labels 2026-09-08 10:15:45 -04:00

jared referenced this issue from a commit

2026-09-08 11:59:38 -04:00

Use showConfirmModal() instead of browser confirm() for template overwrite (#53)

jared referenced this issue from a commit

2026-09-08 15:39:42 -04:00

Merge development into main: 15-issue triage + fix batch

Sign in to join this conversation.