LotusGuild/tinker_tickets
4
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

ESLint: ~20 empty catch blocks and ~6 loose equality comparisons in assets/js/ #44

New Issue
Closed
opened 2026-08-31 21:29:48 -04:00 by jared · 1 comment
jared commented 2026-08-31 21:29:48 -04:00
Owner
Copy Link
Copy Source

Severity: Low

eslint over assets/js/ returns 0 errors but 73 warnings, with two notable clusters:

  • ~20 no-empty: silently swallowed catch {} blocks. Worth a pass to at least console.debug/comment why each is intentionally ignored — a couple appear to mask real fetch failures rather than known-benign cases (e.g. Date parsing).
  • ~6 eqeqeq: loose ==/!= instead of ===/!== in dashboard.js/ticket.js (e.g. data.comment_id == x), comparing values of possibly-differing types. Low risk today but an easy source of a future type-coercion bug.

phpcs --standard=.phpcs.xml across the whole tree is clean (0 violations) — this issue is JS-only.

Fix: Sweep the empty catches to add at minimum a comment explaining why the error is safely ignored (or log it), and switch the flagged loose comparisons to strict equality.

**Severity:** Low `eslint` over `assets/js/` returns 0 errors but 73 warnings, with two notable clusters: - **~20 `no-empty`**: silently swallowed `catch {}` blocks. Worth a pass to at least `console.debug`/comment why each is intentionally ignored — a couple appear to mask real fetch failures rather than known-benign cases (e.g. `Date` parsing). - **~6 `eqeqeq`**: loose `==`/`!=` instead of `===`/`!==` in `dashboard.js`/`ticket.js` (e.g. `data.comment_id == x`), comparing values of possibly-differing types. Low risk today but an easy source of a future type-coercion bug. `phpcs --standard=.phpcs.xml` across the whole tree is clean (0 violations) — this issue is JS-only. **Fix:** Sweep the empty catches to add at minimum a comment explaining why the error is safely ignored (or log it), and switch the flagged loose comparisons to strict equality.
jared added the dead-codepriority/low labels 2026-09-08 10:15:44 -04:00
jared commented 2026-09-11 15:20:22 -04:00
Author
Owner
Copy Link
Copy Source

Fixed and verified (real eslint output, jsdom, README cross-checked against actual file tree). Merged to main in commit 5572f0b.

Fixed and verified (real eslint output, jsdom, README cross-checked against actual file tree). Merged to main in commit 5572f0b.
jared closed this issue 2026-09-11 15:20:22 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
Bearer/internal API surface
 bug
Something is not working
 concurrency
Race condition / concurrency bug
 config
Configuration / deployment default
 data-integrity
Data correctness / schema / integrity issue
 dead-code
Unused / dead code cleanup
 documentation
README / docs accuracy
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-decision
Needs a maintainer decision, not clearly a bug
 notifications
Matrix / in-app notification bug
 performance
Performance or resource-usage concern
 priority/docs
Documentation-only gap
 priority/high
High-severity / high-impact issue
 priority/low
Low-severity / cosmetic issue
 priority/medium
Medium-severity issue
 question
More information is needed
 rate-limiting
Rate limiting behavior
 reliability
Reliability / error-handling gap
 security
Security or access-control impact
 ux
User-facing UX/functional bug
 wontfix
This won't be fixed
 workflow
Ticket status workflow engine
No labels dead-code priority/low
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/tinker_tickets#44