LotusGuild/tinker_tickets
4
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Inconsistent FK ON DELETE behavior: bulk_operations.performed_by and ticket_templates.created_by default to RESTRICT #40

New Issue
Closed
opened 2026-08-31 21:29:46 -04:00 by jared · 1 comment
jared commented 2026-08-31 21:29:46 -04:00
Owner
Copy Link
Copy Source

Severity: Medium

In migrations/000_baseline.sql, tickets.created_by/updated_by/assigned_to, ticket_attachments.uploaded_by, ticket_dependencies.created_by, recurring_tickets.created_by/assigned_to, and api_keys.created_by all use ON DELETE SET NULL. But bulk_operations.performed_by (~line 72) and ticket_templates.created_by (~line 241) have no ON DELETE clause, which defaults to RESTRICT.

Impact: Deleting a user who ever ran a bulk operation or created a template will hard-fail at the DB level instead of nulling out the reference, breaking the pattern used everywhere else in the schema and potentially blocking legitimate user offboarding/cleanup.

Fix: Add a migration to change both FKs to ON DELETE SET NULL, matching the rest of the schema.

**Severity:** Medium In `migrations/000_baseline.sql`, `tickets.created_by/updated_by/assigned_to`, `ticket_attachments.uploaded_by`, `ticket_dependencies.created_by`, `recurring_tickets.created_by/assigned_to`, and `api_keys.created_by` all use `ON DELETE SET NULL`. But `bulk_operations.performed_by` (~line 72) and `ticket_templates.created_by` (~line 241) have no `ON DELETE` clause, which defaults to `RESTRICT`. **Impact:** Deleting a user who ever ran a bulk operation or created a template will hard-fail at the DB level instead of nulling out the reference, breaking the pattern used everywhere else in the schema and potentially blocking legitimate user offboarding/cleanup. **Fix:** Add a migration to change both FKs to `ON DELETE SET NULL`, matching the rest of the schema.
jared added the data-integritypriority/medium labels 2026-09-08 10:15:44 -04:00
jared commented 2026-09-08 20:46:35 -04:00
Author
Owner
Copy Link
Copy Source

Fixed and verified (real MariaDB/GD/jsdom/etc. as applicable). Merged to main in commit cef1689.

Fixed and verified (real MariaDB/GD/jsdom/etc. as applicable). Merged to main in commit cef1689.
jared closed this issue 2026-09-08 20:46:35 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
Bearer/internal API surface
 bug
Something is not working
 concurrency
Race condition / concurrency bug
 config
Configuration / deployment default
 data-integrity
Data correctness / schema / integrity issue
 dead-code
Unused / dead code cleanup
 documentation
README / docs accuracy
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-decision
Needs a maintainer decision, not clearly a bug
 notifications
Matrix / in-app notification bug
 performance
Performance or resource-usage concern
 priority/docs
Documentation-only gap
 priority/high
High-severity / high-impact issue
 priority/low
Low-severity / cosmetic issue
 priority/medium
Medium-severity issue
 question
More information is needed
 rate-limiting
Rate limiting behavior
 reliability
Reliability / error-handling gap
 security
Security or access-control impact
 ux
User-facing UX/functional bug
 wontfix
This won't be fixed
 workflow
Ticket status workflow engine
No labels data-integrity priority/medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/tinker_tickets#40