Dashboard chart click-to-filter discards other active filters #29

Open
opened 2026-08-31 21:29:39 -04:00 by jared · 0 comments
Owner

Severity: High

Follow-up to #22 (chart click-to-filter). views/DashboardView.php (~lines 294-299), gotoFilter() builds a brand-new URLSearchParams() containing only the 1-2 keys the clicked chart segment maps to, then does window.location.href = '/?' + qs. This discards every other active filter on the page (search text, saved-filter selection, date range, assignee, etc.) instead of merging into the current query string.

Repro: Apply any dashboard filter (e.g. search text "sda"), then click a priority-chart segment → lands on /?priority=2&status=... with the search term silently dropped, instead of the filtered+priority intersection the user expected.

Fix: Merge the chart segment's filter key(s) into the current URLSearchParams (parsed from location.search) instead of constructing a fresh one.

**Severity:** High Follow-up to #22 (chart click-to-filter). `views/DashboardView.php` (~lines 294-299), `gotoFilter()` builds a brand-new `URLSearchParams()` containing only the 1-2 keys the clicked chart segment maps to, then does `window.location.href = '/?' + qs`. This discards every other active filter on the page (search text, saved-filter selection, date range, assignee, etc.) instead of merging into the current query string. **Repro:** Apply any dashboard filter (e.g. search text "sda"), then click a priority-chart segment → lands on `/?priority=2&status=...` with the search term silently dropped, instead of the filtered+priority intersection the user expected. **Fix:** Merge the chart segment's filter key(s) into the *current* `URLSearchParams` (parsed from `location.search`) instead of constructing a fresh one.
jared added the priority/highux labels 2026-09-08 10:15:43 -04:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/tinker_tickets#29