LotusGuild/tinker_tickets
4
0
Fork 0
Code Issues 83 Pull Requests Actions Packages Projects Releases Wiki Activity

Requirements checker never verifies memory_limit/max_execution_time are set to sane values #106

New Issue
Open
opened 2026-09-01 00:21:13 -04:00 by jared · 0 comments
jared commented 2026-09-01 00:21:13 -04:00
Owner
Copy Link
Copy Source

Severity: Low

config/requirements.php (the documented "single source of truth" for runtime requirements) only checks PHP version (8.2+) and 6 extensions (ldap/mysqli/curl/mbstring/fileinfo/json). No ini_get('memory_limit') or max_execution_time check exists anywhere in config/requirements.php, scripts/check_requirements.php, or api/health.php. No app-level ini_set('memory_limit', ...) override exists anywhere either.

Impact: A deployment on a host with a low default memory_limit (e.g. shared-hosting-style 128M) passes the startup requirements check cleanly and only surfaces as a mysterious failure under real load — a large CSV export, an oversized dashboard query on a big install.

Fix: Add a memory_limit/max_execution_time sanity check (e.g. warn if memory_limit < 256M) to the requirements checker, alongside the existing PHP version/extension checks.

**Severity:** Low `config/requirements.php` (the documented "single source of truth" for runtime requirements) only checks PHP version (8.2+) and 6 extensions (ldap/mysqli/curl/mbstring/fileinfo/json). No `ini_get('memory_limit')` or `max_execution_time` check exists anywhere in `config/requirements.php`, `scripts/check_requirements.php`, or `api/health.php`. No app-level `ini_set('memory_limit', ...)` override exists anywhere either. **Impact:** A deployment on a host with a low default `memory_limit` (e.g. shared-hosting-style 128M) passes the startup requirements check cleanly and only surfaces as a mysterious failure under real load — a large CSV export, an oversized dashboard query on a big install. **Fix:** Add a memory_limit/max_execution_time sanity check (e.g. warn if memory_limit < 256M) to the requirements checker, alongside the existing PHP version/extension checks.
jared added the configpriority/low labels 2026-09-08 10:15:51 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
Bearer/internal API surface
 bug
Something is not working
 concurrency
Race condition / concurrency bug
 config
Configuration / deployment default
 data-integrity
Data correctness / schema / integrity issue
 dead-code
Unused / dead code cleanup
 documentation
README / docs accuracy
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-decision
Needs a maintainer decision, not clearly a bug
 notifications
Matrix / in-app notification bug
 performance
Performance or resource-usage concern
 priority/docs
Documentation-only gap
 priority/high
High-severity / high-impact issue
 priority/low
Low-severity / cosmetic issue
 priority/medium
Medium-severity issue
 question
More information is needed
 rate-limiting
Rate limiting behavior
 reliability
Reliability / error-handling gap
 security
Security or access-control impact
 ux
User-facing UX/functional bug
 wontfix
This won't be fixed
 workflow
Ticket status workflow engine
No labels config priority/low
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/tinker_tickets#106