LotusGuild/tinker_tickets
4
0
Fork 0
Code Issues 46 Pull Requests Actions Packages Projects Releases Wiki Activity

Attachment listing is completely unpaginated #100

New Issue
Closed
opened 2026-09-01 00:13:39 -04:00 by jared · 1 comment
jared commented 2026-09-01 00:13:39 -04:00
Owner
Copy Link
Copy Source

Severity: Low

AttachmentModel::getAttachments() has no LIMIT/OFFSET (unlike, e.g., the comment-pagination pattern already used elsewhere in the app), and api/upload_attachment.php's GET handler passes nothing through. renderAttachments() in assets/js/ticket.js then builds one HTML string containing every attachment for the ticket.

Impact: A ticket with hundreds of attachments loads them all in one API response and renders them all into one DOM grid — loading="lazy" softens the image-decode cost, but the JSON payload size, DOM node count, and delete/download button wiring all scale unbounded with attachment count.

Fix: Add pagination (limit/offset) to AttachmentModel::getAttachments() and the corresponding API/frontend, matching the pattern already used for comment pagination.

**Severity:** Low `AttachmentModel::getAttachments()` has no `LIMIT`/`OFFSET` (unlike, e.g., the comment-pagination pattern already used elsewhere in the app), and `api/upload_attachment.php`'s GET handler passes nothing through. `renderAttachments()` in `assets/js/ticket.js` then builds one HTML string containing every attachment for the ticket. **Impact:** A ticket with hundreds of attachments loads them all in one API response and renders them all into one DOM grid — `loading="lazy"` softens the image-decode cost, but the JSON payload size, DOM node count, and delete/download button wiring all scale unbounded with attachment count. **Fix:** Add pagination (limit/offset) to `AttachmentModel::getAttachments()` and the corresponding API/frontend, matching the pattern already used for comment pagination.
jared added the performancepriority/low labels 2026-09-08 10:15:50 -04:00
jared commented 2026-09-08 21:18:23 -04:00
Author
Owner
Copy Link
Copy Source

Fixed and verified (real MariaDB/jsdom/curl-range as applicable). Merged to main in commit 23d94bf.

Fixed and verified (real MariaDB/jsdom/curl-range as applicable). Merged to main in commit 23d94bf.
jared closed this issue 2026-09-08 21:18:23 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
api
Bearer/internal API surface
 bug
Something is not working
 concurrency
Race condition / concurrency bug
 config
Configuration / deployment default
 data-integrity
Data correctness / schema / integrity issue
 dead-code
Unused / dead code cleanup
 documentation
README / docs accuracy
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-decision
Needs a maintainer decision, not clearly a bug
 notifications
Matrix / in-app notification bug
 performance
Performance or resource-usage concern
 priority/docs
Documentation-only gap
 priority/high
High-severity / high-impact issue
 priority/low
Low-severity / cosmetic issue
 priority/medium
Medium-severity issue
 question
More information is needed
 rate-limiting
Rate limiting behavior
 reliability
Reliability / error-handling gap
 security
Security or access-control impact
 ux
User-facing UX/functional bug
 wontfix
This won't be fixed
 workflow
Ticket status workflow engine
No labels performance priority/low
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/tinker_tickets#100