tinker_tickets

Author	SHA1	Message	Date
jared	b841037130	Merge branch 'development'	2026-04-11 13:22:20 -04:00
jared	6b89a14a47	Fix ticket ID generation in create_ticket_api.php to avoid leading zeros Use random_int(100000000-999999999) so IDs are always 9 digits without a leading zero, matching the behaviour of TicketModel::createTicket(). The old sprintf('%09d', mt_rand(1, ...)) could produce IDs like 000123456 which broke PHP array key lookups elsewhere. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-11 13:06:08 -04:00
jared	d0c889a594	Fix leading-zero ticket ID in clone_ticket.php - Preserve source ticket ID as string (ctype_digit validation) instead of int-casting with (int) - Use $sourceTicket['ticket_id'] (canonical DB form) when creating the relates_to dependency and audit log entry; avoids storing "123456" instead of "000123456" which breaks string-based depends_on_id lookups in DependencyModel Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-11 13:02:49 -04:00
jared	ab0edd1325	Implement bulk_delete operation; validate operation types - TicketModel: add deleteTicket() that removes all child records (comments, watchers, dependencies, attachments, custom fields) then deletes the ticket and cleans up physical attachment files - BulkOperationsModel: add bulk_delete case to processBulkOperation() so the "Bulk Delete" UI button actually works instead of silently failing with N failures - bulk_operation.php: validate operation_type against whitelist to reject unknown operations early with a proper error Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-11 12:53:53 -04:00
jared	d295d64f85	Fix leading-zero ticket ID handling across API and UI - dashboard.js: use String(cb.value) instead of parseInt() in getSelectedTicketIds() so zero-padded IDs like 000123456 are preserved when sent to bulk_operation.php - DashboardView.php: remove (int) cast on data-ticket-id attribute for quick-status button; was stripping leading zeros - TicketView.php: remove (int) cast on export URL ticket_id param - update_ticket.php: preserve ticket_id as string via trim((string)...) - add_comment.php: preserve ticket_id as string; validate with ctype_digit instead of (int) cast so comments are stored with the canonical zero-padded ID matching the tickets table - export_tickets.php: validate singleId as string to avoid stripping leading zeros in the export endpoint - notifications.php: preserve ticket_id strings in URLs and ticket ownership checks; index myTicketIds by both int and string forms for robust lookup regardless of how audit_log stored the ID - TicketController.php: fix inline dependency insert — column was wrong (depends_on_ticket_id → depends_on_id) and bind types were wrong ("iii" → "ssi"); feature was silently broken Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-11 12:43:18 -04:00
jared	d6603d07f2	Fix bulk operation dropping tickets with leading-zero IDs, add query null-check bulk_operation.php: ticket ID validation was converting IDs to int then back to string, so '000123456' became '123456' which never matched the DB VARCHAR key, silently rejecting ~11% of tickets from bulk operations. Now validates with ctype_digit() to preserve leading zeros. TicketModel::getTicketsByIds(): changed intval() to strval() and bind type 'i' to 's' so VARCHAR ticket_id columns are queried consistently as strings. DashboardController::getCategoriesAndTypes(): added null check on query result before calling fetch_assoc() to prevent TypeError if query fails. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-10 22:29:37 -04:00

1 changed files with 6 additions and 1 deletions

									
										create_ticket_api.php
									
		+6
		-1
	
												View File
												
					@@ -333,7 +333,12 @@ if ($existing) {

					}

					}

					// No existing ticket — create a new one

					// No existing ticket — create a new one

					$ticket_id = sprintf('%09d', mt_rand(1, 999999999));

					// Use random_int range 100000000-999999999 to avoid leading-zero IDs

					try {

					    $ticket_id = (string)random_int(100000000, 999999999);

					} catch (Exception $e) {

					    $ticket_id = (string)mt_rand(100000000, 999999999);

					}

					$insertStmt = $conn->prepare(

					$insertStmt = $conn->prepare(

					    "INSERT INTO tickets (ticket_id, title, description, status, priority, category, type, hash, created_by)

					    "INSERT INTO tickets (ticket_id, title, description, status, priority, category, type, hash, created_by)

					     VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)"

					     VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)"

Compare commits

6 Commits

63092ac070 ... b841037130

Compare commits

6 Commits 63092ac070 ... b841037130

6 Commits

63092ac070 ... b841037130