6 Commits

Include renames

Author	SHA1	Message	Date
jaredandClaude Opus 4.8	b3bc3ab159	Harden recurring cron, bulk delete, error handling; fix semgrep CI ... Continued fixes from the multi-agent review: - recurring tickets cron: now that the parse error is fixed the job runs, exposing two latent bugs. (1) next_run_at was only advanced after the full success path, so any failure (e.g. a NULL created_by passed to the non-nullable assignTicket() $assignedBy -> TypeError) left it in the past and re-created a duplicate ticket every cron cycle. Added an atomic claimForRun() (conditional UPDATE gated on still-due) called BEFORE creation, which also prevents overlapping runs from double-creating. (2) The cron used a raw mysqli with no utf8mb4, corrupting non-ASCII content; it now uses Database::getConnection(). Also guard the assignment so created_by NULL falls back to the assignee. - bulk delete: attachment files were unlinked inside the DB transaction, so an atomic-mode rollback restored rows but the files were already gone. deleteTicket() can now defer file removal to the caller, and BulkOperationsModel deletes files only after a successful commit. - UserModel: back-tick the `groups` column (reserved word on MySQL 8.0.2+). - create_ticket_api.php: stop leaking raw DB/exception messages to callers; log server-side and return a generic error. (Also includes a pre-existing working-tree tweak that adds title to the manual-ticket dedupe hash.) - CI: semgrep install failed under PEP 668; add --break-system-packages. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-06-30 09:34:57 -04:00
jared	c90bdc8ac8	style: auto-fix 1340 phpcs PSR-12 violations via phpcbf; exclude MissingNamespace and SideEffects	2026-04-13 20:56:10 -04:00
jaredandClaude Sonnet 4.6	6e1ae01cac	Fix recurring ticket schedule edge cases in API and model ... - manage_recurring.php calculateNextRun(): expand monthly cap from 28→31 with proper last-day-of-month clamping (matches model fix); use split with ':00' append to handle malformed time strings without crashing; fix weekly day array to start at index 1 (not 0) so day=0 never maps to empty string and blows up DateTime - RecurringTicketModel::calculateNextRunTime(): same weekly day array fix (start at index 1) to eliminate '' → DateTime exception on day=0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-05 18:16:41 -04:00
jaredandClaude Sonnet 4.6	538baadd57	Add comment skeleton loaders, workflow validation, monthly schedule fix ... - TicketView.php: Show 3 lt-skeleton-card placeholders in the comment list while "Load more" fetches; skeletons are removed on resolve or error - ticket.css: Add .comment-skeleton margin spacing - WorkflowDesignerView.php + manage_workflows.php: Prevent creating/editing status transitions where from_status === to_status (client + server check) - RecurringTicketsView.php: Expand monthly day picker from 28 to 31 days (days 29-31 labelled "last day in short months") - RecurringTicketModel.php: Clamp monthly schedule day to last day of target month using format('t') instead of hard-capping at 28 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-05 18:09:53 -04:00
jaredandClaude Sonnet 4.6	c2cd923d32	fix: RecurringTicketModel INSERT bind_param type string mismatch ... next_run_at was typed 'i' (int) but stores a datetime string → should be 's'. is_active was typed 's' (string) but stores 0/1 boolean → should be 'i'. Positions 10-11 were swapped: 'ssssiiisssis' → 'ssssiiisssii'. The UPDATE method already had the correct types; only INSERT was affected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-04 22:37:22 -04:00
jaredandClaude Opus 4.5	be505b7312	Implement comprehensive improvement plan (Phases 1-6) ... Security (Phase 1-2): - Add SecurityHeadersMiddleware with CSP, X-Frame-Options, etc. - Add RateLimitMiddleware for API rate limiting - Add security event logging to AuditLogModel - Add ResponseHelper for standardized API responses - Update config.php with security constants Database (Phase 3): - Add migration 014 for additional indexes - Add migration 015 for ticket dependencies - Add migration 016 for ticket attachments - Add migration 017 for recurring tickets - Add migration 018 for custom fields Features (Phase 4-5): - Add ticket dependencies with DependencyModel and API - Add duplicate detection with check_duplicates API - Add file attachments with AttachmentModel and upload/download APIs - Add @mentions with autocomplete and highlighting - Add quick actions on dashboard rows Collaboration (Phase 5): - Add mention extraction in CommentModel - Add mention autocomplete dropdown in ticket.js - Add mention highlighting CSS styles Admin & Export (Phase 6): - Add StatsModel for dashboard widgets - Add dashboard stats cards (open, critical, unassigned, etc.) - Add CSV/JSON export via export_tickets API - Add rich text editor toolbar in markdown.js - Add RecurringTicketModel with cron job - Add CustomFieldModel for per-category fields - Add admin views: RecurringTickets, CustomFields, Workflow, Templates, AuditLog, UserActivity - Add admin APIs: manage_workflows, manage_templates, manage_recurring, custom_fields, get_users - Add admin routes in index.php Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-01-20 09:55:01 -05:00