4 Commits

Include renames

Author	SHA1	Message	Date
jaredandClaude Opus 4.8	9941fd2dfa	Address remaining review items: Synapse caching, cycle detection, cache/ratelimit/kanban ... - SynapseHelper: memoize username->Matrix-ID lookups per-request (incl. negative results) and add an overall time budget to resolveUsernames() plus a 2s connect timeout, so notifying N watchers with a slow/unreachable Synapse can't stall the request for N x 5s. (Chosen over async/queue per maintainer.) - DependencyModel: fix cycle detection treating 'blocks' and 'blocked_by' as the same edge direction. They are inverse relationships (single row each, no mirror row), so the traversal now walks a unified precedence graph (blocks: ticket-> depends_on; blocked_by: depends_on->ticket) and wouldCreateCycle normalizes the new edge's direction. Prevents both false-positive and missed cycles. - CacheHelper: anchor prefix-delete to exact key boundaries (bare prefix or prefix + '_' + md5) so delete('workflow') can't wipe a 'workflow_rules' cache. - RateLimitMiddleware: hold an exclusive flock across the per-IP counter's read-modify-write so concurrent requests can't both read N and write N+1 (undercounting past the limit). Fails open if the file can't be locked. - dashboard.js: kanban status update now uses lt.api.post (per no-raw-fetch convention) and reverts the card AND the optimistic column counts on failure (the old raw-fetch catch left the card moved without reverting). - BulkOperationsModel: document that bulk_status/bulk_close intentionally bypass workflow transition validation (admin override, by design). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-06-30 12:55:50 -04:00
jared	c90bdc8ac8	style: auto-fix 1340 phpcs PSR-12 violations via phpcbf; exclude MissingNamespace and SideEffects	2026-04-13 20:56:10 -04:00
jaredandClaude Sonnet 4.6	c3ab5c5716	Fix double URL-encoding of Matrix user ID in SynapseHelper ... rawurlencode($username) was called on line 38 (encoding the username), then rawurlencode($matrixId) was called on line 39 encoding the already- encoded string — causing %20 to become %2520 for usernames with special characters. Fixed by building $matrixId with the plain username and only encoding the full Matrix ID once in the URL path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-05 18:12:02 -04:00
jaredandClaude Sonnet 4.6	c8181e8076	feat: comment pagination, Matrix integration, Synapse mention resolution ... Comment pagination: - CommentModel: add getCommentCount(), paginated getCommentsByTicketId() with getThreadedCommentsPaged() for threading + LIMIT/OFFSET - TicketController: load first 50 root comments + total count on page load - api/get_comments.php: new AJAX endpoint for Load More (index.php routed) - TicketView: Load More button + buildCommentEl() JS renderer for AJAX comments; passes totalComments/commentOffset/isAdmin to window.ticketData Matrix integration: - NotificationHelper: add sendStatusChangeNotification(), sendCommentNotification(), sendMentionNotification(), sendAssignmentNotification() alongside existing sendTicketNotification(); internal fire() helper replaces duplicated cURL logic - SynapseHelper: new helper that resolves SSO usernames → Matrix IDs by querying Synapse Admin REST API directly (no caching, no stale data) - config.php: add SYNAPSE_ADMIN_URL, SYNAPSE_ADMIN_TOKEN, MATRIX_NOTIFY_COMMENTS, MATRIX_NOTIFY_ASSIGNMENTS config keys (all from .env) - api/update_ticket.php: fire status-change notification after successful save - api/add_comment.php: resolve @mentioned usernames via SynapseHelper and fire mention notification; fire general comment notification when MATRIX_NOTIFY_COMMENTS=1 - api/assign_ticket.php: fire assignment notification (resolves assignee via Synapse) when MATRIX_NOTIFY_ASSIGNMENTS=1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-29 21:34:16 -04:00