LotusGuild/tinker_tickets
4
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix deleteTicket crash when ticket_custom_fields table doesn't exist

Browse Source 
PHP 8.2 raises mysqli_sql_exception on prepare() for non-existent tables
rather than returning false. Wrap each child-table delete in try/catch and
silently skip tables that don't exist in all deployments, re-throwing for
unexpected errors.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Jared Vititoe
2026-04-11 14:09:34 -04:00
parent 60f23051a9
commit d21691a548
1 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
models/TicketModel.php
+16 -9
View File
@@ -747,16 +747,23 @@ class TicketModel {
]; ];
foreach ($children as $sql) { foreach ($children as $sql) {
$stmt = $this->conn->prepare($sql); try {
if (!$stmt) continue; $stmt = $this->conn->prepare($sql);
// ticket_dependencies uses two placeholders if (!$stmt) continue;
if (strpos($sql, 'depends_on_id') !== false) { // ticket_dependencies uses two placeholders
$stmt->bind_param('ss', $ticketId, $ticketId); if (strpos($sql, 'depends_on_id') !== false) {
} else { $stmt->bind_param('ss', $ticketId, $ticketId);
$stmt->bind_param('s', $ticketId); } else {
$stmt->bind_param('s', $ticketId);
}
$stmt->execute();
$stmt->close();
} catch (mysqli_sql_exception $e) {
// Skip optional tables that may not exist in all deployments
if (strpos($e->getMessage(), "doesn't exist") === false) {
throw $e;
}
} }
$stmt->execute();
$stmt->close();
} }
$stmt = $this->conn->prepare("DELETE FROM tickets WHERE ticket_id = ?"); $stmt = $this->conn->prepare("DELETE FROM tickets WHERE ticket_id = ?");