Address remaining review items: Synapse caching, cycle detection, cache/ratelimit/kanban

- SynapseHelper: memoize username->Matrix-ID lookups per-request (incl. negative results) and add an overall time budget to resolveUsernames() plus a 2s connect timeout, so notifying N watchers with a slow/unreachable Synapse can't stall the request for N x 5s. (Chosen over async/queue per maintainer.) - DependencyModel: fix cycle detection treating 'blocks' and 'blocked_by' as the same edge direction. They are inverse relationships (single row each, no mirror row), so the traversal now walks a unified precedence graph (blocks: ticket-> depends_on; blocked_by: depends_on->ticket) and wouldCreateCycle normalizes the new edge's direction. Prevents both false-positive and missed cycles. - CacheHelper: anchor prefix-delete to exact key boundaries (bare prefix or prefix + '_' + md5) so delete('workflow') can't wipe a 'workflow_rules' cache. - RateLimitMiddleware: hold an exclusive flock across the per-IP counter's read-modify-write so concurrent requests can't both read N and write N+1 (undercounting past the limit). Fails open if the file can't be locked. - dashboard.js: kanban status update now uses lt.api.post (per no-raw-fetch convention) and reverts the card AND the optimistic column counts on failure (the old raw-fetch catch left the card moved without reverting). - BulkOperationsModel: document that bulk_status/bulk_close intentionally bypass workflow transition validation (admin override, by design). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-06-30 12:55:50 -04:00
parent e0e92e326a
commit 9941fd2dfa
6 changed files with 128 additions and 61 deletions
@@ -104,6 +104,11 @@ class BulkOperationsModel
                $success = false;

                try {
+                    // NOTE: bulk_status / bulk_close intentionally do NOT run
+                    // WorkflowModel::isTransitionAllowed(). Bulk operations are an
+                    // admin-only escape hatch for forcing ticket states (e.g. mass
+                    // re-opening), so they bypass the workflow transition rules that
+                    // the single-ticket update path enforces. This is by design.
                    switch ($operation['operation_type']) {
                        case 'bulk_close':
                            // Get current ticket from pre-loaded batch