From 84b104a5012a16b72dd0322244508284a908682a Mon Sep 17 00:00:00 2001 From: Jared Vititoe Date: Sat, 4 Apr 2026 22:29:52 -0400 Subject: [PATCH] fix: various inline style cleanup, a11y improvements, and bind_param bug MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Replace style="text-align:center" with .lt-text-center utility class in WorkflowDesignerView, CustomFieldsView, error_403, error_404, DashboardView JS string - Replace style="margin-top:..." with .lt-mt-sm utility in WorkflowDesignerView - Switch comment-edit-raw data-store textareas to .is-hidden class (TicketView PHP + JS-rendered; ticket.js template literal) — these are never shown, only read via .value - Add aria-describedby="visibilityGroupsHint" + id on hint

in CreateTicketView - Fix bind_param type string bug in manage_workflows.php PUT handler: 'ssiiiii' → 'ssiiii' (7 type chars for 6 params caused binding error on workflow transition updates) Co-Authored-By: Claude Sonnet 4.6 --- api/manage_workflows.php | 2 +- assets/js/ticket.js | 2 +- views/CreateTicketView.php | 4 ++-- views/DashboardView.php | 2 +- views/TicketView.php | 5 ++--- views/admin/CustomFieldsView.php | 2 +- views/admin/WorkflowDesignerView.php | 12 ++++++------ views/error_403.php | 2 +- views/error_404.php | 2 +- 9 files changed, 16 insertions(+), 17 deletions(-) diff --git a/api/manage_workflows.php b/api/manage_workflows.php index 8244a54..812cc81 100644 --- a/api/manage_workflows.php +++ b/api/manage_workflows.php @@ -120,7 +120,7 @@ try { $stmt = $conn->prepare("UPDATE status_transitions SET from_status = ?, to_status = ?, requires_comment = ?, requires_admin = ?, is_active = ? WHERE transition_id = ?"); - $stmt->bind_param('ssiiiii', + $stmt->bind_param('ssiiii', $data['from_status'], $data['to_status'], $data['requires_comment'] ?? 0, diff --git a/assets/js/ticket.js b/assets/js/ticket.js index 2e4b282..3d9e17a 100644 --- a/assets/js/ticket.js +++ b/assets/js/ticket.js @@ -1528,7 +1528,7 @@ function submitReply(parentCommentId) {

${displayText}
- + `; diff --git a/views/CreateTicketView.php b/views/CreateTicketView.php index e08e72b..36a98f0 100644 --- a/views/CreateTicketView.php +++ b/views/CreateTicketView.php @@ -185,7 +185,7 @@ include __DIR__ . '/layout_header.php';

Everyone who is logged in can view this ticket.

- diff --git a/views/DashboardView.php b/views/DashboardView.php index c41ee9f..eb884fe 100644 --- a/views/DashboardView.php +++ b/views/DashboardView.php @@ -1269,7 +1269,7 @@ if (advForm) advForm.addEventListener('submit', performAdvancedSearch); (age ? '
Age' + esc(age) + '
' : '') + '' + '' + - '

Click "Open Full Ticket" for description, comments & attachments.

'; + '

Click "Open Full Ticket" for description, comments & attachments.

'; lt.rightDrawer.open('ticketPreviewDrawer'); } diff --git a/views/TicketView.php b/views/TicketView.php index aad3ad5..c4ca79d 100644 --- a/views/TicketView.php +++ b/views/TicketView.php @@ -596,9 +596,8 @@ $progressClass = $slaBreached ? 'lt-progress--red' : ($slaPct >= 75 ? 'lt-progr ? htmlspecialchars($comment['comment_text']) : nl2br(htmlspecialchars($comment['comment_text'])) ?> - @@ -1263,7 +1262,7 @@ document.addEventListener('DOMContentLoaded', function () { '
' + commentText + '
' + - '' + ''; diff --git a/views/admin/CustomFieldsView.php b/views/admin/CustomFieldsView.php index e10d3ab..df25272 100644 --- a/views/admin/CustomFieldsView.php +++ b/views/admin/CustomFieldsView.php @@ -50,7 +50,7 @@ include __DIR__ . '/../../views/layout_header.php'; - + ✓' : '—' ?> diff --git a/views/admin/WorkflowDesignerView.php b/views/admin/WorkflowDesignerView.php index aa610ac..171182a 100644 --- a/views/admin/WorkflowDesignerView.php +++ b/views/admin/WorkflowDesignerView.php @@ -31,13 +31,13 @@ include __DIR__ . '/../../views/layout_header.php'; $toCount = 0; if (isset($workflows)) { foreach ($workflows as $w) { if ($w['from_status'] === $status) $toCount++; } } ?> -
+
→ transition
-

+

Define which status transitions are allowed. This controls what options appear in the status dropdown on tickets.

@@ -69,17 +69,17 @@ include __DIR__ . '/../../views/layout_header.php'; - → + → - + ✓' : '—' ?> - + ✓' : '—' ?> - + ✓' : '✗' ?> diff --git a/views/error_403.php b/views/error_403.php index f6d2ec7..5395f02 100644 --- a/views/error_403.php +++ b/views/error_403.php @@ -10,7 +10,7 @@ include __DIR__ . '/../views/layout_header.php';
╚╝
[ 403 ] ACCESS DENIED
-
+

You do not have permission to access this resource.

← Dashboard
diff --git a/views/error_404.php b/views/error_404.php index 4d9450c..bcea315 100644 --- a/views/error_404.php +++ b/views/error_404.php @@ -10,7 +10,7 @@ include __DIR__ . '/../views/layout_header.php';
╚╝
[ 404 ] NOT FOUND
-
+

The page you requested does not exist.

← Dashboard