Redact ticket title for non-public tickets in create/status-change Matrix notifications (#46)

sendTicketNotification() and sendStatusChangeNotification() always sent
the ticket title to the shared MATRIX_NOTIFY_USERS list regardless of
visibility, unlike sendCommentNotification()/notifyWatchers() which
already redact the comment/activity preview for non-public tickets.
Creating or changing the status of a confidential ticket broadcast its
title to a shared Matrix room, defeating the point of the Confidential
visibility level.

Added a shared redactedTitle() helper and threaded visibility through
both functions (sendTicketNotification reads it from the existing
$ticketData['visibility'] key; sendStatusChangeNotification takes a new
optional parameter, wired up in both callers from the already-fetched
ticket row). Verified end-to-end with a local HTTP server capturing the
actual webhook payloads: public tickets pass the title through
unchanged, confidential/internal tickets get the redacted placeholder.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015nCxwFFsy8ouMWzn56rPVP

This commit is contained in:

jared

2026-09-08 21:49:06 -04:00

co-authored by

Claude Sonnet 5

parent 3664719148

commit 442cd1d6f6

3 changed files with 31 additions and 6 deletions

									
										api/ticket_status_api.php
									
		+2
		-1
	
												View File
												
				@@ -171,7 +171,8 @@ if ($currentStatus !== $newStatus) {

				        $currentStatus,

				        $newStatus,

				        (string)$ticket['title'],

				        $keyName

				        $keyName,

				        $ticket['visibility'] ?? 'public'

				    );

				    NotificationHelper::notifyWatchers(

				        $conn,