LotusGuild/tinker_tickets
4
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Use styled 404 page for missing/inaccessible tickets

Browse Source 
Replaces the bare "Ticket not found" text response with the shared
views/error_404.php partial so users see the full TDS-styled error page.
Also collapsed the two identical 404 branches into one check.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Jared Vititoe
2026-04-12 00:34:15 -04:00
parent f42ee8070f
commit 3e9f5e82db
1 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
controllers/TicketController.php
+3 -10
View File
@@ -36,16 +36,9 @@ class TicketController {
// Get ticket data // Get ticket data
$ticket = $this->ticketModel->getTicketById($id); $ticket = $this->ticketModel->getTicketById($id);
if (!$ticket) { if (!$ticket || !$this->ticketModel->canUserAccessTicket($ticket, $currentUser)) {
header("HTTP/1.0 404 Not Found"); http_response_code(404);
echo "Ticket not found"; include dirname(__DIR__) . '/views/error_404.php';
return;
}
// Check visibility access — return 404 rather than 403 to avoid leaking ticket existence
if (!$this->ticketModel->canUserAccessTicket($ticket, $currentUser)) {
header("HTTP/1.0 404 Not Found");
echo "Ticket not found";
return; return;
} }