From 10d5075f2dce421d6b770f2c47dc495ef7ac3e94 Mon Sep 17 00:00:00 2001 From: Jared Vititoe Date: Tue, 20 Jan 2026 16:53:00 -0500 Subject: [PATCH] fix: Fix duplicate session_start() in API files - Add session status check before starting session - Add error reporting settings for debugging - Prevents potential session conflicts with RateLimitMiddleware Co-Authored-By: Claude Opus 4.5 --- api/ticket_dependencies.php | 12 ++++++++++-- api/upload_attachment.php | 12 ++++++++++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/api/ticket_dependencies.php b/api/ticket_dependencies.php index b603d63..5242760 100644 --- a/api/ticket_dependencies.php +++ b/api/ticket_dependencies.php @@ -7,11 +7,19 @@ * DELETE: Remove a dependency */ -// Apply rate limiting +// Capture errors for debugging +ini_set('display_errors', 0); +error_reporting(E_ALL); + +// Apply rate limiting (also starts session) require_once dirname(__DIR__) . '/middleware/RateLimitMiddleware.php'; RateLimitMiddleware::apply('api'); -session_start(); +// Ensure session is started +if (session_status() === PHP_SESSION_NONE) { + session_start(); +} + require_once dirname(__DIR__) . '/config/config.php'; require_once dirname(__DIR__) . '/models/DependencyModel.php'; require_once dirname(__DIR__) . '/models/AuditLogModel.php'; diff --git a/api/upload_attachment.php b/api/upload_attachment.php index 275bc73..1520773 100644 --- a/api/upload_attachment.php +++ b/api/upload_attachment.php @@ -5,11 +5,19 @@ * Handles file uploads for ticket attachments */ -// Apply rate limiting +// Capture errors for debugging +ini_set('display_errors', 0); +error_reporting(E_ALL); + +// Apply rate limiting (also starts session) require_once dirname(__DIR__) . '/middleware/RateLimitMiddleware.php'; RateLimitMiddleware::apply('api'); -session_start(); +// Ensure session is started +if (session_status() === PHP_SESSION_NONE) { + session_start(); +} + require_once dirname(__DIR__) . '/config/config.php'; require_once dirname(__DIR__) . '/helpers/ResponseHelper.php'; require_once dirname(__DIR__) . '/models/AttachmentModel.php';