From d344b9b4b55916c2fd863b9944051d88aa9912f9 Mon Sep 17 00:00:00 2001 From: Jared Vititoe Date: Wed, 1 Jul 2026 22:19:39 -0400 Subject: [PATCH] fix(ci): make the SC1091 suppression in lotus_deploy.sh actually apply Shellcheck directives bind to the NEXT command; on the compound line `set -a; source /etc/lotus-deploy.env; set +a` the existing `# shellcheck disable=SC1091` bound to `set -a`, so the info-level SC1091 finding on the runtime-only env file still failed the lint workflow (find -exec shellcheck exits non-zero on any finding). Split the line so the directive sits directly above `source` (as `source=/dev/null`, the standard idiom for host-only env files). Verified with CI's exact invocation: `find . -name "*.sh" -exec shellcheck {} +` now exits 0 (shellcheck 0.9.0). No runtime behavior change. Co-Authored-By: Claude Fable 5 --- cinny/lotus_deploy.sh | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/cinny/lotus_deploy.sh b/cinny/lotus_deploy.sh index b3a1436..1d84d8a 100755 --- a/cinny/lotus_deploy.sh +++ b/cinny/lotus_deploy.sh @@ -15,8 +15,14 @@ echo "[$(date '+%Y-%m-%d %H:%M:%S')] ===== Deploy triggered =====" # Load secrets (auth tokens etc — not in git) if [ -f /etc/lotus-deploy.env ]; then - # shellcheck disable=SC1091 - set -a; source /etc/lotus-deploy.env; set +a + set -a + # This env file only exists on the deploy host at runtime, so shellcheck + # can't follow it. The directive must sit DIRECTLY above the `source` — + # on a compound `set -a; source …` line it binds to `set -a` and the + # SC1091 finding still fails CI. + # shellcheck source=/dev/null + source /etc/lotus-deploy.env + set +a fi cd "$REPO"