Missing Timeout on Multiple Subprocess Calls #9

New Issue

jared · 2026-02-02T14:46:16-05:00

jared commented

2026-02-02 14:46:16 -05:00

Several subprocess calls lack timeouts (potential hangs):

Line 577: subprocess.run(['dmesg', '-T', '--level=err,warn'], ...) ✓ Has timeout

Line 1145: subprocess.run(['smartctl', '-i', device], ...) ❌ Missing timeout

Line 1440: subprocess.run(['smartctl', '-A', '-H', '-l', 'error'...], ...) ✓ Has timeout

Add timeouts to all subprocess calls:

result = subprocess.run(['smartctl', '-i', device],
stdout=subprocess.PIPE, stderr=subprocess.PIPE,
text=True, timeout=30) # Add this

Several subprocess calls lack timeouts (potential hangs): Line 577: subprocess.run(['dmesg', '-T', '--level=err,warn'], ...) ✓ Has timeout Line 1145: subprocess.run(['smartctl', '-i', device], ...) ❌ Missing timeout Line 1440: subprocess.run(['smartctl', '-A', '-H', '-l', 'error'...], ...) ✓ Has timeout Add timeouts to all subprocess calls: result = subprocess.run(['smartctl', '-i', device], stdout=subprocess.PIPE, stderr=subprocess.PIPE, text=True, timeout=30) # Add this

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: LotusGuild/hwmonDaemon#9