From a34b59ad36cbcdae72c797f3292443a38f5ef235 Mon Sep 17 00:00:00 2001 From: Jared Vititoe Date: Wed, 14 May 2025 21:01:40 -0400 Subject: [PATCH] Updated drive firmware checks --- hwmonDaemon.py | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/hwmonDaemon.py b/hwmonDaemon.py index 0df448c..be32953 100644 --- a/hwmonDaemon.py +++ b/hwmonDaemon.py @@ -931,13 +931,16 @@ class SystemHealthMonitor: # Check against known problematic versions if firmware_info['manufacturer'] and firmware_info['model']: - for model, versions in self.PROBLEMATIC_FIRMWARE[firmware_info['manufacturer']].items(): - if model in firmware_info['model'] and firmware_info['version'] in versions: - firmware_info['is_problematic'] = True - firmware_info['known_issues'].append( - f"Known problematic firmware version {firmware_info['version']} " - f"for {firmware_info['model']}" - ) + # Check if manufacturer exists in our problematic firmware database + if firmware_info['manufacturer'] in self.PROBLEMATIC_FIRMWARE: + for model, versions in self.PROBLEMATIC_FIRMWARE[firmware_info['manufacturer']].items(): + if model in firmware_info['model'] and firmware_info['version'] in versions: + firmware_info['is_problematic'] = True + firmware_info['known_issues'].append( + f"Known problematic firmware version {firmware_info['version']} " + f"for {firmware_info['model']}" + ) + logger.debug(f"=== Firmware Check for {device} ===") logger.debug(f"Firmware version: {firmware_info['version']}") logger.debug(f"Model: {firmware_info['model']}")