Only trust Authelia identity headers from the proxy
Lint / JS (eslint) (push) Successful in 7s
Lint / Python (flake8) (push) Successful in 1m9s
Lint / Notify on failure (push) Skipped
Lint / Deploy (push) Skipped
Security / Python Security (bandit) (push) Successful in 1m33s
Test / Python Tests (pytest) (push) Successful in 1m54s
Lint / Python (flake8) (pull_request) Successful in 1m19s
Lint / JS (eslint) (pull_request) Successful in 7s
Lint / Notify on failure (pull_request) Skipped
Lint / Deploy (pull_request) Skipped
Security / Python Security (bandit) (pull_request) Successful in 1m16s
Test / Python Tests (pytest) (pull_request) Successful in 1m29s
Lint / JS (eslint) (push) Successful in 7s
Lint / Python (flake8) (push) Successful in 1m9s
Lint / Notify on failure (push) Skipped
Lint / Deploy (push) Skipped
Security / Python Security (bandit) (push) Successful in 1m33s
Test / Python Tests (pytest) (push) Successful in 1m54s
Lint / Python (flake8) (pull_request) Successful in 1m19s
Lint / JS (eslint) (pull_request) Successful in 7s
Lint / Notify on failure (pull_request) Skipped
Lint / Deploy (pull_request) Skipped
Security / Python Security (bandit) (pull_request) Successful in 1m16s
Test / Python Tests (pytest) (pull_request) Successful in 1m29s
Remote-User/Name/Email/Groups were read from every request, so a LAN host connecting to the container directly could claim any user and group. Add auth.trusted_proxies and ignore those headers unless the request came from one of them: the X-Real-IP the local nginx sets, or the peer address when gunicorn is reached directly. With nothing configured, nobody is trusted. Rejected attempts are logged, and /api/avatar now uses the same check. The container's nginx site blanks the same headers for non-NPM sources (pve-infra 4e3ab7c). Closes #3 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
93828b38e9
commit
5c4e4dc099
3 files changed
+102
-7
No files matched your search
+47
-2
@@ -10,7 +10,10 @@ sys.path.insert(0, os.path.dirname(os.path.dirname(__file__)))
|
||||
|
||||
import app as gandalf # noqa: E402
|
||||
|
||||
AUTH = {'Remote-User': 'jared', 'Remote-Name': 'Jared V', 'Remote-Groups': 'admin'}
|
||||
PROXY = '10.0.0.27'
|
||||
# What the local nginx forwards for a request that came through the Authelia proxy
|
||||
AUTH = {'Remote-User': 'jared', 'Remote-Name': 'Jared V', 'Remote-Groups': 'admin', 'X-Real-IP': PROXY}
|
||||
CONFIG = {'auth': {'allowed_groups': ['admin'], 'trusted_proxies': [PROXY]}, 'ticket_api': {}}
|
||||
STATE = {
|
||||
'network_snapshot': json.dumps({
|
||||
'hosts': {'large1': {'ip': '10.0.0.2', 'status': 'up', 'source': 'prometheus', 'interfaces': {'eth0': 'up'}}},
|
||||
@@ -32,10 +35,52 @@ def client():
|
||||
db.count_active_events.return_value = 0
|
||||
db.get_status_summary.return_value = {'critical': 0, 'warning': 0, 'info': 0, 'resolved_24h': 0}
|
||||
db.check_suppressed.return_value = False
|
||||
with patch.object(gandalf, '_cfg', {'auth': {'allowed_groups': ['admin']}, 'ticket_api': {}}):
|
||||
with patch.object(gandalf, '_cfg', CONFIG):
|
||||
yield gandalf.app.test_client()
|
||||
|
||||
|
||||
class TestIdentityHeaderTrust:
|
||||
def test_proxy_identity_is_accepted(self, client):
|
||||
assert client.get('/api/devices', headers=AUTH).status_code == 200
|
||||
|
||||
def test_lan_client_through_nginx_cannot_claim_a_user(self, client):
|
||||
spoofed = dict(AUTH, **{'X-Real-IP': '10.0.0.99'})
|
||||
assert client.get('/api/devices', headers=spoofed).status_code == 401
|
||||
|
||||
def test_loopback_without_nginx_source_is_untrusted(self, client):
|
||||
spoofed = {k: v for k, v in AUTH.items() if k != 'X-Real-IP'}
|
||||
assert client.get('/api/devices', headers=spoofed).status_code == 401
|
||||
|
||||
def test_direct_peer_cannot_borrow_the_proxy_address(self, client):
|
||||
resp = client.get('/api/devices', headers=AUTH, environ_base={'REMOTE_ADDR': '10.0.0.99'})
|
||||
assert resp.status_code == 401
|
||||
|
||||
def test_proxy_connecting_directly_is_trusted(self, client):
|
||||
resp = client.get('/api/devices', headers=AUTH, environ_base={'REMOTE_ADDR': PROXY})
|
||||
assert resp.status_code == 200
|
||||
|
||||
def test_fails_closed_without_trusted_proxies(self, client):
|
||||
with patch.object(gandalf, '_cfg', {'auth': {'allowed_groups': ['admin']}}):
|
||||
assert client.get('/api/devices', headers=AUTH).status_code == 401
|
||||
|
||||
def test_cidr_entries_and_bad_entries(self, client):
|
||||
cfg = {'auth': {'allowed_groups': ['admin'], 'trusted_proxies': ['not-an-ip', '10.0.0.0/24']}}
|
||||
with patch.object(gandalf, '_cfg', cfg):
|
||||
assert client.get('/api/devices', headers=AUTH).status_code == 200
|
||||
|
||||
def test_garbage_source_header_is_untrusted(self, client):
|
||||
assert client.get('/api/devices', headers=dict(AUTH, **{'X-Real-IP': 'not-an-ip'})).status_code == 401
|
||||
|
||||
def test_rejection_is_logged(self, client, caplog):
|
||||
client.get('/api/devices', headers=dict(AUTH, **{'X-Real-IP': '10.0.0.99'}))
|
||||
assert "untrusted source '10.0.0.99'" in caplog.text
|
||||
|
||||
def test_avatar_ignores_untrusted_identity(self, client):
|
||||
with patch.object(gandalf, '_config', return_value=dict(CONFIG, ldap={'host': 'h', 'bind_dn': 'b'})):
|
||||
resp = client.get('/api/avatar', headers=dict(AUTH, **{'X-Real-IP': '10.0.0.99'}))
|
||||
assert resp.status_code == 401
|
||||
|
||||
|
||||
class TestPagesAndNav:
|
||||
def test_home_has_search_and_no_link_debug(self, client):
|
||||
html = client.get('/', headers=AUTH).get_data(as_text=True)
|
||||
|
||||
Reference in new issue
Block a user