From 3dfcd5903a7bc7cc57960fb75dc10bc4acc84b3e Mon Sep 17 00:00:00 2001
From: Jared Vititoe <jjvititoe1@gmail.com>
Date: Mon, 13 Apr 2026 22:23:26 -0400
Subject: [PATCH] ci: add flake8 lint workflow; fix unused imports

Adds .gitea/workflows/lint.yml running flake8 with .flake8 config.
Removes unused imports (flask.redirect, flask.url_for, time, typing.Tuple).
Config ignores E221/E305 (intentional column alignment and function spacing).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 .flake8                   |  6 ++++++
 .gitea/workflows/lint.yml | 20 ++++++++++++++++++++
 app.py                    |  3 ++-
 diagnose.py               |  3 +--
 4 files changed, 29 insertions(+), 3 deletions(-)
 create mode 100644 .flake8
 create mode 100644 .gitea/workflows/lint.yml

diff --git a/.flake8 b/.flake8
new file mode 100644
index 0000000..b353c07
--- /dev/null
+++ b/.flake8
@@ -0,0 +1,6 @@
+[flake8]
+max-line-length = 120
+# E221: multiple spaces before operator — intentional column alignment
+# E305: two blank lines after function — relaxed for module-level code
+extend-ignore = E221, E305
+exclude = __pycache__, .git
diff --git a/.gitea/workflows/lint.yml b/.gitea/workflows/lint.yml
new file mode 100644
index 0000000..b4c5095
--- /dev/null
+++ b/.gitea/workflows/lint.yml
@@ -0,0 +1,20 @@
+name: Lint
+
+on:
+  push:
+    branches: ["**"]
+  pull_request:
+    branches: ["**"]
+
+jobs:
+  python-lint:
+    name: Python (flake8)
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Install flake8
+        run: pip install flake8
+
+      - name: Run flake8
+        run: flake8 .
diff --git a/app.py b/app.py
index 3d93f0c..ae49d10 100644
--- a/app.py
+++ b/app.py
@@ -13,7 +13,7 @@ import time
 import uuid
 from functools import wraps
 
-from flask import Flask, jsonify, redirect, render_template, request, url_for
+from flask import Flask, jsonify, render_template, request
 
 import db
 import diagnose
@@ -42,6 +42,7 @@ def inject_config():
         }
     }
 
+
 # In-memory diagnostic job store { job_id: { status, result, created_at } }
 _diag_jobs: dict = {}
 _diag_lock = threading.Lock()
diff --git a/diagnose.py b/diagnose.py
index 30e2fb4..e2140c3 100644
--- a/diagnose.py
+++ b/diagnose.py
@@ -6,9 +6,8 @@ Executed in a background thread; results stored in _diag_jobs (app.py).
 """
 import re
 import shlex
-import time
 import logging
-from typing import Dict, List, Optional, Tuple
+from typing import Dict, List, Optional
 
 logger = logging.getLogger('gandalf.diagnose')