Lotus CIandClaude Opus 5.5
e0eecc5271
The host used to add PTT/deafen key listeners to this frame's window,
which needs same-origin access. Now it sends `io.lotus.set_hotkeys
{ codes }` and the fork reports those keys as `io.lotus.hotkey`
(keydown/keyup with modifiers + whether the target is a text field or a
button), plus window focus changes so a held PTT is released. The
default action is cancelled here with the host's rules (not while typing,
not on a focused button). `controls_state` carries `hotkeys: true`.
Fixes a live bug: EC's own shortcuts (M = toggle mic, Space = PTT) also
fired for the host's keys, so with focus in the call and the default
deafen key M, the first press turned the MIC ON instead of deafening
(even in push-to-talk mode). EC's shortcuts now ignore keys the host owns.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PPmy3tPq869XDW4njjVaKA
51 lines
1.8 KiB
TypeScript
51 lines
1.8 KiB
TypeScript
/*
|
|
Copyright 2026 Lotus Guild
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
|
Please see LICENSE in the repository root for full details.
|
|
*/
|
|
|
|
import { describe, expect, it } from "vitest";
|
|
|
|
import {
|
|
isEditableTarget,
|
|
isInteractiveTarget,
|
|
parseHotkeyCodes,
|
|
} from "./lotusHotkeys";
|
|
|
|
describe("parseHotkeyCodes", () => {
|
|
it("keeps KeyboardEvent.code-like strings", () => {
|
|
expect(parseHotkeyCodes({ codes: ["Space", "KeyM", "F13"] })).toEqual([
|
|
"Space",
|
|
"KeyM",
|
|
"F13",
|
|
]);
|
|
});
|
|
it("drops junk and caps the list", () => {
|
|
expect(parseHotkeyCodes({ codes: ["Space", 3, "", "a b", "<x>"] })).toEqual(
|
|
["Space"],
|
|
);
|
|
expect(parseHotkeyCodes({ codes: Array(20).fill("KeyA") })).toHaveLength(8);
|
|
expect(parseHotkeyCodes({})).toEqual([]);
|
|
expect(parseHotkeyCodes(null)).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe("target checks", () => {
|
|
it("treats inputs and contenteditable as editable", () => {
|
|
document.body.innerHTML =
|
|
'<input id="i"><div contenteditable="true"><span id="s">x</span></div><div id="d"></div>';
|
|
expect(isEditableTarget(document.getElementById("i"))).toBe(true);
|
|
expect(isEditableTarget(document.getElementById("s"))).toBe(true);
|
|
expect(isEditableTarget(document.getElementById("d"))).toBe(false);
|
|
expect(isEditableTarget(null)).toBe(false);
|
|
});
|
|
it("treats buttons, links and button roles as interactive", () => {
|
|
document.body.innerHTML =
|
|
'<button id="b">b</button><div role="menuitem"><span id="m">m</span></div><p id="p"></p>';
|
|
expect(isInteractiveTarget(document.getElementById("b"))).toBe(true);
|
|
expect(isInteractiveTarget(document.getElementById("m"))).toBe(true);
|
|
expect(isInteractiveTarget(document.getElementById("p"))).toBe(false);
|
|
});
|
|
});
|