Published npm version consumed by cinny has no corresponding git tag #22
Closed
opened 2026-09-12 02:13:09 -04:00 by jared
·
1 comment
No Branch/Tag Specified
lotus
chore/dev-tool-security
feat/expected-devices
lotus-upstream-v0.28.0
feat/call-summary-details
feat/soundboard-mic-mix
feat/mobile-self-tile
feat/screenshare-audio-state
feat/decorations-origin
docs/lotus-call-error
lotus-stall-retry
docs/lotus-protocol
lotus-soundboard-not-permitted
lotus-mic-sampler-churn
lotus-call-error
fix/audio-output-list
lotus-notify-none
lotus-screenshare-prompt
lotus-call-origin
v0.28.0-lotus.4
v0.28.0-lotus.3
v0.28.0-lotus.2
v0.28.0-lotus.1
v0.25.0-lotus.29
v0.25.0-lotus.28
v0.25.0-lotus.27
v0.25.0-lotus.26
v0.25.0-lotus.25
v0.25.0-lotus.24
v0.25.0-lotus.23
v0.25.0-lotus.22
v0.25.0-lotus.21
v0.25.0-lotus.20
v0.25.0-lotus.19
v0.25.0-lotus.18
v0.25.0-lotus.17
v0.25.0-lotus.16
v0.25.0-lotus.15
v0.25.0-lotus.14
v0.25.0-lotus.13
v0.25.0-lotus.12
v0.25.0-lotus.11
v0.25.0-lotus.10
v0.25.0-lotus.9
v0.25.0-lotus.8
v0.25.0-lotus.7
v0.25.0-lotus.6
v0.25.0-lotus.5
v0.25.0-lotus.4
v0.25.0-lotus.3
v0.25.0-lotus.2
v0.25.0-lotus.1
v0.20.1
Labels
Clear labels
a11y
area: audio-pipeline
area: build-publish
area: deafen
area: decorations
area: denoise
area: livekit
area: mobile-ui
area: soundboard-inject
area: upstream-sync
area: widget-actions
bug
dependencies
docs
enhancement
performance
priority: critical
priority: high
priority: low
priority: medium
research
security
tech-debt
ux
Accessibility
Fork area: audio-pipeline
Fork area: build-publish
Fork area: deafen
Fork area: decorations
Fork area: denoise
Fork area: livekit
Fork area: mobile-ui
Fork area: soundboard-inject
Fork area: upstream-sync
Fork area: widget-actions
Something is not working
Package versions and advisories
Docs wrong or missing
New feature
Audio pipeline cost, re-render storms, leaks
Data loss, security hole, or crash on a main path
Broken feature or serious usability problem
Minor issue or polish
Wrong behaviour in an edge case or notable degradation
Origin checks, capability leaks, media/key handling
Code health, fragile patterns
Usability or visual inconsistency
Milestone
No items
No Milestone
EC fork audit 2026-09 · Medium & Low
Projects
Clear projects
No projects
Notifications
Due Date
Dependencies
No dependencies set.
Reference: LotusGuild/element-call#22
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Severity: medium · Type: bug · Confidence: high
Location:
embedded/web/package.json:3(checked-in0.20.1-lotus.2, unpublished);/root/code/cinny/package.json:81pins@lotusguild/element-call-embeddeddevDependency... (see below) — actually pinned in cinny's own deps block at"@lotusguild/element-call-embedded": "0.20.1-lotus.1";.gitea/workflows/ci.yml:99-104(npm version "$TAG"derives the published version solely fromGITHUB_REF_NAME, i.e. the pushed git tag)Problem
The publish workflow makes the git tag the sole source of truth for the published version (comment at
ci.yml:12-14even says so explicitly), butgit tag | grep -i lotuson this checkout returns nolotus-scoped tags at all — notv0.20.1-lotus.1(what cinny currently consumes) norv0.20.1-lotus.2(whatembedded/web/package.jsoncurrently declares as the next version). If the tag that produced the published0.20.1-lotus.1artifact was deleted, never pushed to this remote, or only exists on the Gitea mirror, there is no way for anyone auditing this checkout to reconstruct which commit cinny's dependents are actually running. Fork HEAD (lotus@e36aef8a, "in-call mobile UI fixes wave-2") is 5 commits ahead of the last "prep 0.20.1-lotus.2" commit (d71d8d67), all unpublished per LOTUS_TODO P6-2, so there is also live drift: HEAD hasset_deafen, wave-1 EC1-EC6 fixes, and wave-2 mobile fixes that neither the publishedlotus.1nor even the stagedlotus.2package.json bump necessarily reflects in a taggable way.How to trigger
Try to answer "what commit is cinny's
0.20.1-lotus.1embed built from?" using only this repo's tags — there is nothing to resolve it to.Suggested fix
Push (and never delete) an annotated
vX.Y.Z-lotus.Ntag for every version that is actuallynpm published, and consider stamping the build with the git SHA (not just the tag name) viaVITE_APP_VERSIONor a separateVITE_APP_COMMITso the About/DeveloperSettings/rageshake output can disambiguate even if a tag is later moved or lost.Filed from the September 2026 audit (branch
lotus).Fixed in
872b8772, shipped in0.25.0-lotus.1(published by CI from tag v0.25.0-lotus.1) and consumed by cinny at 9a85a487.