Compare commits
7
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
aeb72c22b9 | ||
|
|
6fa34911ef | ||
|
|
35bc7a1e98 | ||
|
|
cee6bab9a6 | ||
|
|
44023a4c84 | ||
|
|
3086edc64a | ||
|
|
2b6bb20104 |
@@ -1,6 +1,6 @@
|
|||||||
{
|
{
|
||||||
"name": "@lotusguild/element-call-embedded",
|
"name": "@lotusguild/element-call-embedded",
|
||||||
"version": "0.25.0-lotus.14",
|
"version": "0.25.0-lotus.17",
|
||||||
"files": [
|
"files": [
|
||||||
"README.md",
|
"README.md",
|
||||||
"LICENSE-AGPL-3.0",
|
"LICENSE-AGPL-3.0",
|
||||||
|
|||||||
@@ -30,6 +30,7 @@ describe("LotusWidgetActions", () => {
|
|||||||
LotusWidgetActions.SetLayout,
|
LotusWidgetActions.SetLayout,
|
||||||
LotusWidgetActions.OpenSettings,
|
LotusWidgetActions.OpenSettings,
|
||||||
LotusWidgetActions.ToggleReactions,
|
LotusWidgetActions.ToggleReactions,
|
||||||
|
LotusWidgetActions.SetScreenshare,
|
||||||
];
|
];
|
||||||
|
|
||||||
expect(new Set(LOTUS_TO_WIDGET_ACTIONS)).toEqual(new Set(expectedToWidget));
|
expect(new Set(LOTUS_TO_WIDGET_ACTIONS)).toEqual(new Set(expectedToWidget));
|
||||||
@@ -50,5 +51,6 @@ describe("LotusWidgetActions", () => {
|
|||||||
expect(LOTUS_TO_WIDGET_ACTIONS).not.toContain(
|
expect(LOTUS_TO_WIDGET_ACTIONS).not.toContain(
|
||||||
LotusWidgetActions.ControlsState,
|
LotusWidgetActions.ControlsState,
|
||||||
);
|
);
|
||||||
|
expect(LOTUS_TO_WIDGET_ACTIONS).not.toContain(LotusWidgetActions.MicLevel);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -75,11 +75,24 @@ export enum LotusWidgetActions {
|
|||||||
/** toWidget: toggle the reactions / raise-hand menu (cinny #43). */
|
/** toWidget: toggle the reactions / raise-hand menu (cinny #43). */
|
||||||
ToggleReactions = "io.lotus.toggle_reactions",
|
ToggleReactions = "io.lotus.toggle_reactions",
|
||||||
/**
|
/**
|
||||||
* fromWidget: `{ screensharing: boolean, layout: "grid" | "spotlight" | null }`
|
* toWidget: start/stop sharing `{ on?: boolean }` (omit to toggle; cinny #43).
|
||||||
|
* Starting calls getDisplayMedia, which needs the user's click: the host
|
||||||
|
* sends this with Capability Delegation (`delegate: "display-capture"`), and
|
||||||
|
* without it the browser rejects the share.
|
||||||
|
*/
|
||||||
|
SetScreenshare = "io.lotus.set_screenshare",
|
||||||
|
/**
|
||||||
|
* fromWidget: `{ screensharing: boolean, layout: "grid" | "spotlight" | null,
|
||||||
|
* screenshareAction: true }`
|
||||||
* whenever either changes (cinny #43), so the host stops reading EC's DOM for
|
* whenever either changes (cinny #43), so the host stops reading EC's DOM for
|
||||||
* them. Its arrival also tells the host this fork supports the actions above.
|
* them. Its arrival also tells the host this fork supports the actions above.
|
||||||
*/
|
*/
|
||||||
ControlsState = "io.lotus.controls_state",
|
ControlsState = "io.lotus.controls_state",
|
||||||
|
/**
|
||||||
|
* fromWidget: local mic level `{ bars: 0 | 1 | 2 | 3 }` (cinny #146), sent
|
||||||
|
* only when it changes (≤ 10 Hz); 0 while muted or with no mic.
|
||||||
|
*/
|
||||||
|
MicLevel = "io.lotus.mic_level",
|
||||||
}
|
}
|
||||||
|
|
||||||
/** toWidget Lotus actions that must be allow-listed in `initializeWidget`. */
|
/** toWidget Lotus actions that must be allow-listed in `initializeWidget`. */
|
||||||
@@ -93,4 +106,5 @@ export const LOTUS_TO_WIDGET_ACTIONS: LotusWidgetActions[] = [
|
|||||||
LotusWidgetActions.SetLayout,
|
LotusWidgetActions.SetLayout,
|
||||||
LotusWidgetActions.OpenSettings,
|
LotusWidgetActions.OpenSettings,
|
||||||
LotusWidgetActions.ToggleReactions,
|
LotusWidgetActions.ToggleReactions,
|
||||||
|
LotusWidgetActions.SetScreenshare,
|
||||||
];
|
];
|
||||||
|
|||||||
@@ -7,7 +7,11 @@ Please see LICENSE in the repository root for full details.
|
|||||||
|
|
||||||
import { describe, expect, it } from "vitest";
|
import { describe, expect, it } from "vitest";
|
||||||
|
|
||||||
import { parseLayoutPayload, parseSettingsPayload } from "./lotusControls";
|
import {
|
||||||
|
parseLayoutPayload,
|
||||||
|
parseSettingsPayload,
|
||||||
|
shouldToggleScreenshare,
|
||||||
|
} from "./lotusControls";
|
||||||
|
|
||||||
describe("parseLayoutPayload", () => {
|
describe("parseLayoutPayload", () => {
|
||||||
it("accepts grid and spotlight", () => {
|
it("accepts grid and spotlight", () => {
|
||||||
@@ -33,3 +37,17 @@ describe("parseSettingsPayload", () => {
|
|||||||
expect(parseSettingsPayload({ open: "yes" }, true)).toBe(false);
|
expect(parseSettingsPayload({ open: "yes" }, true)).toBe(false);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe("shouldToggleScreenshare", () => {
|
||||||
|
it("toggles only when an explicit on differs from the current state", () => {
|
||||||
|
expect(shouldToggleScreenshare({ on: true }, false)).toBe(true);
|
||||||
|
expect(shouldToggleScreenshare({ on: true }, true)).toBe(false);
|
||||||
|
expect(shouldToggleScreenshare({ on: false }, true)).toBe(true);
|
||||||
|
expect(shouldToggleScreenshare({ on: false }, false)).toBe(false);
|
||||||
|
});
|
||||||
|
it("toggles when on is missing or not a boolean", () => {
|
||||||
|
expect(shouldToggleScreenshare({}, false)).toBe(true);
|
||||||
|
expect(shouldToggleScreenshare({ on: "yes" }, true)).toBe(true);
|
||||||
|
expect(shouldToggleScreenshare(null, true)).toBe(true);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -21,6 +21,8 @@ export interface LotusControlsState {
|
|||||||
screensharing: boolean;
|
screensharing: boolean;
|
||||||
/** Null while EC offers no layout switch (e.g. PiP or a 1:1 layout). */
|
/** Null while EC offers no layout switch (e.g. PiP or a 1:1 layout). */
|
||||||
layout: LayoutMode | null;
|
layout: LayoutMode | null;
|
||||||
|
/** This fork handles `io.lotus.set_screenshare` (always true). */
|
||||||
|
screenshareAction: true;
|
||||||
}
|
}
|
||||||
|
|
||||||
/** `{ layout }` payload → a layout mode, or undefined if invalid. Exported for tests. */
|
/** `{ layout }` payload → a layout mode, or undefined if invalid. Exported for tests. */
|
||||||
@@ -39,13 +41,28 @@ export function parseSettingsPayload(data: unknown, current: boolean): boolean {
|
|||||||
return !current;
|
return !current;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* `{ on? }` payload + current sharing state → whether to call the toggle.
|
||||||
|
* Exported for tests.
|
||||||
|
*/
|
||||||
|
export function shouldToggleScreenshare(
|
||||||
|
data: unknown,
|
||||||
|
sharing: boolean,
|
||||||
|
): boolean {
|
||||||
|
if (typeof data === "object" && data !== null && "on" in data) {
|
||||||
|
const { on } = data as { on?: unknown };
|
||||||
|
if (typeof on === "boolean") return on !== sharing;
|
||||||
|
}
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* [cinny #43] Widget-API replacements for the host's DOM access to EC's
|
* [cinny #43] Widget-API replacements for the host's DOM access to EC's
|
||||||
* controls: layout switch, settings modal and reactions menu, plus a
|
* controls: layout switch, settings modal and reactions menu, plus a
|
||||||
* `controls_state` report (screensharing + layout) so the host no longer reads
|
* `controls_state` report (screensharing + layout) so the host no longer reads
|
||||||
* EC's DOM for them. Screensharing itself stays host-DOM driven for now:
|
* EC's DOM for them. Screenshare start/stop too: `getDisplayMedia` needs the
|
||||||
* `getDisplayMedia` needs the user's click to reach this frame (Capability
|
* user's click in this frame, so the host sends `set_screenshare` with
|
||||||
* Delegation), which a plain widget message doesn't carry.
|
* Capability Delegation (Chromium). Elsewhere it keeps clicking EC's button.
|
||||||
*
|
*
|
||||||
* No effect unless the host sends the actions; registering is safe whenever
|
* No effect unless the host sends the actions; registering is safe whenever
|
||||||
* we're a widget. Returns a teardown function.
|
* we're a widget. Returns a teardown function.
|
||||||
@@ -69,10 +86,19 @@ export function startLotusControls(vm: CallViewModel): () => void {
|
|||||||
w.api.transport.reply(ev.detail, {});
|
w.api.transport.reply(ev.detail, {});
|
||||||
window.dispatchEvent(new Event(LOTUS_TOGGLE_REACTIONS_EVENT));
|
window.dispatchEvent(new Event(LOTUS_TOGGLE_REACTIONS_EVENT));
|
||||||
};
|
};
|
||||||
|
const onSetScreenshare = (ev: CustomEvent<IWidgetApiRequest>): void => {
|
||||||
|
w.api.transport.reply(ev.detail, {});
|
||||||
|
// Call synchronously: the delegated activation is only good for a few
|
||||||
|
// seconds after the message arrived.
|
||||||
|
if (shouldToggleScreenshare(ev.detail.data, vm.sharingScreen$.value)) {
|
||||||
|
vm.toggleScreenSharing?.();
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
w.lazyActions.on(LotusWidgetActions.SetLayout, onSetLayout);
|
w.lazyActions.on(LotusWidgetActions.SetLayout, onSetLayout);
|
||||||
w.lazyActions.on(LotusWidgetActions.OpenSettings, onOpenSettings);
|
w.lazyActions.on(LotusWidgetActions.OpenSettings, onOpenSettings);
|
||||||
w.lazyActions.on(LotusWidgetActions.ToggleReactions, onToggleReactions);
|
w.lazyActions.on(LotusWidgetActions.ToggleReactions, onToggleReactions);
|
||||||
|
w.lazyActions.on(LotusWidgetActions.SetScreenshare, onSetScreenshare);
|
||||||
|
|
||||||
const sub: Subscription = combineLatest([
|
const sub: Subscription = combineLatest([
|
||||||
vm.sharingScreen$,
|
vm.sharingScreen$,
|
||||||
@@ -85,6 +111,7 @@ export function startLotusControls(vm: CallViewModel): () => void {
|
|||||||
([screensharing, layout]): LotusControlsState => ({
|
([screensharing, layout]): LotusControlsState => ({
|
||||||
screensharing,
|
screensharing,
|
||||||
layout,
|
layout,
|
||||||
|
screenshareAction: true,
|
||||||
}),
|
}),
|
||||||
),
|
),
|
||||||
distinctUntilChanged(
|
distinctUntilChanged(
|
||||||
@@ -100,5 +127,6 @@ export function startLotusControls(vm: CallViewModel): () => void {
|
|||||||
w.lazyActions.off(LotusWidgetActions.SetLayout, onSetLayout);
|
w.lazyActions.off(LotusWidgetActions.SetLayout, onSetLayout);
|
||||||
w.lazyActions.off(LotusWidgetActions.OpenSettings, onOpenSettings);
|
w.lazyActions.off(LotusWidgetActions.OpenSettings, onOpenSettings);
|
||||||
w.lazyActions.off(LotusWidgetActions.ToggleReactions, onToggleReactions);
|
w.lazyActions.off(LotusWidgetActions.ToggleReactions, onToggleReactions);
|
||||||
|
w.lazyActions.off(LotusWidgetActions.SetScreenshare, onSetScreenshare);
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,37 @@
|
|||||||
|
/*
|
||||||
|
Copyright 2026 Lotus Guild
|
||||||
|
|
||||||
|
SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
||||||
|
Please see LICENSE in the repository root for full details.
|
||||||
|
*/
|
||||||
|
|
||||||
|
import { describe, expect, it } from "vitest";
|
||||||
|
|
||||||
|
import { MicLevelQuantizer } from "./lotusMicLevel";
|
||||||
|
|
||||||
|
describe("MicLevelQuantizer", () => {
|
||||||
|
it("maps RMS to 0–3 bars", () => {
|
||||||
|
expect(new MicLevelQuantizer().push(0.001)).toBe(0);
|
||||||
|
expect(new MicLevelQuantizer().push(0.008)).toBe(1);
|
||||||
|
expect(new MicLevelQuantizer().push(0.02)).toBe(2);
|
||||||
|
expect(new MicLevelQuantizer().push(0.2)).toBe(3);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("rises at once and falls one bar per sample", () => {
|
||||||
|
const q = new MicLevelQuantizer();
|
||||||
|
expect(q.push(0.2)).toBe(3);
|
||||||
|
expect(q.push(0)).toBe(2);
|
||||||
|
expect(q.push(0)).toBe(1);
|
||||||
|
expect(q.push(0.02)).toBe(2);
|
||||||
|
expect(q.push(0)).toBe(1);
|
||||||
|
expect(q.push(0)).toBe(0);
|
||||||
|
expect(q.push(0)).toBe(0);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("reset drops straight to 0", () => {
|
||||||
|
const q = new MicLevelQuantizer();
|
||||||
|
q.push(0.2);
|
||||||
|
q.reset();
|
||||||
|
expect(q.push(0)).toBe(0);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,192 @@
|
|||||||
|
/*
|
||||||
|
Copyright 2026 Lotus Guild
|
||||||
|
|
||||||
|
SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
||||||
|
Please see LICENSE in the repository root for full details.
|
||||||
|
*/
|
||||||
|
|
||||||
|
import {
|
||||||
|
type LocalTrackPublication,
|
||||||
|
type Room as LivekitRoom,
|
||||||
|
RoomEvent,
|
||||||
|
Track,
|
||||||
|
} from "livekit-client";
|
||||||
|
import { Observable, type Subscription, share, switchMap } from "rxjs";
|
||||||
|
import { distinctUntilChanged, map } from "rxjs/operators";
|
||||||
|
|
||||||
|
import { type CallViewModel } from "../state/CallViewModel/CallViewModel";
|
||||||
|
import { widget } from "../widget";
|
||||||
|
import { LotusWidgetActions, lotusFlag, lotusSendToHost } from "./lotusWidget";
|
||||||
|
|
||||||
|
/**
|
||||||
|
* [lotus #146] One local mic sampler shared by the host's mic level meter
|
||||||
|
* (`io.lotus.mic_level`) and "talking while muted" (#37, lotusMutedSpeech).
|
||||||
|
* It taps a CLONE of the published mic track (the post-processor track when
|
||||||
|
* the in-source denoiser is active, so what's measured is what's sent) and
|
||||||
|
* reads RMS at ~10 Hz while a mic track is published, muted or not.
|
||||||
|
* Local only: nothing here reaches other participants.
|
||||||
|
*/
|
||||||
|
|
||||||
|
const SAMPLE_MS = 100;
|
||||||
|
|
||||||
|
export interface LocalMicSample {
|
||||||
|
rms: number;
|
||||||
|
/** The mic is published but muted (the clone still hears it). */
|
||||||
|
muted: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
const micPublication = (
|
||||||
|
room: LivekitRoom,
|
||||||
|
): { track: MediaStreamTrack; muted: boolean } | null => {
|
||||||
|
const pub: LocalTrackPublication | undefined =
|
||||||
|
room.localParticipant.getTrackPublication(Track.Source.Microphone);
|
||||||
|
const track = pub?.track?.mediaStreamTrack;
|
||||||
|
return track && track.readyState === "live"
|
||||||
|
? { track, muted: pub?.isMuted ?? false }
|
||||||
|
: null;
|
||||||
|
};
|
||||||
|
|
||||||
|
const samplers = new WeakMap<
|
||||||
|
CallViewModel,
|
||||||
|
Observable<LocalMicSample | null>
|
||||||
|
>();
|
||||||
|
|
||||||
|
/**
|
||||||
|
* RMS samples of the local mic, or `null` while no mic track is published.
|
||||||
|
* Shared per call view model, so the meter and the muted-speech detector use
|
||||||
|
* one AudioContext between them.
|
||||||
|
*/
|
||||||
|
export function observeLocalMicSample$(
|
||||||
|
vm: CallViewModel,
|
||||||
|
): Observable<LocalMicSample | null> {
|
||||||
|
const cached = samplers.get(vm);
|
||||||
|
if (cached) return cached;
|
||||||
|
const sampler$ = vm.allConnections$.pipe(
|
||||||
|
switchMap(
|
||||||
|
(data) =>
|
||||||
|
new Observable<LocalMicSample | null>((subscriber) => {
|
||||||
|
const rooms = data.getConnections().map((c) => c.livekitRoom);
|
||||||
|
let ctx: AudioContext | null = null;
|
||||||
|
let clone: MediaStreamTrack | null = null;
|
||||||
|
let timer: ReturnType<typeof setInterval> | undefined;
|
||||||
|
let tapped: MediaStreamTrack | null = null;
|
||||||
|
let muted = false;
|
||||||
|
|
||||||
|
const stopTap = (): void => {
|
||||||
|
if (timer !== undefined) clearInterval(timer);
|
||||||
|
timer = undefined;
|
||||||
|
clone?.stop();
|
||||||
|
clone = null;
|
||||||
|
void ctx?.close().catch(() => undefined);
|
||||||
|
ctx = null;
|
||||||
|
tapped = null;
|
||||||
|
subscriber.next(null);
|
||||||
|
};
|
||||||
|
|
||||||
|
const startTap = (source: MediaStreamTrack): void => {
|
||||||
|
try {
|
||||||
|
clone = source.clone();
|
||||||
|
// Muting disables the published track; the clone must still hear.
|
||||||
|
clone.enabled = true;
|
||||||
|
ctx = new AudioContext();
|
||||||
|
const analyser = ctx.createAnalyser();
|
||||||
|
analyser.fftSize = 1024;
|
||||||
|
ctx
|
||||||
|
.createMediaStreamSource(new MediaStream([clone]))
|
||||||
|
.connect(analyser);
|
||||||
|
const buf = new Float32Array(analyser.fftSize);
|
||||||
|
tapped = source;
|
||||||
|
timer = setInterval(() => {
|
||||||
|
analyser.getFloatTimeDomainData(buf);
|
||||||
|
let sum = 0;
|
||||||
|
for (let i = 0; i < buf.length; i += 1) sum += buf[i] * buf[i];
|
||||||
|
subscriber.next({ rms: Math.sqrt(sum / buf.length), muted });
|
||||||
|
}, SAMPLE_MS);
|
||||||
|
} catch {
|
||||||
|
stopTap();
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const reconcile = (): void => {
|
||||||
|
const pub =
|
||||||
|
rooms.map(micPublication).find((p) => p !== null) ?? null;
|
||||||
|
muted = pub?.muted ?? false;
|
||||||
|
const track = pub?.track ?? null;
|
||||||
|
if (track === tapped) return;
|
||||||
|
if (tapped) stopTap();
|
||||||
|
if (track) startTap(track);
|
||||||
|
};
|
||||||
|
|
||||||
|
const events = [
|
||||||
|
RoomEvent.TrackMuted,
|
||||||
|
RoomEvent.TrackUnmuted,
|
||||||
|
RoomEvent.LocalTrackPublished,
|
||||||
|
RoomEvent.LocalTrackUnpublished,
|
||||||
|
RoomEvent.Reconnected,
|
||||||
|
RoomEvent.Disconnected,
|
||||||
|
] as const;
|
||||||
|
rooms.forEach((room) =>
|
||||||
|
events.forEach((ev) => room.on(ev, reconcile)),
|
||||||
|
);
|
||||||
|
subscriber.next(null);
|
||||||
|
reconcile();
|
||||||
|
return (): void => {
|
||||||
|
rooms.forEach((room) =>
|
||||||
|
events.forEach((ev) => room.off(ev, reconcile)),
|
||||||
|
);
|
||||||
|
if (tapped) stopTap();
|
||||||
|
};
|
||||||
|
}),
|
||||||
|
),
|
||||||
|
share(),
|
||||||
|
);
|
||||||
|
samplers.set(vm, sampler$);
|
||||||
|
return sampler$;
|
||||||
|
}
|
||||||
|
|
||||||
|
/** RMS at which each bar lights: ≈ −46, −36 and −26 dBFS. */
|
||||||
|
export const BAR_THRESHOLDS = [0.005, 0.015, 0.05] as const;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Quantise RMS to 0–3 bars with a little hysteresis: rises at once, falls one
|
||||||
|
* bar per sample, so the meter doesn't flicker between words. Unit-tested.
|
||||||
|
*/
|
||||||
|
export class MicLevelQuantizer {
|
||||||
|
private bars = 0;
|
||||||
|
|
||||||
|
public reset(): void {
|
||||||
|
this.bars = 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
public push(rms: number): number {
|
||||||
|
const target = BAR_THRESHOLDS.filter((t) => rms >= t).length;
|
||||||
|
this.bars = target >= this.bars ? target : this.bars - 1;
|
||||||
|
return this.bars;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Send the host `io.lotus.mic_level { bars }` (0–3) whenever the quantised
|
||||||
|
* level changes; 0 while muted or with no mic. At most one message per sample
|
||||||
|
* (10 Hz) and none during steady silence. Opt-in with the rest of the host
|
||||||
|
* state stream (`lotusCallState=1`). Returns a teardown function.
|
||||||
|
*/
|
||||||
|
export function startLotusMicLevel(vm: CallViewModel): () => void {
|
||||||
|
if (!lotusFlag("lotusCallState") || !widget) return (): void => undefined;
|
||||||
|
const quantizer = new MicLevelQuantizer();
|
||||||
|
const sub: Subscription = observeLocalMicSample$(vm)
|
||||||
|
.pipe(
|
||||||
|
map((sample) => {
|
||||||
|
if (!sample || sample.muted) {
|
||||||
|
quantizer.reset();
|
||||||
|
return 0;
|
||||||
|
}
|
||||||
|
return quantizer.push(sample.rms);
|
||||||
|
}),
|
||||||
|
distinctUntilChanged(),
|
||||||
|
)
|
||||||
|
.subscribe((bars) => {
|
||||||
|
lotusSendToHost(LotusWidgetActions.MicLevel, { bars });
|
||||||
|
});
|
||||||
|
return (): void => sub.unsubscribe();
|
||||||
|
}
|
||||||
@@ -6,14 +6,15 @@ Please see LICENSE in the repository root for full details.
|
|||||||
*/
|
*/
|
||||||
|
|
||||||
import {
|
import {
|
||||||
type LocalTrackPublication,
|
type Observable,
|
||||||
type Room as LivekitRoom,
|
distinctUntilChanged,
|
||||||
RoomEvent,
|
map,
|
||||||
Track,
|
scan,
|
||||||
} from "livekit-client";
|
startWith,
|
||||||
import { Observable, distinctUntilChanged, switchMap } from "rxjs";
|
} from "rxjs";
|
||||||
|
|
||||||
import { type CallViewModel } from "../state/CallViewModel/CallViewModel";
|
import { type CallViewModel } from "../state/CallViewModel/CallViewModel";
|
||||||
|
import { type LocalMicSample, observeLocalMicSample$ } from "./lotusMicLevel";
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* [lotus #37] "Talking while muted" detection for the LOCAL participant.
|
* [lotus #37] "Talking while muted" detection for the LOCAL participant.
|
||||||
@@ -23,13 +24,12 @@ import { type CallViewModel } from "../state/CallViewModel/CallViewModel";
|
|||||||
* tells the user they are talking into a muted mic. This taps a CLONE of the
|
* tells the user they are talking into a muted mic. This taps a CLONE of the
|
||||||
* published track (the post-processor track when the in-source denoiser is
|
* published track (the post-processor track when the in-source denoiser is
|
||||||
* active, so keyboard noise doesn't count), samples RMS at ~10 Hz and emits a
|
* active, so keyboard noise doesn't count), samples RMS at ~10 Hz and emits a
|
||||||
* debounced boolean. Zero cost when unmuted (tap torn down), local-only —
|
* debounced boolean. Local-only —
|
||||||
* the flag rides `io.lotus.call_state` to the host and never reaches other
|
* the flag rides `io.lotus.call_state` to the host and never reaches other
|
||||||
* participants.
|
* participants.
|
||||||
*/
|
*/
|
||||||
|
|
||||||
export const MUTED_SPEECH_RMS = 0.015; // ≈ −36 dBFS; normal speech into a headset is 0.05–0.3
|
export const MUTED_SPEECH_RMS = 0.015; // ≈ −36 dBFS; normal speech into a headset is 0.05–0.3
|
||||||
const SAMPLE_MS = 100;
|
|
||||||
const ON_SAMPLES = 3; // 300 ms of voice before we say "talking"
|
const ON_SAMPLES = 3; // 300 ms of voice before we say "talking"
|
||||||
const OFF_SAMPLES = 8; // 800 ms of quiet before we drop it
|
const OFF_SAMPLES = 8; // 800 ms of quiet before we drop it
|
||||||
|
|
||||||
@@ -61,94 +61,24 @@ export class MutedSpeechGate {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const mutedMicTrack = (room: LivekitRoom): MediaStreamTrack | null => {
|
|
||||||
const pub: LocalTrackPublication | undefined =
|
|
||||||
room.localParticipant.getTrackPublication(Track.Source.Microphone);
|
|
||||||
const track = pub?.track?.mediaStreamTrack;
|
|
||||||
return pub?.isMuted && track && track.readyState === "live" ? track : null;
|
|
||||||
};
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Emits while the local mic is muted and voice is detected on it. Emits
|
* Emits while the local mic is muted and voice is detected on it. Emits
|
||||||
* `false` whenever the mic is unmuted, unpublished or the connection changes.
|
* `false` whenever the mic is unmuted, unpublished or the connection changes.
|
||||||
|
* [lotus #146] Fed by the shared local mic sampler (lotusMicLevel.ts), which
|
||||||
|
* also drives the host's mic level meter while unmuted.
|
||||||
*/
|
*/
|
||||||
export function observeSpeakingWhileMuted$(
|
export function observeSpeakingWhileMuted$(
|
||||||
vm: CallViewModel,
|
vm: CallViewModel,
|
||||||
): Observable<boolean> {
|
): Observable<boolean> {
|
||||||
return vm.allConnections$.pipe(
|
return observeLocalMicSample$(vm).pipe(
|
||||||
switchMap(
|
scan((gate: MutedSpeechGate | null, sample: LocalMicSample | null) => {
|
||||||
(data) =>
|
if (!sample?.muted) return null;
|
||||||
new Observable<boolean>((subscriber) => {
|
const g = gate ?? new MutedSpeechGate();
|
||||||
const rooms = data.getConnections().map((c) => c.livekitRoom);
|
g.push(sample.rms);
|
||||||
let ctx: AudioContext | null = null;
|
return g;
|
||||||
let clone: MediaStreamTrack | null = null;
|
}, null),
|
||||||
let timer: ReturnType<typeof setInterval> | undefined;
|
map((gate) => gate?.value ?? false),
|
||||||
let tapped: MediaStreamTrack | null = null;
|
startWith(false),
|
||||||
|
|
||||||
const stopTap = (): void => {
|
|
||||||
if (timer !== undefined) clearInterval(timer);
|
|
||||||
timer = undefined;
|
|
||||||
clone?.stop();
|
|
||||||
clone = null;
|
|
||||||
void ctx?.close().catch(() => undefined);
|
|
||||||
ctx = null;
|
|
||||||
tapped = null;
|
|
||||||
subscriber.next(false);
|
|
||||||
};
|
|
||||||
|
|
||||||
const startTap = (source: MediaStreamTrack): void => {
|
|
||||||
try {
|
|
||||||
clone = source.clone();
|
|
||||||
clone.enabled = true; // the source is disabled by the mute — the clone must not be
|
|
||||||
ctx = new AudioContext();
|
|
||||||
const analyser = ctx.createAnalyser();
|
|
||||||
analyser.fftSize = 1024;
|
|
||||||
ctx
|
|
||||||
.createMediaStreamSource(new MediaStream([clone]))
|
|
||||||
.connect(analyser);
|
|
||||||
const buf = new Float32Array(analyser.fftSize);
|
|
||||||
const gate = new MutedSpeechGate();
|
|
||||||
tapped = source;
|
|
||||||
timer = setInterval(() => {
|
|
||||||
analyser.getFloatTimeDomainData(buf);
|
|
||||||
let sum = 0;
|
|
||||||
for (let i = 0; i < buf.length; i += 1) sum += buf[i] * buf[i];
|
|
||||||
subscriber.next(gate.push(Math.sqrt(sum / buf.length)));
|
|
||||||
}, SAMPLE_MS);
|
|
||||||
} catch {
|
|
||||||
stopTap();
|
|
||||||
}
|
|
||||||
};
|
|
||||||
|
|
||||||
const reconcile = (): void => {
|
|
||||||
const track =
|
|
||||||
rooms.map(mutedMicTrack).find((t) => t !== null) ?? null;
|
|
||||||
if (track === tapped) return;
|
|
||||||
if (tapped) stopTap();
|
|
||||||
if (track) startTap(track);
|
|
||||||
};
|
|
||||||
|
|
||||||
const events = [
|
|
||||||
RoomEvent.TrackMuted,
|
|
||||||
RoomEvent.TrackUnmuted,
|
|
||||||
RoomEvent.LocalTrackPublished,
|
|
||||||
RoomEvent.LocalTrackUnpublished,
|
|
||||||
RoomEvent.Reconnected,
|
|
||||||
RoomEvent.Disconnected,
|
|
||||||
] as const;
|
|
||||||
rooms.forEach((room) =>
|
|
||||||
events.forEach((ev) => room.on(ev, reconcile)),
|
|
||||||
);
|
|
||||||
subscriber.next(false);
|
|
||||||
reconcile();
|
|
||||||
return () => {
|
|
||||||
rooms.forEach((room) =>
|
|
||||||
events.forEach((ev) => room.off(ev, reconcile)),
|
|
||||||
);
|
|
||||||
if (tapped) stopTap();
|
|
||||||
};
|
|
||||||
}),
|
|
||||||
),
|
|
||||||
distinctUntilChanged(),
|
distinctUntilChanged(),
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,61 @@
|
|||||||
|
/*
|
||||||
|
Copyright 2026 Lotus Guild
|
||||||
|
|
||||||
|
SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
||||||
|
Please see LICENSE in the repository root for full details.
|
||||||
|
*/
|
||||||
|
|
||||||
|
import { beforeEach, describe, expect, it } from "vitest";
|
||||||
|
|
||||||
|
import {
|
||||||
|
MAX_REMEMBERED,
|
||||||
|
getRememberedVolume,
|
||||||
|
rememberVolume,
|
||||||
|
} from "./lotusVolumeMemory";
|
||||||
|
|
||||||
|
describe("lotusVolumeMemory", () => {
|
||||||
|
beforeEach(() => localStorage.clear());
|
||||||
|
|
||||||
|
it("defaults to 1 and remembers a set volume", () => {
|
||||||
|
expect(getRememberedVolume("@bob:x")).toBe(1);
|
||||||
|
rememberVolume("@bob:x", 0.4);
|
||||||
|
expect(getRememberedVolume("@bob:x")).toBe(0.4);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("forgets the entry when set back to 1", () => {
|
||||||
|
rememberVolume("@bob:x", 0.4);
|
||||||
|
rememberVolume("@bob:x", 1);
|
||||||
|
expect(getRememberedVolume("@bob:x")).toBe(1);
|
||||||
|
expect(localStorage.getItem("lotus-per-user-volume")).toBe("{}");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("keeps only the most recently set entries", () => {
|
||||||
|
for (let i = 0; i < MAX_REMEMBERED + 5; i++)
|
||||||
|
rememberVolume(`@u${i}:x`, 0.5);
|
||||||
|
expect(getRememberedVolume("@u0:x")).toBe(1);
|
||||||
|
expect(getRememberedVolume("@u4:x")).toBe(1);
|
||||||
|
expect(getRememberedVolume("@u5:x")).toBe(0.5);
|
||||||
|
expect(getRememberedVolume(`@u${MAX_REMEMBERED + 4}:x`)).toBe(0.5);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("re-setting an old entry makes it recent", () => {
|
||||||
|
for (let i = 0; i < MAX_REMEMBERED; i++) rememberVolume(`@u${i}:x`, 0.5);
|
||||||
|
rememberVolume("@u0:x", 0.7);
|
||||||
|
rememberVolume("@new:x", 0.3);
|
||||||
|
expect(getRememberedVolume("@u0:x")).toBe(0.7);
|
||||||
|
expect(getRememberedVolume("@u1:x")).toBe(1);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("ignores junk in storage and invalid volumes", () => {
|
||||||
|
localStorage.setItem(
|
||||||
|
"lotus-per-user-volume",
|
||||||
|
JSON.stringify({ "@a:x": "loud", "@b:x": 0.2 }),
|
||||||
|
);
|
||||||
|
expect(getRememberedVolume("@a:x")).toBe(1);
|
||||||
|
expect(getRememberedVolume("@b:x")).toBe(0.2);
|
||||||
|
rememberVolume("@c:x", Number.NaN);
|
||||||
|
expect(getRememberedVolume("@c:x")).toBe(1);
|
||||||
|
localStorage.setItem("lotus-per-user-volume", "not json");
|
||||||
|
expect(getRememberedVolume("@b:x")).toBe(1);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,65 @@
|
|||||||
|
/*
|
||||||
|
Copyright 2026 Lotus Guild
|
||||||
|
|
||||||
|
SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
||||||
|
Please see LICENSE in the repository root for full details.
|
||||||
|
*/
|
||||||
|
|
||||||
|
/**
|
||||||
|
* [element-call #36] Remember the per-participant volume slider across calls,
|
||||||
|
* reloads and reconnects. Keyed by Matrix user id (not device), so "Bob is
|
||||||
|
* loud" sticks when Bob switches devices. Local to this browser, never synced.
|
||||||
|
* Only voice is remembered; screenshare audio stays per-share.
|
||||||
|
*/
|
||||||
|
|
||||||
|
const STORAGE_KEY = "lotus-per-user-volume";
|
||||||
|
/** Most recently set entries kept; older ones are dropped. */
|
||||||
|
export const MAX_REMEMBERED = 50;
|
||||||
|
|
||||||
|
type VolumeMap = Record<string, number>;
|
||||||
|
|
||||||
|
const isVolume = (v: unknown): v is number =>
|
||||||
|
typeof v === "number" && Number.isFinite(v) && v >= 0 && v <= 4;
|
||||||
|
|
||||||
|
function load(): VolumeMap {
|
||||||
|
try {
|
||||||
|
const raw = localStorage.getItem(STORAGE_KEY);
|
||||||
|
if (!raw) return {};
|
||||||
|
const parsed: unknown = JSON.parse(raw);
|
||||||
|
if (typeof parsed !== "object" || parsed === null) return {};
|
||||||
|
const out: VolumeMap = {};
|
||||||
|
for (const [k, v] of Object.entries(parsed)) if (isVolume(v)) out[k] = v;
|
||||||
|
return out;
|
||||||
|
} catch {
|
||||||
|
return {};
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
function save(map: VolumeMap): void {
|
||||||
|
try {
|
||||||
|
localStorage.setItem(STORAGE_KEY, JSON.stringify(map));
|
||||||
|
} catch {
|
||||||
|
// Storage unavailable (private mode, quota): the slider just won't stick.
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/** The remembered volume for `userId`, or 1 (100 %) if none. */
|
||||||
|
export function getRememberedVolume(userId: string): number {
|
||||||
|
return load()[userId] ?? 1;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Remember `volume` for `userId`. 1 (the default) forgets the entry. The entry
|
||||||
|
* moves to the end so the map is in least-recently-set order, trimmed to
|
||||||
|
* MAX_REMEMBERED.
|
||||||
|
*/
|
||||||
|
export function rememberVolume(userId: string, volume: number): void {
|
||||||
|
if (!isVolume(volume)) return;
|
||||||
|
const map = load();
|
||||||
|
delete map[userId];
|
||||||
|
if (volume !== 1) map[userId] = volume;
|
||||||
|
const keys = Object.keys(map);
|
||||||
|
for (const k of keys.slice(0, Math.max(0, keys.length - MAX_REMEMBERED)))
|
||||||
|
delete map[k];
|
||||||
|
save(map);
|
||||||
|
}
|
||||||
@@ -32,6 +32,7 @@ import { widget } from "../widget";
|
|||||||
import { startLotusCallState } from "../lotus/lotusCallState";
|
import { startLotusCallState } from "../lotus/lotusCallState";
|
||||||
import { startLotusFocus } from "../lotus/lotusFocus";
|
import { startLotusFocus } from "../lotus/lotusFocus";
|
||||||
import { startLotusControls } from "../lotus/lotusControls";
|
import { startLotusControls } from "../lotus/lotusControls";
|
||||||
|
import { startLotusMicLevel } from "../lotus/lotusMicLevel";
|
||||||
import { startLotusAudioInject } from "../lotus/lotusAudioInject";
|
import { startLotusAudioInject } from "../lotus/lotusAudioInject";
|
||||||
import { startLotusQuality } from "../lotus/lotusQuality";
|
import { startLotusQuality } from "../lotus/lotusQuality";
|
||||||
import { startLotusDecorations } from "../lotus/lotusDecorations";
|
import { startLotusDecorations } from "../lotus/lotusDecorations";
|
||||||
@@ -304,6 +305,8 @@ export const InCallView: FC<InCallViewProps> = ({
|
|||||||
// [cinny #43] layout / settings / reactions over the widget API, plus a
|
// [cinny #43] layout / settings / reactions over the widget API, plus a
|
||||||
// screensharing + layout report, replacing the host's DOM access.
|
// screensharing + layout report, replacing the host's DOM access.
|
||||||
useEffect(() => startLotusControls(vm), [vm]);
|
useEffect(() => startLotusControls(vm), [vm]);
|
||||||
|
// [cinny #146] Local mic level for the host's mute-button meter.
|
||||||
|
useEffect(() => startLotusMicLevel(vm), [vm]);
|
||||||
// [lotus] Handle the host's io.lotus.inject_audio action to mix a soundboard
|
// [lotus] Handle the host's io.lotus.inject_audio action to mix a soundboard
|
||||||
// clip into the call as a separate track (#3). No-op unless the host sends it.
|
// clip into the call as a separate track (#3). No-op unless the host sends it.
|
||||||
useEffect(() => startLotusAudioInject(vm), [vm]);
|
useEffect(() => startLotusAudioInject(vm), [vm]);
|
||||||
|
|||||||
+71
-27
@@ -5,7 +5,16 @@ SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
|||||||
Please see LICENSE in the repository root for full details.
|
Please see LICENSE in the repository root for full details.
|
||||||
*/
|
*/
|
||||||
|
|
||||||
import { combineLatest, map, merge, of, Subject, switchMap } from "rxjs";
|
import {
|
||||||
|
combineLatest,
|
||||||
|
distinctUntilChanged,
|
||||||
|
map,
|
||||||
|
merge,
|
||||||
|
of,
|
||||||
|
skip,
|
||||||
|
Subject,
|
||||||
|
switchMap,
|
||||||
|
} from "rxjs";
|
||||||
|
|
||||||
import { type Behavior } from "./Behavior";
|
import { type Behavior } from "./Behavior";
|
||||||
import { type ObservableScope } from "./ObservableScope";
|
import { type ObservableScope } from "./ObservableScope";
|
||||||
@@ -25,7 +34,12 @@ export interface VolumeControls {
|
|||||||
playbackMuted$: Behavior<boolean>;
|
playbackMuted$: Behavior<boolean>;
|
||||||
togglePlaybackMuted: () => void;
|
togglePlaybackMuted: () => void;
|
||||||
adjustPlaybackVolume: (value: number) => void;
|
adjustPlaybackVolume: (value: number) => void;
|
||||||
commitPlaybackVolume: () => void;
|
/**
|
||||||
|
* Commit the volume. [lotus #36] Pass the slider's committed value: with the
|
||||||
|
* keyboard the slider commits before its last change reaches us, which left
|
||||||
|
* the committed (and remembered) volume one step behind.
|
||||||
|
*/
|
||||||
|
commitPlaybackVolume: (value?: number) => void;
|
||||||
}
|
}
|
||||||
|
|
||||||
interface VolumeControlsInputs {
|
interface VolumeControlsInputs {
|
||||||
@@ -35,6 +49,10 @@ interface VolumeControlsInputs {
|
|||||||
* requested volume.
|
* requested volume.
|
||||||
*/
|
*/
|
||||||
sink$: Behavior<(volume: number) => void>;
|
sink$: Behavior<(volume: number) => void>;
|
||||||
|
/** [lotus #36] Starting volume (a remembered one); defaults to 1. */
|
||||||
|
initialVolume?: number;
|
||||||
|
/** [lotus #36] Called with each newly committed volume. */
|
||||||
|
onCommit?: (volume: number) => void;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -43,38 +61,61 @@ interface VolumeControlsInputs {
|
|||||||
*/
|
*/
|
||||||
export function createVolumeControls(
|
export function createVolumeControls(
|
||||||
scope: ObservableScope,
|
scope: ObservableScope,
|
||||||
{ pretendToBeDisconnected$, sink$ }: VolumeControlsInputs,
|
{
|
||||||
|
pretendToBeDisconnected$,
|
||||||
|
sink$,
|
||||||
|
initialVolume = 1,
|
||||||
|
onCommit,
|
||||||
|
}: VolumeControlsInputs,
|
||||||
): VolumeControls {
|
): VolumeControls {
|
||||||
const toggleMuted$ = new Subject<"toggle mute">();
|
const toggleMuted$ = new Subject<"toggle mute">();
|
||||||
const adjustVolume$ = new Subject<number>();
|
const adjustVolume$ = new Subject<number>();
|
||||||
const commitVolume$ = new Subject<"commit">();
|
const commitVolume$ = new Subject<"commit">();
|
||||||
|
|
||||||
const playbackVolume$ = scope.behavior<number>(
|
const state$ = scope.behavior(
|
||||||
merge(toggleMuted$, adjustVolume$, commitVolume$).pipe(
|
merge(toggleMuted$, adjustVolume$, commitVolume$).pipe(
|
||||||
accumulate({ volume: 1, committedVolume: 1 }, (state, event) => {
|
accumulate(
|
||||||
switch (event) {
|
{ volume: initialVolume, committedVolume: initialVolume },
|
||||||
case "toggle mute":
|
(state, event) => {
|
||||||
return {
|
switch (event) {
|
||||||
...state,
|
case "toggle mute":
|
||||||
volume: state.volume === 0 ? state.committedVolume : 0,
|
return {
|
||||||
};
|
...state,
|
||||||
case "commit":
|
volume: state.volume === 0 ? state.committedVolume : 0,
|
||||||
// Dragging the slider to zero should have the same effect as
|
};
|
||||||
// muting: keep the original committed volume, as if it were never
|
case "commit":
|
||||||
// dragged
|
// Dragging the slider to zero should have the same effect as
|
||||||
return {
|
// muting: keep the original committed volume, as if it were never
|
||||||
...state,
|
// dragged
|
||||||
committedVolume:
|
return {
|
||||||
state.volume === 0 ? state.committedVolume : state.volume,
|
...state,
|
||||||
};
|
committedVolume:
|
||||||
default:
|
state.volume === 0 ? state.committedVolume : state.volume,
|
||||||
// Volume adjustment
|
};
|
||||||
return { ...state, volume: event };
|
default:
|
||||||
}
|
// Volume adjustment
|
||||||
}),
|
return { ...state, volume: event };
|
||||||
map(({ volume }) => volume),
|
}
|
||||||
|
},
|
||||||
|
),
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
const playbackVolume$ = scope.behavior<number>(
|
||||||
|
state$.pipe(map(({ volume }) => volume)),
|
||||||
|
);
|
||||||
|
|
||||||
|
// [lotus #36] Report committed changes (not the starting value) so the
|
||||||
|
// caller can remember them.
|
||||||
|
if (onCommit) {
|
||||||
|
state$
|
||||||
|
.pipe(
|
||||||
|
map(({ committedVolume }) => committedVolume),
|
||||||
|
distinctUntilChanged(),
|
||||||
|
skip(1),
|
||||||
|
scope.bind(),
|
||||||
|
)
|
||||||
|
.subscribe(onCommit);
|
||||||
|
}
|
||||||
|
|
||||||
// Sync the requested volume with the audio playback module
|
// Sync the requested volume with the audio playback module
|
||||||
combineLatest([
|
combineLatest([
|
||||||
@@ -96,6 +137,9 @@ export function createVolumeControls(
|
|||||||
),
|
),
|
||||||
togglePlaybackMuted: () => toggleMuted$.next("toggle mute"),
|
togglePlaybackMuted: () => toggleMuted$.next("toggle mute"),
|
||||||
adjustPlaybackVolume: (value: number) => adjustVolume$.next(value),
|
adjustPlaybackVolume: (value: number) => adjustVolume$.next(value),
|
||||||
commitPlaybackVolume: () => commitVolume$.next("commit"),
|
commitPlaybackVolume: (value?: number) => {
|
||||||
|
if (value !== undefined) adjustVolume$.next(value);
|
||||||
|
commitVolume$.next("commit");
|
||||||
|
},
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -5,7 +5,7 @@ SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
|||||||
Please see LICENSE in the repository root for full details.
|
Please see LICENSE in the repository root for full details.
|
||||||
*/
|
*/
|
||||||
|
|
||||||
import { expect, onTestFinished, test, vi } from "vitest";
|
import { afterEach, expect, onTestFinished, test, vi } from "vitest";
|
||||||
import {
|
import {
|
||||||
type LocalTrackPublication,
|
type LocalTrackPublication,
|
||||||
LocalVideoTrack,
|
LocalVideoTrack,
|
||||||
@@ -44,6 +44,36 @@ vi.mock("../../Platform", () => ({
|
|||||||
|
|
||||||
const rtcMembership = mockRtcMembership("@alice:example.org", "AAAA");
|
const rtcMembership = mockRtcMembership("@alice:example.org", "AAAA");
|
||||||
|
|
||||||
|
// [lotus #36] Remote volumes are remembered in localStorage; keep tests apart.
|
||||||
|
afterEach(() => localStorage.clear());
|
||||||
|
|
||||||
|
test("a remembered volume is restored and a committed slider value is saved", () => {
|
||||||
|
localStorage.setItem(
|
||||||
|
"lotus-per-user-volume",
|
||||||
|
JSON.stringify({ "@alice:example.org": 0.5 }),
|
||||||
|
);
|
||||||
|
const setVolumeSpy = vi.fn();
|
||||||
|
const vm = mockRemoteMedia(
|
||||||
|
rtcMembership,
|
||||||
|
{},
|
||||||
|
mockRemoteParticipant({ setVolume: setVolumeSpy }),
|
||||||
|
);
|
||||||
|
withTestScheduler(({ expectObservable, schedule }) => {
|
||||||
|
schedule("-a|", {
|
||||||
|
a() {
|
||||||
|
// Keyboard order: the slider commits with its final value before that
|
||||||
|
// value's change event reaches the view model.
|
||||||
|
vm.commitPlaybackVolume(0.3);
|
||||||
|
expect(setVolumeSpy).toHaveBeenLastCalledWith(0.3);
|
||||||
|
expect(
|
||||||
|
JSON.parse(localStorage.getItem("lotus-per-user-volume") ?? "{}"),
|
||||||
|
).toEqual({ "@alice:example.org": 0.3 });
|
||||||
|
},
|
||||||
|
});
|
||||||
|
expectObservable(vm.playbackVolume$).toBe("ab", { a: 0.5, b: 0.3 });
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
test("control a participant's volume", () => {
|
test("control a participant's volume", () => {
|
||||||
const setVolumeSpy = vi.fn();
|
const setVolumeSpy = vi.fn();
|
||||||
const vm = mockRemoteMedia(
|
const vm = mockRemoteMedia(
|
||||||
|
|||||||
@@ -11,6 +11,10 @@ import { combineLatest, map, of, switchMap } from "rxjs";
|
|||||||
|
|
||||||
import { type Behavior } from "../Behavior";
|
import { type Behavior } from "../Behavior";
|
||||||
import { createVolumeControls, type VolumeControls } from "../VolumeControls";
|
import { createVolumeControls, type VolumeControls } from "../VolumeControls";
|
||||||
|
import {
|
||||||
|
getRememberedVolume,
|
||||||
|
rememberVolume,
|
||||||
|
} from "../../lotus/lotusVolumeMemory";
|
||||||
import {
|
import {
|
||||||
type BaseUserMediaInputs,
|
type BaseUserMediaInputs,
|
||||||
type BaseUserMediaViewModel,
|
type BaseUserMediaViewModel,
|
||||||
@@ -52,6 +56,9 @@ export function createRemoteUserMedia(
|
|||||||
sink$: scope.behavior(
|
sink$: scope.behavior(
|
||||||
inputs.participant$.pipe(map((p) => (volume) => p?.setVolume(volume))),
|
inputs.participant$.pipe(map((p) => (volume) => p?.setVolume(volume))),
|
||||||
),
|
),
|
||||||
|
// [lotus #36] The slider sticks per user across calls and reconnects.
|
||||||
|
initialVolume: getRememberedVolume(inputs.userId),
|
||||||
|
onCommit: (volume) => rememberVolume(inputs.userId, volume),
|
||||||
}),
|
}),
|
||||||
local: false,
|
local: false,
|
||||||
speaking$: scope.behavior(
|
speaking$: scope.behavior(
|
||||||
|
|||||||
@@ -337,7 +337,10 @@ const ScreenShareVolumeButton: FC<ScreenShareVolumeButtonProps> = ({ vm }) => {
|
|||||||
(v: number) => vm.adjustPlaybackVolume(v),
|
(v: number) => vm.adjustPlaybackVolume(v),
|
||||||
[vm],
|
[vm],
|
||||||
);
|
);
|
||||||
const onVolumeCommit = useCallback(() => vm.commitPlaybackVolume(), [vm]);
|
const onVolumeCommit = useCallback(
|
||||||
|
(value: number) => vm.commitPlaybackVolume(value),
|
||||||
|
[vm],
|
||||||
|
);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
audioEnabled && (
|
audioEnabled && (
|
||||||
|
|||||||
Reference in New Issue
Block a user