feat(spotlight): flip between cameras as well as screenshares during a share (#67)
During a screenshare the spotlight carousel holds the shares first, then the host-pinned camera, then every other remote camera that is on (join order). The share stays the default view; the view falls back to the first share when the visible camera turns off or leaves. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPmy3tPq869XDW4njjVaKA
This commit was merged in pull request #68.
This commit is contained in:
@@ -71,8 +71,9 @@ widgetTest("Sharing screen in group call", async ({ addUser, browserName }) => {
|
||||
.locator('iframe[title="Element Call"]')
|
||||
.contentFrame();
|
||||
|
||||
// Expect 4 (3 + screen share) video tiles
|
||||
await expect(frame.locator("video")).toHaveCount(4, {
|
||||
// Expect 6 video tiles: 3 cameras in the grid, plus the spotlight
|
||||
// carousel's screen share and the 2 remote cameras (lotus #67)
|
||||
await expect(frame.locator("video")).toHaveCount(6, {
|
||||
timeout: 5000,
|
||||
});
|
||||
|
||||
@@ -112,8 +113,9 @@ widgetTest("Sharing screen in group call", async ({ addUser, browserName }) => {
|
||||
.locator('iframe[title="Element Call"]')
|
||||
.contentFrame();
|
||||
|
||||
// Expect 5 (2 + screen share) video tiles
|
||||
await expect(frame.locator("video")).toHaveCount(5, {
|
||||
// Expect 7 video tiles: 3 cameras in the grid, plus the spotlight
|
||||
// carousel's 2 screen shares and 2 remote cameras (lotus #67)
|
||||
await expect(frame.locator("video")).toHaveCount(7, {
|
||||
timeout: 5000,
|
||||
});
|
||||
|
||||
@@ -121,8 +123,12 @@ widgetTest("Sharing screen in group call", async ({ addUser, browserName }) => {
|
||||
frame.locator('video[data-lk-source="screen_share"]'),
|
||||
).toHaveCount(2);
|
||||
|
||||
// Expect 2 indicators at the bottom
|
||||
await expect(frame.getByTestId("screenshare-indicator")).toHaveCount(2);
|
||||
// Expect 4 indicators at the bottom: the 2 shares first, then the 2
|
||||
// remote cameras (lotus #67)
|
||||
await expect(frame.getByTestId("screenshare-indicator")).toHaveCount(4);
|
||||
await expect(
|
||||
frame.locator('[data-testid="screenshare-indicator"][data-kind="user"]'),
|
||||
).toHaveCount(2);
|
||||
|
||||
// Check the first indicator is visible
|
||||
await expect(
|
||||
|
||||
Reference in New Issue
Block a user