From d71d8d6799b6ae2ed0836fa81c99ff42be6a3177 Mon Sep 17 00:00:00 2001 From: Lotus CI Date: Wed, 1 Jul 2026 23:56:28 -0400 Subject: [PATCH] chore(lotus): fix stale denoise flag docs + prep 0.20.1-lotus.2 The in-source ML denoiser is gated on lotusDenoiseSource (see lotusDenoise.ts gate), not the legacy build-time shim flag lotusDenoise=ml. Correct the two stale references (lotusDenoise.ts JSDoc + InCallView.tsx comment) to lotusDenoiseSource=1. Bump the embedded package to 0.20.1-lotus.2 for the next publish and update the CI comment: the checked-in version now tracks the intended release, while a pushed tag still wins (npm version "$TAG" overwrites at publish time). Co-Authored-By: Claude Opus 4.8 --- .gitea/workflows/ci.yml | 6 ++++-- embedded/web/package.json | 2 +- src/lotus/lotusDenoise.ts | 2 +- src/room/InCallView.tsx | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/.gitea/workflows/ci.yml b/.gitea/workflows/ci.yml index d7d139ca..526965ed 100644 --- a/.gitea/workflows/ci.yml +++ b/.gitea/workflows/ci.yml @@ -8,8 +8,10 @@ name: CI # - Pushes of a tag `v*` -> build + publish @lotusguild/element-call-embedded # to the Gitea npm registry # -# Versioning mirrors upstream: the in-repo package.json stays 0.0.0; the -# published version is derived from the git tag at publish time. +# Versioning: the checked-in embedded/web/package.json tracks the intended next +# release (e.g. 0.20.1-lotus.2) for local/manual publishes, but the AUTHORITATIVE +# published version is still derived from the git tag at publish time (the +# `npm version "$TAG"` step below overwrites it, so a tag always wins). on: push: diff --git a/embedded/web/package.json b/embedded/web/package.json index 66e19bee..5f61bfe8 100644 --- a/embedded/web/package.json +++ b/embedded/web/package.json @@ -1,6 +1,6 @@ { "name": "@lotusguild/element-call-embedded", - "version": "0.0.0", + "version": "0.20.1-lotus.2", "files": [ "README.md", "LICENSE-AGPL-3.0", diff --git a/src/lotus/lotusDenoise.ts b/src/lotus/lotusDenoise.ts index bb70761e..8f06aa41 100644 --- a/src/lotus/lotusDenoise.ts +++ b/src/lotus/lotusDenoise.ts @@ -25,7 +25,7 @@ import { * Element Call audio TrackProcessor (#1), replacing the host's build-time * `getUserMedia` monkeypatch. * - * Opt-in via `lotusDenoise=ml` (+ `lotusModel`, `lotusGate`, + * Opt-in via `lotusDenoiseSource=1` (+ `lotusModel`, `lotusGate`, * `lotusGateThreshold`, `lotusDenoiseBase`). Because the processor is attached * to the mic publication and re-attached on every (re)publish, denoise * survives EC's mid-call reconnect — fixing the A7 "mic dead after reconnect" diff --git a/src/room/InCallView.tsx b/src/room/InCallView.tsx index 50c19f44..d09763a4 100644 --- a/src/room/InCallView.tsx +++ b/src/room/InCallView.tsx @@ -301,7 +301,7 @@ export const InCallView: FC = ({ // them on in-call tile avatars (#6). No-op unless the host sends them. useEffect(() => startLotusDecorations(), []); // [lotus] Apply ML denoise to the mic as a first-class audio processor that - // survives reconnects (#1 / A7). No-op unless lotusDenoise=ml. + // survives reconnects (#1 / A7). No-op unless lotusDenoiseSource=1. useEffect(() => startLotusDenoise(vm), [vm]); const fatalCallError = useBehavior(vm.fatalError$);