Magic Numbers #21

New Issue

2026-02-02T15:05:01-05:00

jared commented

2026-02-02 15:05:01 -05:00

grep -B 20 "/dev/$device" # Why 20?
awk '{print $10}' # Why column 10?

Improvement: Use named constants:

readonly CEPH_CONTEXT_LINES=20
readonly SMART_TEMP_COLUMN=10

grep -B 20 "/dev/$device" # Why 20? awk '{print $10}' # Why column 10? Improvement: Use named constants: readonly CEPH_CONTEXT_LINES=20 readonly SMART_TEMP_COLUMN=10

jared closed this issue

2026-02-05 12:20:49 -05:00

jared referenced this issue from a commit

2026-02-05 19:51:41 -05:00

Magic numbers already addressed in earlier fixes

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: LotusGuild/driveAtlas#21