Global Variable Scope Issue in build_drive_map() #1

New Issue

2026-02-02T14:54:43-05:00

jared commented

2026-02-02 14:54:43 -05:00

Line ~200-210

build_drive_map() {
local host=$(hostname)
declare -A drive_map # Local associative array

# ... population logic ...

# This makes it global, but it's inefficient and error-prone
declare -g -A DRIVE_MAP=()
for key in "${!drive_map[@]}"; do
    DRIVE_MAP[$key]=${drive_map[$key]}
done

}
Issue: Creating a local array then copying to global is inefficient. Should declare

DRIVE_MAP as global at the start.

Fix: Use

declare -g -A DRIVE_MAP at function start, populate directly.

# Line ~200-210 build_drive_map() { local host=$(hostname) declare -A drive_map # Local associative array # ... population logic ... # This makes it global, but it's inefficient and error-prone declare -g -A DRIVE_MAP=() for key in "${!drive_map[@]}"; do DRIVE_MAP[$key]=${drive_map[$key]} done } Issue: Creating a local array then copying to global is inefficient. Should declare DRIVE_MAP as global at the start. Fix: Use declare -g -A DRIVE_MAP at function start, populate directly.

jared closed this issue

2026-02-05 12:20:52 -05:00

jared referenced this issue from a commit

2026-02-05 19:51:39 -05:00

Fix inefficient DRIVE_MAP declaration pattern

jared referenced this issue from a commit

2026-06-08 15:42:22 -04:00

Fix large1 bay mappings based on physical audit

Sign in to join this conversation.