Hardcoded URLs in Production #7

New Issue

2026-02-02T15:11:00-05:00

jared commented

2026-02-02 15:11:00 -05:00

"http://10.10.10.157:11434/api/generate" # Line 564
"http://10.10.10.67" # PELICAN_URL default

Issue: Exposes internal network topology.

Fix:

Use environment variables without defaults for internal services

OLLAMA_URL = os.getenv('OLLAMA_URL') # No default
if not OLLAMA_URL:
logger.error("OLLAMA_URL not configured")

Validate internal URLs

def validate_internal_url(url: str) -> bool:
"""Ensure URL points to approved internal service"""
# Add your validation logic
return url.startswith(('http://10.', 'https://'))

"http://10.10.10.157:11434/api/generate" # Line 564 "http://10.10.10.67" # PELICAN_URL default Issue: Exposes internal network topology. Fix: # Use environment variables without defaults for internal services OLLAMA_URL = os.getenv('OLLAMA_URL') # No default if not OLLAMA_URL: logger.error("OLLAMA_URL not configured") # Validate internal URLs def validate_internal_url(url: str) -> bool: """Ensure URL points to approved internal service""" # Add your validation logic return url.startswith(('http://10.', 'https://'))

jared referenced this issue from a commit

2026-02-10 20:42:28 -05:00

Refactor bot with 17 issue fixes: logging, caching, error handling, security

jared closed this issue

2026-02-10 20:42:29 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: LotusGuild/discordBot#7