Duplicate Code for Media Files #10

New Issue

2026-02-02T15:11:34-05:00

jared commented

2026-02-02 15:11:34 -05:00

Kill, punch, hug, revive all have identical logic.

Fix:

async def send_interaction_media(
interaction: discord.Interaction,
member: discord.Member,
action: str,
media_prefix: str
):
"""Generic function for interaction commands"""
media_files = [f"media/{media_prefix}{i}.gif" for i in ['', '1', '2', '3']]
available = [f for f in media_files if Path(f).exists()]

message = {
    'kill': f"You killed {member}",
    'punch': f"You punched {member}",
    'hug': f"{member} has been squeezed tightly!",
    'revive': f"{member} has been brought back to life"
}[action]

if available:
    await interaction.response.send_message(
        message, file=discord.File(random.choice(available))
    )
else:
    await interaction.response.send_message(message)

Then simplify commands:

@client.tree.command(name="kill", description="Kill another user")
async def kill(interaction: discord.Interaction, member: discord.Member):
await send_interaction_media(interaction, member, 'kill', 'kill')

Kill, punch, hug, revive all have identical logic. Fix: async def send_interaction_media( interaction: discord.Interaction, member: discord.Member, action: str, media_prefix: str ): """Generic function for interaction commands""" media_files = [f"media/{media_prefix}{i}.gif" for i in ['', '1', '2', '3']] available = [f for f in media_files if Path(f).exists()] message = { 'kill': f"You killed {member}", 'punch': f"You punched {member}", 'hug': f"{member} has been squeezed tightly!", 'revive': f"{member} has been brought back to life" }[action] if available: await interaction.response.send_message( message, file=discord.File(random.choice(available)) ) else: await interaction.response.send_message(message) # Then simplify commands: @client.tree.command(name="kill", description="Kill another user") async def kill(interaction: discord.Interaction, member: discord.Member): await send_interaction_media(interaction, member, 'kill', 'kill')

jared referenced this issue from a commit

2026-02-10 20:42:27 -05:00

Refactor bot with 17 issue fixes: logging, caching, error handling, security

jared closed this issue

2026-02-10 20:42:28 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: LotusGuild/discordBot#10