Low-priority robustness cleanups #12

New Issue

2026-10-07T20:04:28-04:00

jared commented

2026-10-07 20:04:28 -04:00

Source: engineering review, 2026-10-07.

postinst re-sources tmux.conf and set -as terminal-features appends every time; the live server had 16 duplicates. Use an explicit index.
devdesk-deploy:
- Add -o DPkg::Lock::Timeout=120 and log an explicit "deploy failed" line.
- Add logrotate for /var/log/devdesk-deploy.log.
- Make CI fail visibly when the deploy fails; the webhook is async today.
run_resume treats any non-zero exit within 10s as "transcript gone" and replaces the recorded id. Only fall back when the transcript file is actually missing.
Env files are sourced by bash and parsed by systemd. Validate them as KEY=value (no unquoted spaces).
end leaves uploads/<name>; temp files from killed hooks (.name.XXXXXX) pile up; a rename can race the SessionStart hook.
Add X-Frame-Options: DENY / CSP frame-ancestors 'none' in NPM.

_Source: engineering review, 2026-10-07._ - [ ] `postinst` re-sources tmux.conf and `set -as terminal-features` appends every time; the live server had 16 duplicates. Use an explicit index. - [ ] devdesk-deploy: - [ ] Add `-o DPkg::Lock::Timeout=120` and log an explicit "deploy failed" line. - [ ] Add logrotate for `/var/log/devdesk-deploy.log`. - [ ] Make CI fail visibly when the deploy fails; the webhook is async today. - [ ] `run_resume` treats any non-zero exit within 10s as "transcript gone" and replaces the recorded id. Only fall back when the transcript file is actually missing. - [ ] Env files are sourced by bash *and* parsed by systemd. Validate them as `KEY=value` (no unquoted spaces). - [ ] `end` leaves `uploads/<name>`; temp files from killed hooks (`.name.XXXXXX`) pile up; a rename can race the SessionStart hook. - [ ] Add `X-Frame-Options: DENY` / CSP `frame-ancestors 'none'` in NPM.

jared added this to the backlog milestone 2026-10-07 20:04:28 -04:00

jared added the chore label 2026-10-07 20:04:28 -04:00

jared referenced this issue from a commit

2026-10-11 01:01:53 -04:00

fix: v0.9.1 robustness cleanups

jared closed this issue

2026-10-11 01:01:53 -04:00

jared referenced this issue from a commit

2026-10-11 01:46:10 -04:00

docs: frame headers in the NPM Advanced template

Sign in to join this conversation.