Address findings from 3 review agents on the Threads list panel:
- Last-activity accuracy (SDK): sort key and the "last reply <time>"
label now use thread.replyToEvent.getTs() (server bundle latest_event)
instead of lastReply(), which returns the ROOT time until each thread's
replies lazily paginate (or permanently on fetch error). Applied to the
hook signature too.
- Live-refresh completeness (correctness): the useRoomThreads signature
now includes thread.length and the root event's replacingEventId, so a
mid-thread redaction (reply count) and a root-message edit (row snippet)
refresh the row live instead of going stale.
- a11y: the row's aria-label was the button's whole accessible name,
hiding the snippet/count/unread from screen readers. It now describes
the thread ("Open thread by <name>, unread, N replies, last reply ..").
- Unread badge: replaced the bare green dot (Success = the mention color)
with the app-wide UnreadBadge, using the Highlight count so mentions
render red and ordinary unread renders secondary, matching room-nav.
- Hover/focus affordance: the clickable row moved its inline styles to a
css class with token-based :hover / :active backgrounds.
- Participant pile now also includes the last replier from the bundle.
- Stabilized the panel's onClose/onOpenThread with useCallback so its
Escape listener isn't re-subscribed every Room render. Added
filter->sort pipeline + all/participating immutability tests.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
234 lines
9.1 KiB
TypeScript
234 lines
9.1 KiB
TypeScript
import React, { useCallback, useEffect, useRef } from 'react';
|
|
import { Box, Line } from 'folds';
|
|
import { useParams } from 'react-router-dom';
|
|
import { isKeyHotkey } from 'is-hotkey';
|
|
import { useAtomValue, useSetAtom } from 'jotai';
|
|
import { RoomView } from './RoomView';
|
|
import { MembersDrawer } from './MembersDrawer';
|
|
import { MediaGallery } from './MediaGallery';
|
|
import { mediaGalleryAtom } from '../../state/mediaGallery';
|
|
import { WidgetsPanel } from './widgets/WidgetsPanel';
|
|
import { widgetsPanelAtom } from '../../state/widgetsPanel';
|
|
import { ScreenSize, useScreenSizeContext } from '../../hooks/useScreenSize';
|
|
import { useSetting } from '../../state/hooks/settings';
|
|
import { settingsAtom } from '../../state/settings';
|
|
import { PowerLevelsContextProvider, usePowerLevels } from '../../hooks/usePowerLevels';
|
|
import { useRoom } from '../../hooks/useRoom';
|
|
import { useKeyDown } from '../../hooks/useKeyDown';
|
|
import { markAsRead } from '../../utils/notifications';
|
|
import { useMatrixClient } from '../../hooks/useMatrixClient';
|
|
import { useRoomMembers } from '../../hooks/useRoomMembers';
|
|
import { CallView } from '../call/CallView';
|
|
import { RoomViewHeader } from './RoomViewHeader';
|
|
import { callChatAtom } from '../../state/callEmbed';
|
|
import { CallChatView } from './CallChatView';
|
|
import { useCallEmbed } from '../../hooks/useCallEmbed';
|
|
import { useCallMembers, useCallSession } from '../../hooks/useCall';
|
|
import { roomIdToActiveThreadIdAtomFamily } from '../../state/room/thread';
|
|
import { threadsListAtom } from '../../state/threadsList';
|
|
import { ThreadPanel } from './thread';
|
|
import { ThreadsListPanel } from './thread/ThreadsListPanel';
|
|
|
|
export function Room() {
|
|
const { eventId } = useParams();
|
|
const room = useRoom();
|
|
const mx = useMatrixClient();
|
|
|
|
const callSession = useCallSession(room);
|
|
const callMembers = useCallMembers(callSession);
|
|
const callEmbed = useCallEmbed();
|
|
|
|
const [isDrawer] = useSetting(settingsAtom, 'isPeopleDrawer');
|
|
const activeThreadId = useAtomValue(roomIdToActiveThreadIdAtomFamily(room.roomId));
|
|
const setActiveThreadId = useSetAtom(roomIdToActiveThreadIdAtomFamily(room.roomId));
|
|
const galleryOpen = useAtomValue(mediaGalleryAtom);
|
|
const setGalleryOpen = useSetAtom(mediaGalleryAtom);
|
|
const widgetsOpen = useAtomValue(widgetsPanelAtom);
|
|
const setWidgetsOpen = useSetAtom(widgetsPanelAtom);
|
|
const threadsListOpen = useAtomValue(threadsListAtom);
|
|
const setThreadsListOpen = useSetAtom(threadsListAtom);
|
|
const [hideActivity] = useSetting(settingsAtom, 'hideActivity');
|
|
const screenSize = useScreenSizeContext();
|
|
const powerLevels = usePowerLevels(room);
|
|
const members = useRoomMembers(mx, room.roomId);
|
|
const chat = useAtomValue(callChatAtom);
|
|
useKeyDown(
|
|
window,
|
|
useCallback(
|
|
(evt) => {
|
|
if (isKeyHotkey('escape', evt)) {
|
|
// Skip when a composer already consumed Escape (it preventDefaults).
|
|
if (evt.defaultPrevented) return;
|
|
// Skip while a thread panel is open: listener registration order
|
|
// means this can run BEFORE the panel's own Escape handler, and the
|
|
// user's intent there is "close the panel", not "mark room read".
|
|
if (activeThreadId) return;
|
|
markAsRead(mx, room.roomId, hideActivity);
|
|
}
|
|
},
|
|
[mx, room.roomId, hideActivity, activeThreadId],
|
|
),
|
|
);
|
|
|
|
// Stable handlers for the threads-list panel so its document-level Escape
|
|
// listener isn't torn down and re-added on every Room re-render.
|
|
const closeThreadsList = useCallback(() => setThreadsListOpen(false), [setThreadsListOpen]);
|
|
const openThreadFromList = useCallback(
|
|
(threadId: string) => {
|
|
setActiveThreadId(threadId);
|
|
setThreadsListOpen(false);
|
|
},
|
|
[setActiveThreadId, setThreadsListOpen],
|
|
);
|
|
|
|
const callView = callEmbed?.roomId === room.roomId || room.isCallRoom() || callMembers.length > 0;
|
|
|
|
// The content panels (thread / media gallery / widgets) are mutually exclusive
|
|
// on every screen size: opening one closes the others. Detect the just-opened
|
|
// transition so whichever was opened most recently wins.
|
|
const prevThreadRef = useRef(activeThreadId);
|
|
const prevGalleryRef = useRef(galleryOpen);
|
|
const prevWidgetsRef = useRef(widgetsOpen);
|
|
const prevThreadsListRef = useRef(threadsListOpen);
|
|
useEffect(() => {
|
|
const threadJustOpened = Boolean(activeThreadId) && !prevThreadRef.current;
|
|
const galleryJustOpened = galleryOpen && !prevGalleryRef.current;
|
|
const widgetsJustOpened = widgetsOpen && !prevWidgetsRef.current;
|
|
const threadsListJustOpened = threadsListOpen && !prevThreadsListRef.current;
|
|
if (threadJustOpened) {
|
|
if (galleryOpen) setGalleryOpen(false);
|
|
if (widgetsOpen) setWidgetsOpen(false);
|
|
if (threadsListOpen) setThreadsListOpen(false);
|
|
} else if (galleryJustOpened) {
|
|
if (activeThreadId) setActiveThreadId(null);
|
|
if (widgetsOpen) setWidgetsOpen(false);
|
|
if (threadsListOpen) setThreadsListOpen(false);
|
|
} else if (widgetsJustOpened) {
|
|
if (activeThreadId) setActiveThreadId(null);
|
|
if (galleryOpen) setGalleryOpen(false);
|
|
if (threadsListOpen) setThreadsListOpen(false);
|
|
} else if (threadsListJustOpened) {
|
|
if (activeThreadId) setActiveThreadId(null);
|
|
if (galleryOpen) setGalleryOpen(false);
|
|
if (widgetsOpen) setWidgetsOpen(false);
|
|
}
|
|
prevThreadRef.current = activeThreadId;
|
|
prevGalleryRef.current = galleryOpen;
|
|
prevWidgetsRef.current = widgetsOpen;
|
|
prevThreadsListRef.current = threadsListOpen;
|
|
}, [
|
|
activeThreadId,
|
|
galleryOpen,
|
|
widgetsOpen,
|
|
threadsListOpen,
|
|
setGalleryOpen,
|
|
setActiveThreadId,
|
|
setWidgetsOpen,
|
|
setThreadsListOpen,
|
|
]);
|
|
|
|
// On non-desktop screens at most one right-side panel may show, priority
|
|
// thread > gallery > widgets > members. On desktop thread + members may coexist
|
|
// while the content panels stay mutually exclusive (via the effect above).
|
|
const isDesktop = screenSize === ScreenSize.Desktop;
|
|
const showThreadPanel = !callView && Boolean(activeThreadId);
|
|
const showGallery = !callView && galleryOpen && (isDesktop || !activeThreadId);
|
|
const showWidgets = !callView && widgetsOpen && (isDesktop || (!activeThreadId && !galleryOpen));
|
|
// The single-thread panel always replaces the list (they share the content slot).
|
|
const showThreadsList =
|
|
!callView &&
|
|
threadsListOpen &&
|
|
!activeThreadId &&
|
|
(isDesktop || (!galleryOpen && !widgetsOpen));
|
|
const showMembers =
|
|
!callView &&
|
|
isDrawer &&
|
|
(isDesktop || (!activeThreadId && !galleryOpen && !widgetsOpen && !threadsListOpen));
|
|
|
|
return (
|
|
<PowerLevelsContextProvider value={powerLevels}>
|
|
<Box grow="Yes">
|
|
{callView && (screenSize === ScreenSize.Desktop || !chat) && (
|
|
<Box grow="Yes" direction="Column">
|
|
<RoomViewHeader callView />
|
|
<Box grow="Yes">
|
|
<CallView />
|
|
</Box>
|
|
</Box>
|
|
)}
|
|
{!callView && (
|
|
<Box grow="Yes" direction="Column">
|
|
<RoomViewHeader />
|
|
<Box grow="Yes">
|
|
<RoomView eventId={eventId} />
|
|
</Box>
|
|
</Box>
|
|
)}
|
|
|
|
{callView && chat && (
|
|
<>
|
|
{screenSize === ScreenSize.Desktop && (
|
|
<Line variant="Background" direction="Vertical" size="300" />
|
|
)}
|
|
<CallChatView />
|
|
</>
|
|
)}
|
|
{showGallery && (
|
|
<>
|
|
{screenSize === ScreenSize.Desktop && (
|
|
<Line variant="Background" direction="Vertical" size="300" />
|
|
)}
|
|
<MediaGallery key={room.roomId} room={room} onClose={() => setGalleryOpen(false)} />
|
|
</>
|
|
)}
|
|
{showWidgets && (
|
|
<>
|
|
{screenSize === ScreenSize.Desktop && (
|
|
<Line variant="Background" direction="Vertical" size="300" />
|
|
)}
|
|
<WidgetsPanel
|
|
key={room.roomId}
|
|
room={room}
|
|
requestClose={() => setWidgetsOpen(false)}
|
|
/>
|
|
</>
|
|
)}
|
|
{showThreadsList && (
|
|
<>
|
|
{screenSize === ScreenSize.Desktop && (
|
|
<Line variant="Background" direction="Vertical" size="300" />
|
|
)}
|
|
<ThreadsListPanel
|
|
key={room.roomId}
|
|
room={room}
|
|
onClose={closeThreadsList}
|
|
onOpenThread={openThreadFromList}
|
|
/>
|
|
</>
|
|
)}
|
|
{showThreadPanel && activeThreadId && (
|
|
<>
|
|
{screenSize === ScreenSize.Desktop && (
|
|
<Line variant="Background" direction="Vertical" size="300" />
|
|
)}
|
|
<ThreadPanel
|
|
key={`${room.roomId}${activeThreadId}`}
|
|
room={room}
|
|
threadId={activeThreadId}
|
|
requestClose={() => setActiveThreadId(null)}
|
|
/>
|
|
</>
|
|
)}
|
|
{showMembers && (
|
|
<>
|
|
{screenSize === ScreenSize.Desktop && (
|
|
<Line variant="Background" direction="Vertical" size="300" />
|
|
)}
|
|
<MembersDrawer key={room.roomId} room={room} members={members} />
|
|
</>
|
|
)}
|
|
</Box>
|
|
</PowerLevelsContextProvider>
|
|
);
|
|
}
|