CI / Build & Quality Checks (push) Successful in 1m53s
CI / Docker image build & smoke test (push) Skipped
CI / Secret scan (gitleaks) (push) Successful in 6s
CI / Trigger Desktop Build (push) Successful in 5s
CI / Playwright smoke (e2e) (push) Successful in 11m15s
16 menus (room header, Home/Direct/Space sidebar tabs, create tab, lobby,
room-nav item, history visibility, client root) set
returnFocusOnDeactivate: false, so pressing Escape dropped focus to
<body> and a keyboard user had to start over from the top of the page.
That option was there so focus wouldn't be pulled back to the menu button
when an item opens a dialog; since ce8ed89f dialogs move focus into
themselves (their initial focus runs after the menu's return), so it's no
longer needed. The autocomplete menu (focus must stay in the editor) and
the two menus whose opener disappears are left as they were.
Checked: room header menu → Escape → focus on "More options" (was
<body>); menu → Leave Room → focus inside the Leave Room dialog on
Cancel, same as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PPmy3tPq869XDW4njjVaKA
166 lines
5.4 KiB
TypeScript
166 lines
5.4 KiB
TypeScript
import React, { MouseEventHandler, useCallback, useMemo, useState } from 'react';
|
|
import {
|
|
Button,
|
|
color,
|
|
config,
|
|
Icon,
|
|
Icons,
|
|
Menu,
|
|
MenuItem,
|
|
PopOut,
|
|
RectCords,
|
|
Spinner,
|
|
Text,
|
|
} from 'folds';
|
|
import { HistoryVisibility, MatrixError } from 'matrix-js-sdk';
|
|
import { RoomHistoryVisibilityEventContent } from 'matrix-js-sdk/lib/types';
|
|
import FocusTrap from 'focus-trap-react';
|
|
import { SequenceCard } from '../../../components/sequence-card';
|
|
import { SequenceCardStyle } from '../../room-settings/styles.css';
|
|
import { SettingTile } from '../../../components/setting-tile';
|
|
import { useMatrixClient } from '../../../hooks/useMatrixClient';
|
|
import { useRoom } from '../../../hooks/useRoom';
|
|
import { StateEvent } from '../../../../types/matrix/room';
|
|
import { sendStateEvent } from '../../../utils/room';
|
|
import { AsyncStatus, useAsyncCallback } from '../../../hooks/useAsyncCallback';
|
|
import { useStateEvent } from '../../../hooks/useStateEvent';
|
|
import { stopPropagation } from '../../../utils/keyboard';
|
|
import { RoomPermissionsAPI } from '../../../hooks/useRoomPermissions';
|
|
|
|
const useVisibilityStr = () =>
|
|
useMemo(
|
|
() => ({
|
|
[HistoryVisibility.Invited]: 'After Invite',
|
|
[HistoryVisibility.Joined]: 'After Join',
|
|
[HistoryVisibility.Shared]: 'All Messages',
|
|
[HistoryVisibility.WorldReadable]: 'All Messages (Guests)',
|
|
}),
|
|
[],
|
|
);
|
|
|
|
const useVisibilityMenu = () =>
|
|
useMemo(
|
|
() => [
|
|
HistoryVisibility.Shared,
|
|
HistoryVisibility.Invited,
|
|
HistoryVisibility.Joined,
|
|
HistoryVisibility.WorldReadable,
|
|
],
|
|
[],
|
|
);
|
|
|
|
type RoomHistoryVisibilityProps = {
|
|
permissions: RoomPermissionsAPI;
|
|
};
|
|
export function RoomHistoryVisibility({ permissions }: RoomHistoryVisibilityProps) {
|
|
const mx = useMatrixClient();
|
|
const room = useRoom();
|
|
|
|
const canEdit = permissions.stateEvent(StateEvent.RoomHistoryVisibility, mx.getSafeUserId());
|
|
|
|
const visibilityEvent = useStateEvent(room, StateEvent.RoomHistoryVisibility);
|
|
const historyVisibility: HistoryVisibility =
|
|
visibilityEvent?.getContent<RoomHistoryVisibilityEventContent>().history_visibility ??
|
|
HistoryVisibility.Shared;
|
|
const visibilityMenu = useVisibilityMenu();
|
|
const visibilityStr = useVisibilityStr();
|
|
|
|
const [menuAnchor, setMenuAnchor] = useState<RectCords>();
|
|
|
|
const handleOpenMenu: MouseEventHandler<HTMLButtonElement> = (evt) => {
|
|
setMenuAnchor(evt.currentTarget.getBoundingClientRect());
|
|
};
|
|
|
|
const [submitState, submit] = useAsyncCallback(
|
|
useCallback(
|
|
async (visibility: HistoryVisibility) => {
|
|
const content: RoomHistoryVisibilityEventContent = {
|
|
history_visibility: visibility,
|
|
};
|
|
await sendStateEvent(mx, room.roomId, StateEvent.RoomHistoryVisibility, content);
|
|
},
|
|
[mx, room.roomId],
|
|
),
|
|
);
|
|
const submitting = submitState.status === AsyncStatus.Loading;
|
|
|
|
const handleChange = (visibility: HistoryVisibility) => {
|
|
submit(visibility);
|
|
setMenuAnchor(undefined);
|
|
};
|
|
|
|
return (
|
|
<SequenceCard
|
|
className={SequenceCardStyle}
|
|
variant="SurfaceVariant"
|
|
direction="Column"
|
|
gap="400"
|
|
>
|
|
<SettingTile
|
|
title="Message History Visibility"
|
|
description="Changes to history visibility will only apply to future messages. The visibility of existing history will have no effect."
|
|
after={
|
|
<PopOut
|
|
anchor={menuAnchor}
|
|
position="Bottom"
|
|
align="End"
|
|
content={
|
|
<FocusTrap
|
|
focusTrapOptions={{
|
|
initialFocus: false,
|
|
onDeactivate: () => setMenuAnchor(undefined),
|
|
clickOutsideDeactivates: true,
|
|
isKeyForward: (evt: KeyboardEvent) => evt.key === 'ArrowDown',
|
|
isKeyBackward: (evt: KeyboardEvent) => evt.key === 'ArrowUp',
|
|
escapeDeactivates: stopPropagation,
|
|
}}
|
|
>
|
|
<Menu style={{ padding: config.space.S100 }}>
|
|
{visibilityMenu.map((visibility) => (
|
|
<MenuItem
|
|
key={visibility}
|
|
size="300"
|
|
radii="300"
|
|
onClick={() => handleChange(visibility)}
|
|
aria-pressed={visibility === historyVisibility}
|
|
>
|
|
<Text as="span" size="T300" truncate>
|
|
{visibilityStr[visibility]}
|
|
</Text>
|
|
</MenuItem>
|
|
))}
|
|
</Menu>
|
|
</FocusTrap>
|
|
}
|
|
>
|
|
<Button
|
|
variant="Secondary"
|
|
fill="Soft"
|
|
size="300"
|
|
radii="300"
|
|
outlined
|
|
disabled={!canEdit || submitting}
|
|
onClick={handleOpenMenu}
|
|
after={
|
|
submitting ? (
|
|
<Spinner size="100" variant="Secondary" />
|
|
) : (
|
|
<Icon size="100" src={Icons.ChevronBottom} />
|
|
)
|
|
}
|
|
>
|
|
<Text size="B300">{visibilityStr[historyVisibility]}</Text>
|
|
</Button>
|
|
</PopOut>
|
|
}
|
|
>
|
|
{submitState.status === AsyncStatus.Error && (
|
|
<Text style={{ color: color.Critical.Main }} size="T200">
|
|
{(submitState.error as MatrixError).message}
|
|
</Text>
|
|
)}
|
|
</SettingTile>
|
|
</SequenceCard>
|
|
);
|
|
}
|