jaredandClaude Opus 4.8
726cefb5ab
Several localStorage caches held decrypted message content or user PII and survived a normal logout, leaving residue on a shared device (the search index was already wiped; these were not): - cinny_scheduled_messages_v1 - decrypted IContent.body of pending sends - cinny_recent_searches_v1 - search query text - cinny_recent_forward_targets_v1 - recent forward contact/room graph - cinny_recent_gifs_v1 / cinny_recent_stickers_v1 - media the user sent - navToActivePath<userId> - per-space last-visited room paths - (plus the translation cache added earlier) Add a clear function per module and a single auditable clearPlaintextCaches() aggregator, called from both logout paths (logoutClient + the server-forced SessionLoggedOut handler) alongside the existing session/search-index wipes. Unit-tested. Deliberately NOT cleared (documented in the aggregator): unsent composer drafts and the presence status message (preserved by product decision N98); SDK sync/crypto store + io.lotus.* account data (reminders/bookmarks/notes), already wiped by mx.clearStores(); low-sensitivity UI/metadata residue. The forward-targets/gifs/stickers/nav-path additions and the accurate "not covered" documentation address findings from two review passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
55 lines
1.9 KiB
TypeScript
55 lines
1.9 KiB
TypeScript
import { atom } from 'jotai';
|
|
import { atomWithStorage, createJSONStorage } from 'jotai/utils';
|
|
|
|
const STORAGE_KEY = 'cinny_recent_forward_targets_v1';
|
|
const MAX_RECENT_FORWARD_TARGETS = 8;
|
|
|
|
// Internal atom persists as a plain string[] of roomIds (JSON-serializable).
|
|
// getOnInit reads localStorage synchronously so the Recent row is present on the
|
|
// first render of the Forward dialog (no flash of the empty default).
|
|
const internalAtom = atomWithStorage<string[]>(
|
|
STORAGE_KEY,
|
|
[],
|
|
createJSONStorage(() => localStorage),
|
|
{ getOnInit: true },
|
|
);
|
|
|
|
/**
|
|
* Global atom: string[] of the most recent distinct roomIds forwarded to.
|
|
* Most-recent first, deduped, capped at MAX_RECENT_FORWARD_TARGETS.
|
|
* Backed by localStorage (device-local convenience — not synced across devices).
|
|
*/
|
|
export const recentForwardTargetsAtom = atom(
|
|
(get): string[] => get(internalAtom),
|
|
(_get, set, updater: string[] | ((prev: string[]) => string[])) => {
|
|
set(internalAtom, (prev) => {
|
|
const prevList = Array.isArray(prev) ? prev : [];
|
|
const next = typeof updater === 'function' ? updater(prevList) : updater;
|
|
return next;
|
|
});
|
|
},
|
|
);
|
|
|
|
/**
|
|
* Prepend a roomId: dedupes, drops empties, moves an existing id to the front,
|
|
* caps at MAX_RECENT_FORWARD_TARGETS.
|
|
*/
|
|
export const addRecentForwardTarget = (prev: string[], roomId: string): string[] => {
|
|
if (!roomId) return prev;
|
|
const withoutDupe = prev.filter((id) => id !== roomId);
|
|
return [roomId, ...withoutDupe].slice(0, MAX_RECENT_FORWARD_TARGETS);
|
|
};
|
|
|
|
/**
|
|
* Wipe persisted recent forward targets. Called on logout — the list is the
|
|
* user's recent messaging contact/room graph (PII) and must not survive a
|
|
* session on a shared device.
|
|
*/
|
|
export const clearRecentForwardTargets = (): void => {
|
|
try {
|
|
localStorage.removeItem(STORAGE_KEY);
|
|
} catch {
|
|
/* localStorage unavailable — nothing to clear */
|
|
}
|
|
};
|