This is documented as intentional so the existing no-explicit-any warnings stay informational, but the side effect is that every other warning-level rule is also invisible in CI — including react-hooks/exhaustive-deps, which is the rule most likely to flag the stale-closure and missing-cleanup bugs found in this audit (#31 soundboard stale count, #47 profile fetch clobber).
Suggested fix
Either promote react-hooks/exhaustive-deps and react-hooks/rules-of-hooks to error in eslint.config.mjs (fixing or explicitly disabling the current hits), or run eslint --max-warnings <current count> so the count can only go down. Leave no-explicit-any as a warning.
Filed from the September 2026 client audit (CI pipeline review, branch lotus @ 4bea4895).
**Location:** `package.json` → `check:eslint: "eslint src/*"`, `.gitea/workflows/ci.yml` comment "eslint gates on errors only"
### Problem
This is documented as intentional so the existing `no-explicit-any` warnings stay informational, but the side effect is that every other warning-level rule is also invisible in CI — including `react-hooks/exhaustive-deps`, which is the rule most likely to flag the stale-closure and missing-cleanup bugs found in this audit (#31 soundboard stale count, #47 profile fetch clobber).
### Suggested fix
Either promote `react-hooks/exhaustive-deps` and `react-hooks/rules-of-hooks` to `error` in `eslint.config.mjs` (fixing or explicitly disabling the current hits), or run `eslint --max-warnings <current count>` so the count can only go down. Leave `no-explicit-any` as a warning.
---
_Filed from the September 2026 client audit (CI pipeline review, branch `lotus` @ 4bea4895)._
jared
added this to the Audit 2026-09 · Medium & Low milestone 2026-09-12 01:57:45 -04:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Location:
package.json→check:eslint: "eslint src/*",.gitea/workflows/ci.ymlcomment "eslint gates on errors only"Problem
This is documented as intentional so the existing
no-explicit-anywarnings stay informational, but the side effect is that every other warning-level rule is also invisible in CI — includingreact-hooks/exhaustive-deps, which is the rule most likely to flag the stale-closure and missing-cleanup bugs found in this audit (#31 soundboard stale count, #47 profile fetch clobber).Suggested fix
Either promote
react-hooks/exhaustive-depsandreact-hooks/rules-of-hookstoerrorineslint.config.mjs(fixing or explicitly disabling the current hits), or runeslint --max-warnings <current count>so the count can only go down. Leaveno-explicit-anyas a warning.Filed from the September 2026 client audit (CI pipeline review, branch
lotus@4bea4895).