_pipMode is assigned by setPipMode() (called from an effect in CallEmbedProvider on every pip transition) but is never read anywhere in the class or the codebase — the comment "so it can adjust behavior accordingly" describes behaviour that does not exist. It reads as a live invariant during review and hides the fact that CallControl has no PiP-specific behaviour at all.
How to trigger
n/a (static).
Suggested fix
delete _pipMode/setPipMode and the effect, or implement the intended PiP behaviour.
Filed from the September 2026 client audit (branch lotus @ 4bea4895).
**Severity:** low · **Type:** tech-debt · **Confidence:** high
**Location:** `src/app/plugins/call/CallControl.ts:36,425-427`, `src/app/components/CallEmbedProvider.tsx:724-727`
### Problem
`_pipMode` is assigned by `setPipMode()` (called from an effect in `CallEmbedProvider` on every pip transition) but is never read anywhere in the class or the codebase — the comment "so it can adjust behavior accordingly" describes behaviour that does not exist. It reads as a live invariant during review and hides the fact that `CallControl` has no PiP-specific behaviour at all.
### How to trigger
n/a (static).
### Suggested fix
delete `_pipMode`/`setPipMode` and the effect, or implement the intended PiP behaviour.
---
_Filed from the September 2026 client audit (branch `lotus` @ 4bea4895)._
jared
added this to the Audit 2026-09 · Medium & Low milestone 2026-09-12 01:51:19 -04:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Severity: low · Type: tech-debt · Confidence: high
Location:
src/app/plugins/call/CallControl.ts:36,425-427,src/app/components/CallEmbedProvider.tsx:724-727Problem
_pipModeis assigned bysetPipMode()(called from an effect inCallEmbedProvideron every pip transition) but is never read anywhere in the class or the codebase — the comment "so it can adjust behavior accordingly" describes behaviour that does not exist. It reads as a live invariant during review and hides the fact thatCallControlhas no PiP-specific behaviour at all.How to trigger
n/a (static).
Suggested fix
delete
_pipMode/setPipModeand the effect, or implement the intended PiP behaviour.Filed from the September 2026 client audit (branch
lotus@4bea4895).