Problem:src/client/secretStorageKeys.js was untyped JS and reached createClient behind cryptoCallbacks as any. That cast hid a real mismatch: getSecretStorageKey returned undefined when no key is cached, but the SDK's CryptoCallbacks type says null.
Change
The module is now TypeScript, typed against the SDK's CryptoCallbacks, and the cast is gone.
It returns null when no key is cached.
storePrivateKey accepts any Uint8Array and keeps its own copy, on a plain ArrayBuffer, which is what the callback type requires.
Behaviour is otherwise unchanged.
Survey of the remaining as any in app code (14 left, excluding tests): most are single, documented boundary casts that each keep their call sites typed: account data with custom event types, sendStateEvent for custom state, and the correlated generic in useRoomsListener. The partial fake event in local message search is the same kind. I left them as they are.
Tested
New unit test for the key cache: null when unknown, the key once stored, the input is copied, clearSecretStorageKeys works, and invalid input is rejected.
1,441 unit tests pass, and tsc is clean.
Build succeeds.
Playwright, 9/9: key-upload-recovery (recovery-key unlock), security-nudge and boot.
Part of #210 (typing hygiene).
**Problem:** `src/client/secretStorageKeys.js` was untyped JS and reached `createClient` behind `cryptoCallbacks as any`. That cast hid a real mismatch: `getSecretStorageKey` returned `undefined` when no key is cached, but the SDK's `CryptoCallbacks` type says `null`.
**Change**
- The module is now TypeScript, typed against the SDK's `CryptoCallbacks`, and the cast is gone.
- It returns `null` when no key is cached.
- `storePrivateKey` accepts any `Uint8Array` and keeps its own copy, on a plain `ArrayBuffer`, which is what the callback type requires.
- Behaviour is otherwise unchanged.
**Survey of the remaining `as any` in app code** (14 left, excluding tests): most are single, documented boundary casts that each keep their call sites typed: account data with custom event types, `sendStateEvent` for custom state, and the correlated generic in `useRoomsListener`. The partial fake event in local message search is the same kind. I left them as they are.
**Tested**
- New unit test for the key cache: `null` when unknown, the key once stored, the input is copied, `clearSecretStorageKeys` works, and invalid input is rejected.
- 1,441 unit tests pass, and tsc is clean.
- Build succeeds.
- Playwright, 9/9: key-upload-recovery (recovery-key unlock), security-nudge and boot.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
secretStorageKeys was untyped JS, passed to createClient behind `as any`,
which hid that getSecretStorageKey returned undefined where the SDK type
says null. Now TypeScript against the SDK's CryptoCallbacks, returns null,
and storePrivateKey keeps its own copy of the key. Unit test added.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
jared
scheduled this pull request to auto merge when all checks succeed 2026-10-25 19:40:22 -04:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Part of #210 (typing hygiene).
Problem:
src/client/secretStorageKeys.jswas untyped JS and reachedcreateClientbehindcryptoCallbacks as any. That cast hid a real mismatch:getSecretStorageKeyreturnedundefinedwhen no key is cached, but the SDK'sCryptoCallbackstype saysnull.Change
CryptoCallbacks, and the cast is gone.nullwhen no key is cached.storePrivateKeyaccepts anyUint8Arrayand keeps its own copy, on a plainArrayBuffer, which is what the callback type requires.Survey of the remaining
as anyin app code (14 left, excluding tests): most are single, documented boundary casts that each keep their call sites typed: account data with custom event types,sendStateEventfor custom state, and the correlated generic inuseRoomsListener. The partial fake event in local message search is the same kind. I left them as they are.Tested
nullwhen unknown, the key once stored, the input is copied,clearSecretStorageKeysworks, and invalid input is rejected.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5